Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/netsurf: do not allow on static linking configurations
Date: Thu,  9 May 2019 22:28:08 +0200	[thread overview]
Message-ID: <20190509202808.6741-3-thomas.petazzoni@bootlin.com> (raw)
In-Reply-To: <20190509202808.6741-1-thomas.petazzoni@bootlin.com>

Static linking does not work properly in netsurf, nobody fixed it, and
the netsurf build system is completely broken. Let's disable the
package for static linking configurations.

Fixes:

  http://autobuild.buildroot.net/results/28b43c29e241080e23c87145797ea00dc4b3970d/

Signed-off-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/netsurf/Config.in | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/package/netsurf/Config.in b/package/netsurf/Config.in
index 8a301e6218..30b2695309 100644
--- a/package/netsurf/Config.in
+++ b/package/netsurf/Config.in
@@ -1,5 +1,10 @@
+comment "netsurf needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
+
 config BR2_PACKAGE_NETSURF
 	bool "netsurf"
+	# static linking support is broken beyond repair
+	depends on !BR2_STATIC_LIBS
 	select BR2_PACKAGE_EXPAT
 	select BR2_PACKAGE_JPEG
 	select BR2_PACKAGE_LIBICONV if !BR2_ENABLE_LOCALE
-- 
2.21.0

  parent reply	other threads:[~2019-05-09 20:28 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-09 20:28 [Buildroot] [PATCH 0/2] Some more netsurf fixes Thomas Petazzoni
2019-05-09 20:28 ` [Buildroot] [PATCH 1/2] package/netsurf: change how CFLAGS/LDFLAGS are passed Thomas Petazzoni
2019-05-09 20:52   ` Thomas Petazzoni
2019-05-14 21:12     ` Peter Korsgaard
2019-06-05 21:01   ` Peter Korsgaard
2019-05-09 20:28 ` Thomas Petazzoni [this message]
2019-05-14 21:13   ` [Buildroot] [PATCH 2/2] package/netsurf: do not allow on static linking configurations Peter Korsgaard
2019-06-05 21:01   ` Peter Korsgaard
2019-05-26 11:42 ` [Buildroot] [PATCH 0/2] Some more netsurf fixes Arnout Vandecappelle
2019-05-26 21:15   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190509202808.6741-3-thomas.petazzoni@bootlin.com \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox