* [Buildroot] [PATCH] package/cog: install to staging
@ 2019-05-16 9:58 Charlie Turner
2019-05-16 13:27 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Charlie Turner @ 2019-05-16 9:58 UTC (permalink / raw)
To: buildroot
This is useful when unstripped libraries are installed into staging. It
allows the cog executable to be debugged.
---
package/cog/cog.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/cog/cog.mk b/package/cog/cog.mk
index 43f13152c8..6bbffcfc8e 100644
--- a/package/cog/cog.mk
+++ b/package/cog/cog.mk
@@ -9,6 +9,7 @@ COG_SITE = $(call github,Igalia,cog,$(COG_VERSION))
COG_DEPENDENCIES = dbus wpewebkit wpebackend-fdo
COG_LICENSE = MIT
COG_LICENSE_FILES = COPYING
+COG_INSTALL_STAGING = YES
COG_CONF_OPTS = \
-DCOG_BUILD_PROGRAMS=ON \
-DCOG_PLATFORM_FDO=ON \
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/cog: install to staging
2019-05-16 9:58 [Buildroot] [PATCH] package/cog: install to staging Charlie Turner
@ 2019-05-16 13:27 ` Thomas Petazzoni
2019-05-17 14:29 ` Adrian Perez de Castro
0 siblings, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-05-16 13:27 UTC (permalink / raw)
To: buildroot
Hello Charlie,
On Thu, 16 May 2019 10:58:58 +0100
Charlie Turner <cturner@igalia.com> wrote:
> This is useful when unstripped libraries are installed into staging. It
> allows the cog executable to be debugged.
Missing Signed-off-by line, but an identical patch was already proposed
by Adrian:
http://patchwork.ozlabs.org/patch/1100157/
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/cog: install to staging
2019-05-16 13:27 ` Thomas Petazzoni
@ 2019-05-17 14:29 ` Adrian Perez de Castro
2019-05-17 15:02 ` Thomas Petazzoni
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Perez de Castro @ 2019-05-17 14:29 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Thu, 16 May 2019 15:27:50 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Charlie,
>
> On Thu, 16 May 2019 10:58:58 +0100
> Charlie Turner <cturner@igalia.com> wrote:
>
> > This is useful when unstripped libraries are installed into staging. It
> > allows the cog executable to be debugged.
>
> Missing Signed-off-by line, but an identical patch was already proposed
> by Adrian:
>
> http://patchwork.ozlabs.org/patch/1100157/
Today I had a quick private chat with Charlie and we have agreed on
withdrawing his patch and go ahead with mine :-)
Cheers,
?Adri?n
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190517/4a79388b/attachment.asc>
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] package/cog: install to staging
2019-05-17 14:29 ` Adrian Perez de Castro
@ 2019-05-17 15:02 ` Thomas Petazzoni
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Petazzoni @ 2019-05-17 15:02 UTC (permalink / raw)
To: buildroot
On Fri, 17 May 2019 17:29:11 +0300
Adrian Perez de Castro <aperez@igalia.com> wrote:
> > Missing Signed-off-by line, but an identical patch was already proposed
> > by Adrian:
> >
> > http://patchwork.ozlabs.org/patch/1100157/
>
> Today I had a quick private chat with Charlie and we have agreed on
> withdrawing his patch and go ahead with mine :-)
Thanks. I had already marked Charlie's patch as "Not Applicable" in
patchwork.
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-05-17 15:02 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-16 9:58 [Buildroot] [PATCH] package/cog: install to staging Charlie Turner
2019-05-16 13:27 ` Thomas Petazzoni
2019-05-17 14:29 ` Adrian Perez de Castro
2019-05-17 15:02 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox