Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
Date: Fri, 17 May 2019 11:26:28 +0200	[thread overview]
Message-ID: <20190517112628.0acd34d1@windsurf> (raw)
In-Reply-To: <20190517092232.27749-1-victor.huesca@bootlin.com>

Hello Victor,

On Fri, 17 May 2019 11:22:32 +0200
Victor Huesca <victor.huesca@bootlin.com> wrote:

> Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
> ---
>  package/dhcpcd/dhcpcd.hash | 6 +++---
>  package/dhcpcd/dhcpcd.mk   | 2 +-
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/package/dhcpcd/dhcpcd.hash b/package/dhcpcd/dhcpcd.hash
> index 605e87609e..6769cdac49 100644
> --- a/package/dhcpcd/dhcpcd.hash
> +++ b/package/dhcpcd/dhcpcd.hash
> @@ -1,4 +1,4 @@
> -# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
> -sha256	a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e	dhcpcd-7.0.3.tar.xz
> +# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
> +sha256	3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e	dhcpcd-7.2.2.tar.xz
>  # Locally calculated
> -sha256	b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947	LICENSE
> +sha256	213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303	LICENSE

When the LICENSE file has changed, we like to have an explanation in
the commit log about what changed. This way, we are sure the actual
change in the license file has been verified by someone, especially to
make sure that the license terms of the package have not changed.

Most of the time, the change is just that the copyright year has been
updated, but it's always important to check that. So just do a diff
between the old LICENSE and the new LICENSE file to see what the
differences are, and summarize that in the commit log.

Otherwise, looks good to me. Did you use ./utils/test-pkg to verify
that everything was building fine for this package after the version
bump ?

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-05-17  9:26 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-17  9:22 [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2 Victor Huesca
2019-05-17  9:26 ` Thomas Petazzoni [this message]
2019-05-17 10:05   ` Victor Huesca
  -- strict thread matches above, loose matches on Subject: below --
2019-05-17 10:06 Victor Huesca
2019-05-18 19:22 ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190517112628.0acd34d1@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox