* [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
@ 2019-05-17 9:22 Victor Huesca
2019-05-17 9:26 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Victor Huesca @ 2019-05-17 9:22 UTC (permalink / raw)
To: buildroot
Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
---
package/dhcpcd/dhcpcd.hash | 6 +++---
package/dhcpcd/dhcpcd.mk | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/dhcpcd/dhcpcd.hash b/package/dhcpcd/dhcpcd.hash
index 605e87609e..6769cdac49 100644
--- a/package/dhcpcd/dhcpcd.hash
+++ b/package/dhcpcd/dhcpcd.hash
@@ -1,4 +1,4 @@
-# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
-sha256 a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e dhcpcd-7.0.3.tar.xz
+# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
+sha256 3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e dhcpcd-7.2.2.tar.xz
# Locally calculated
-sha256 b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947 LICENSE
+sha256 213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303 LICENSE
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index ae16c340d6..a0f0c2bf42 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -4,7 +4,7 @@
#
################################################################################
-DHCPCD_VERSION = 7.0.3
+DHCPCD_VERSION = 7.2.2
DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.xz
DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd
DHCPCD_DEPENDENCIES = host-pkgconf
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
2019-05-17 9:22 [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2 Victor Huesca
@ 2019-05-17 9:26 ` Thomas Petazzoni
2019-05-17 10:05 ` Victor Huesca
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-05-17 9:26 UTC (permalink / raw)
To: buildroot
Hello Victor,
On Fri, 17 May 2019 11:22:32 +0200
Victor Huesca <victor.huesca@bootlin.com> wrote:
> Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
> ---
> package/dhcpcd/dhcpcd.hash | 6 +++---
> package/dhcpcd/dhcpcd.mk | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/package/dhcpcd/dhcpcd.hash b/package/dhcpcd/dhcpcd.hash
> index 605e87609e..6769cdac49 100644
> --- a/package/dhcpcd/dhcpcd.hash
> +++ b/package/dhcpcd/dhcpcd.hash
> @@ -1,4 +1,4 @@
> -# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
> -sha256 a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e dhcpcd-7.0.3.tar.xz
> +# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
> +sha256 3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e dhcpcd-7.2.2.tar.xz
> # Locally calculated
> -sha256 b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947 LICENSE
> +sha256 213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303 LICENSE
When the LICENSE file has changed, we like to have an explanation in
the commit log about what changed. This way, we are sure the actual
change in the license file has been verified by someone, especially to
make sure that the license terms of the package have not changed.
Most of the time, the change is just that the copyright year has been
updated, but it's always important to check that. So just do a diff
between the old LICENSE and the new LICENSE file to see what the
differences are, and summarize that in the commit log.
Otherwise, looks good to me. Did you use ./utils/test-pkg to verify
that everything was building fine for this package after the version
bump ?
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
2019-05-17 9:26 ` Thomas Petazzoni
@ 2019-05-17 10:05 ` Victor Huesca
0 siblings, 0 replies; 5+ messages in thread
From: Victor Huesca @ 2019-05-17 10:05 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Fri, 17 May 2019 11:26 +0200
Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> When the LICENSE file has changed, we like to have an explanation in
> the commit log about what changed. This way, we are sure the actual
> change in the license file has been verified by someone, especially to
> make sure that the license terms of the package have not changed.
>
> Most of the time, the change is just that the copyright year has been
> updated, but it's always important to check that. So just do a diff
> between the old LICENSE and the new LICENSE file to see what the
> differences are, and summarize that in the commit log.
You're right it was just the copyright year that has been updated to
2019. I will submit a new patch according to it.
> Otherwise, looks good to me. Did you use ./utils/test-pkg to verify
> that everything was building fine for this package after the version
> bump ?
Yes, all test passed with success.
Victor
--
Victor Huesca, Bootlin
Embedded Linux and kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
@ 2019-05-17 10:06 Victor Huesca
2019-05-18 19:22 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Victor Huesca @ 2019-05-17 10:06 UTC (permalink / raw)
To: buildroot
The license file only got updated to 2019.
Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
---
package/dhcpcd/dhcpcd.hash | 6 +++---
package/dhcpcd/dhcpcd.mk | 2 +-
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/package/dhcpcd/dhcpcd.hash b/package/dhcpcd/dhcpcd.hash
index 605e87609e..6769cdac49 100644
--- a/package/dhcpcd/dhcpcd.hash
+++ b/package/dhcpcd/dhcpcd.hash
@@ -1,4 +1,4 @@
-# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.0.3.tar.xz.distinfo.asc
-sha256 a255d9aecceb1c77a9862f1c0d31a48ba37aab5ef2ca5ad76fc7a907b6ea292e dhcpcd-7.0.3.tar.xz
+# sha256 from ftp://roy.marples.name/pub/dhcpcd/dhcpcd-7.2.2.tar.xz.distinfo
+sha256 3db7ff18cba9274da1d2176fb3c7cbe23926a8e58d5c8e244ad55c62d38ba09e dhcpcd-7.2.2.tar.xz
# Locally calculated
-sha256 b120a64b92cfb2453b61df4457a3c0eb163ef9c1c397822826756a31581f3947 LICENSE
+sha256 213fc1a704cecdb322276fa7c95891fd1c23137d9ab572af1fc5e91b48762303 LICENSE
diff --git a/package/dhcpcd/dhcpcd.mk b/package/dhcpcd/dhcpcd.mk
index ae16c340d6..a0f0c2bf42 100644
--- a/package/dhcpcd/dhcpcd.mk
+++ b/package/dhcpcd/dhcpcd.mk
@@ -4,7 +4,7 @@
#
################################################################################
-DHCPCD_VERSION = 7.0.3
+DHCPCD_VERSION = 7.2.2
DHCPCD_SOURCE = dhcpcd-$(DHCPCD_VERSION).tar.xz
DHCPCD_SITE = http://roy.marples.name/downloads/dhcpcd
DHCPCD_DEPENDENCIES = host-pkgconf
--
2.21.0
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2
2019-05-17 10:06 Victor Huesca
@ 2019-05-18 19:22 ` Thomas Petazzoni
0 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni @ 2019-05-18 19:22 UTC (permalink / raw)
To: buildroot
On Fri, 17 May 2019 12:06:54 +0200
Victor Huesca <victor.huesca@bootlin.com> wrote:
> The license file only got updated to 2019.
>
> Signed-off-by: Victor Huesca <victor.huesca@bootlin.com>
> ---
> package/dhcpcd/dhcpcd.hash | 6 +++---
> package/dhcpcd/dhcpcd.mk | 2 +-
> 2 files changed, 4 insertions(+), 4 deletions(-)
Applied to next, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-05-18 19:22 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-05-17 9:22 [Buildroot] [PATCH] package/dhcpcd: bump version to 7.2.2 Victor Huesca
2019-05-17 9:26 ` Thomas Petazzoni
2019-05-17 10:05 ` Victor Huesca
-- strict thread matches above, loose matches on Subject: below --
2019-05-17 10:06 Victor Huesca
2019-05-18 19:22 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox