From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/meson: Fix linking of shared/static libs with static libs
Date: Sat, 18 May 2019 21:56:37 +0200 [thread overview]
Message-ID: <20190518215637.2ea2ea51@windsurf> (raw)
In-Reply-To: <20190514184245.92222-1-aduskett@gmail.com>
Hello,
+Peter Seiderer in Cc. Peter, if you could review the below patch, it
would be nice.
On Tue, 14 May 2019 14:42:45 -0400
aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> From https://github.com/mesonbuild/meson/pull/3939:
>
> This commit contains the following fixes:
>
> 1. When a shared library A does link_with: to static library B, the
> parts of B used by A will be added to A, and so we don't need to
> return B in A.get_dependencies() for targets that link to A. This
> already is the behaviour when a shared library A does link_whole:
> on B.
>
> 2. In situation (1), when generating a pkg-config file for A, we must
> also not add B to Libs.private for A. This already is the behaviour
> when a shared library A does link_whole: on B.
>
> 3. When a static library A does link_whole: to static library B, we
> must add the objects in B to A.
>
> 4. When a static library A does link_with: to static library B, and
> B is not installed (which makes it an internal static library), we
> must add the objects in B to A, otherwise nothing can use A.
>
> 5. In situation (4), when generating a pkg-config file for A, we must
> also not add B to Libs.private for A.
>
> Without this patch, static builds of libglib2 and gstreamer using the
> meson build system will not compile and link properly.
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
Adam: is this for next or master ? Since libglib2 and gstreamer in
master are still using autotools, I would suppose this patch is for
next. Could you confirm ?
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-05-18 19:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 18:42 [Buildroot] [PATCH 1/1] package/meson: Fix linking of shared/static libs with static libs aduskett at gmail.com
2019-05-18 19:56 ` Thomas Petazzoni [this message]
2019-05-20 15:41 ` Adam Duskett
2019-05-20 18:26 ` Peter Seiderer
2019-05-20 18:45 ` Thomas Petazzoni
2019-05-21 16:54 ` Peter Seiderer
2019-06-08 18:02 ` Adam Duskett
2019-06-08 20:40 ` Arnout Vandecappelle
2019-05-20 18:28 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190518215637.2ea2ea51@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox