From: Peter Seiderer <ps.report@gmx.net>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/meson: Fix linking of shared/static libs with static libs
Date: Tue, 21 May 2019 18:54:47 +0200 [thread overview]
Message-ID: <20190521185447.2de12554@gmx.net> (raw)
In-Reply-To: <20190520204517.52564b80@windsurf.home>
Hello Thomas,
On Mon, 20 May 2019 20:45:17 +0200, Thomas Petazzoni <thomas.petazzoni@bootlin.com> wrote:
> Hello Peter,
>
> Thanks for your feedback!
>
> On Mon, 20 May 2019 20:26:15 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
>
> > I can confirm the patch fixes the gstreamer static build/static libs
> > problem (see [1])....
> >
> > But as it is a (not yet) upstream committed bugfix, maybe it is better to
> > wait for a upstream committ and/or next meson version bump?
>
> That would of course be the best approach...
>
> > On the other side the gstreamer folks where bored with waiting for the
> > meson fix to be accepted and committed an workaround for the problem
> > already (see [2])...
> >
> > Conclusion: Take the patch in case there is already a buildroot
> > in-tree package which needs the fix (or commit the patch with
> > in series with a in-tree user), otherwise wait for meson
> > upstream...
>
> ... however, if it starts holding off bumping too many packages, I
> guess we'll have to take this patch. Having to add a !BR2_STATIC_LIBS
> dependency to libglib2 would be really horrible, considering the number
> of reverse dependencies that libglib2 has.
As far as I know only gstreamer itself is affected (the only package
linking a static library using an internal static helper library)?
But the first other package affected by this bug justifies the
patch applied ;-)
>
> At least, if the problem is acknowledged upstream, we know it will be
> fixed at some point. Perhaps not with the exact patch we will have, but
> at least it will be fixed, which means we won't have to carry this
> patch forever.
Yes...
Regards,
Peter
>
> Thomas
next prev parent reply other threads:[~2019-05-21 16:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 18:42 [Buildroot] [PATCH 1/1] package/meson: Fix linking of shared/static libs with static libs aduskett at gmail.com
2019-05-18 19:56 ` Thomas Petazzoni
2019-05-20 15:41 ` Adam Duskett
2019-05-20 18:26 ` Peter Seiderer
2019-05-20 18:45 ` Thomas Petazzoni
2019-05-21 16:54 ` Peter Seiderer [this message]
2019-06-08 18:02 ` Adam Duskett
2019-06-08 20:40 ` Arnout Vandecappelle
2019-05-20 18:28 ` Peter Seiderer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190521185447.2de12554@gmx.net \
--to=ps.report@gmx.net \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox