[Buildroot] [PATCH v1 1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters

[Buildroot] [PATCH v1 1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/armadeus/readme.txt | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/board/armadeus/readme.txt b/board/armadeus/readme.txt
index 98c7b08249..c03508c604 100644
--- a/board/armadeus/readme.txt
+++ b/board/armadeus/readme.txt
@@ -44,11 +44,11 @@ Result of the build
 When the build is finished, you will end up with:

     output/images/
-    ??? imx**-apfxxdev.dtb	[1]
-    ??? rootfs.tar
-    ??? rootfs.ubi
-    ??? rootfs.ubifs
-    ??? uImage
+    +-- imx**-apfxxdev.dtb	[1]
+    +-- rootfs.tar
+    +-- rootfs.ubi
+    +-- rootfs.ubifs
+    +-- uImage

 [1] Only if the kernel version used uses a Device Tree.

--
2.21.0

[Buildroot] [PATCH v1 2/5] board/beagleboardx15: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/beagleboardx15/readme.txt | 22 +++++++++++-----------
 1 file changed, 11 insertions(+), 11 deletions(-)

diff --git a/board/beagleboardx15/readme.txt b/board/beagleboardx15/readme.txt
index 56ebca8c5f..5af2c914ba 100644
--- a/board/beagleboardx15/readme.txt
+++ b/board/beagleboardx15/readme.txt
@@ -26,17 +26,17 @@ Result of the build
 After building, you should get a tree like this:

   output/images/
-  ??? am57xx-beagle-x15.dtb
-  ??? am57xx-beagle-x15-revb1.dtb
-  ??? boot.vfat
-  ??? MLO
-  ??? rootfs.ext2
-  ??? rootfs.ext4
-  ??? rootfs.tar
-  ??? sdcard.img
-  ??? u-boot.img
-  ??? u-boot-spl.bin
-  ??? zImage
+  +-- am57xx-beagle-x15.dtb
+  +-- am57xx-beagle-x15-revb1.dtb
+  +-- boot.vfat
+  +-- MLO
+  +--rootfs.ext2
+  +-- rootfs.ext4
+  +-- rootfs.tar
+  +-- sdcard.img
+  +-- u-boot.img
+  +-- u-boot-spl.bin
+  +-- zImage

 How to write the microSD card
 =============================
--
2.21.0

[Buildroot] [PATCH v1 3/5] board/beaglebone: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/beaglebone/readme.txt | 24 ++++++++++++------------
 1 file changed, 12 insertions(+), 12 deletions(-)

diff --git a/board/beaglebone/readme.txt b/board/beaglebone/readme.txt
index e908b22235..e6647dad2a 100644
--- a/board/beaglebone/readme.txt
+++ b/board/beaglebone/readme.txt
@@ -27,18 +27,18 @@ $ make
 Result of the build
 ===================
 output/images/
-??? am335x-boneblack.dtb
-??? am335x-bone.dtb
-??? am335x-evm.dtb
-??? am335x-evmsk.dtb
-??? boot.vfat
-??? MLO
-??? rootfs.ext2
-??? rootfs.tar
-??? sdcard.img
-??? u-boot.img
-??? uEnv.txt
-??? zImage
++-- am335x-boneblack.dtb
++-- am335x-bone.dtb
++-- am335x-evm.dtb
++-- am335x-evmsk.dtb
++-- boot.vfat
++-- MLO
++-- rootfs.ext2
++-- rootfs.tar
++-- sdcard.img
++-- u-boot.img
++-- uEnv.txt
++-- zImage

 To copy the image file to the sdcard use dd:
 $ dd if=output/images/sdcard.img of=/dev/XXX
--
2.21.0

[Buildroot] [PATCH v1 4/5] board/csky: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/csky/readme.txt | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/board/csky/readme.txt b/board/csky/readme.txt
index b4605c541e..dc82dcc1d7 100644
--- a/board/csky/readme.txt
+++ b/board/csky/readme.txt
@@ -41,9 +41,9 @@ Result of the build
 After building, you should obtain this tree:

     output/images/
-    ??? vmlinux
-    ??? rootfs.ext2
-    ??? <board name>.dtb
+    +-- vmlinux
+    +-- rootfs.ext2
+    +-- <board name>.dtb

 How to run it
 =============
--
2.21.0

[Buildroot] [PATCH v1 5/5] board/pandaboard: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Signed-off-by: Peter Seiderer <ps.report@gmx.net>
---
 board/pandaboard/readme.txt | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

diff --git a/board/pandaboard/readme.txt b/board/pandaboard/readme.txt
index 1e4820b828..80a20c2743 100644
--- a/board/pandaboard/readme.txt
+++ b/board/pandaboard/readme.txt
@@ -23,14 +23,14 @@ When you are happy with the setup, run:
 The result of the build with the default settings should be these files:

   output/images
-  ??? MLO
-  ??? omap4-panda-a4.dtb
-  ??? omap4-panda.dtb
-  ??? omap4-panda-es.dtb
-  ??? rootfs.ext4
-  ??? sdcard.img
-  ??? u-boot.img
-  ??? zImage
+  +-- MLO
+  +-- omap4-panda-a4.dtb
+  +-- omap4-panda.dtb
+  +-- omap4-panda-es.dtb
+  +-- rootfs.ext4
+  +-- sdcard.img
+  +-- u-boot.img
+  +-- zImage

 How to write the SD card
 ------------------------
--
2.21.0

[Buildroot] [PATCH v1 1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters

[Thomas Petazzoni]

On Wed,  8 May 2019 19:28:18 +0200
Peter Seiderer <ps.report@gmx.net> wrote:

> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> ---
>  board/armadeus/readme.txt | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)

Series applied to master. Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v1 1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters

[Yann E. MORIN]

Peter, Thomas, Peter, All,

On 2019-05-18 23:36 +0200, Thomas Petazzoni spake thusly:
> On Wed,  8 May 2019 19:28:18 +0200
> Peter Seiderer <ps.report@gmx.net> wrote:
> 
> > Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> > ---
> >  board/armadeus/readme.txt | 10 +++++-----
> >  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> Series applied to master. Thanks!

Sorry, but I still fail to see why we want to remove non-ascii chars,
especially in docs and the likes. The commit logs for these patches fail
to explain the problem they fix, if there is even a problem.

This whole "no UTF-8 chars patches" are totally nonsense nowadays. If
your system still can't display them properly, upgrade and get a decent
font.

Now, if I need to add a comment like:

    # As explained by Fr?d?ric in [0], blurb da dee woops blabla...

then, check-package whines. While "Fr?d?ric" can be easily asciified to
Frederic, this is not nice and there are a lot of names that can't be
easily asciified, like ??? or anyone whose language is not using a
latin script.

I agree that the unicode NO-BREAK-SPACE (U+00A0, UTF-8 C2A0) is nasty,
and should be replaced, but otherwise it feels like we're going
something like 30 years back in time...

BTW, a good editor can be made to report such "trolling" chars. For
example, there is a plugin for vim that can highlight such chars, like
NO-BREAK-SPACE "?" (U+00A0) which is highlighted red for me here:
    https://github.com/vim-utils/vim-troll-stopper
And for emacs (untested, I don't use emacs):
    https://www.emacswiki.org/emacs/highlight-chars.el

Regards,
Yann E. MORIN.

PS. Yes, I was the first one to report and fix U+00A0 (C2 A0) in
    5d436ac5a6 and 911ac036e0, but those were fixing real problems.
YEM.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'

[Buildroot] [PATCH v1 1/5] board/armadeus: replace utf-8 graphic sympols by ascii characters

[Peter Seiderer]

Hello Yann, and *,

On Sun, 19 May 2019 11:08:53 +0200, "Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Peter, Thomas, Peter, All,
> 
> On 2019-05-18 23:36 +0200, Thomas Petazzoni spake thusly:
> > On Wed,  8 May 2019 19:28:18 +0200
> > Peter Seiderer <ps.report@gmx.net> wrote:
> >   
> > > Signed-off-by: Peter Seiderer <ps.report@gmx.net>--cc "Ricardo Martincoski <ricardo.martincoski@gmail.com>"
> > > ---
> > >  board/armadeus/readme.txt | 10 +++++-----
> > >  1 file changed, 5 insertions(+), 5 deletions(-)  
> > 
> > Series applied to master. Thanks!  
> 
> Sorry, but I still fail to see why we want to remove non-ascii chars,
> especially in docs and the likes. The commit logs for these patches fail
> to explain the problem they fix, if there is even a problem.

Valid point, maybe for the board patches a commit tile a la 'harmonize graphic
symbol usage' would have been better...

> 
> This whole "no UTF-8 chars patches" are totally nonsense nowadays. If
> your system still can't display them properly, upgrade and get a decent
> font.
> 
> Now, if I need to add a comment like:
> 
>     # As explained by Fr?d?ric in [0], blurb da dee woops blabla...
> 
> then, check-package whines. While "Fr?d?ric" can be easily asciified to
> Frederic, this is not nice and there are a lot of names that can't be
> easily asciified, like ??? or anyone whose language is not using a
> latin script.
> 
> I agree that the unicode NO-BREAK-SPACE (U+00A0, UTF-8 C2A0) is nasty,
> and should be replaced, but otherwise it feels like we're going
> something like 30 years back in time...

Yes, Fr?d?ric will surly by honoured to be called by his real name ;-),
but all package patches touched easily replaceable UTF-8 characters
and did not change, by intent, the ones mentioned by Peter Korsgaard
(see [1]) and Arnout Vandecappelle mentioned the From/Sob tags
problem (see [2])...

> 
> BTW, a good editor can be made to report such "trolling" chars. For
> example, there is a plugin for vim that can highlight such chars, like
> NO-BREAK-SPACE "?" (U+00A0) which is highlighted red for me here:
>     https://github.com/vim-utils/vim-troll-stopper
> And for emacs (untested, I don't use emacs):
>     https://www.emacswiki.org/emacs/highlight-chars.el

It is simpler to check for not utf-8 instead of an blacklist of
various characters (no-break-space, multiple quote/hyphen signs, etc.),
maybe the warning can be downgraded to a minor one (plus a hint 'do
not apply to names')...

Regards,
Peter

[1] http://lists.busybox.net/pipermail/buildroot/2019-May/249725.html
[2] http://lists.busybox.net/pipermail/buildroot/2019-May/249716.html

> 
> Regards,
> Yann E. MORIN.
> 
> PS. Yes, I was the first one to report and fix U+00A0 (C2 A0) in
>     5d436ac5a6 and 911ac036e0, but those were fixing real problems.
> YEM.
>