[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Fabrice Fontaine]

Fixes:
 - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libubootenv/Config.in | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/libubootenv/Config.in b/package/libubootenv/Config.in
index 9be52c4522..016497abbb 100644
--- a/package/libubootenv/Config.in
+++ b/package/libubootenv/Config.in
@@ -1,5 +1,6 @@
 config BR2_PACKAGE_LIBUBOOTENV
 	bool "libubootenv"
+	depends on BR2_TOOLCHAIN_HAS_THREADS
 	select BR2_PACKAGE_ZLIB
 	help
 	  libubootenv is a library that provides a hardware independent
@@ -9,3 +10,6 @@ config BR2_PACKAGE_LIBUBOOTENV
 	  new tools build from the library and not from U-Boot.
 
 	  https://github.com/sbabic/libubootenv/
+
+comment "libubootenv needs a toolchain w/ threads"
+	depends on !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.14.1

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Pierre-Jean Texier]

Hi Fabrice,

Le 03/06/2019 ? 21:59, Fabrice Fontaine a ?crit?:
> Fixes:
>   - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Acked-by: Pierre-Jean Texier <pjtexier@koncepto.io>

Thanks for the fix !

> ---
>   package/libubootenv/Config.in | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/package/libubootenv/Config.in b/package/libubootenv/Config.in
> index 9be52c4522..016497abbb 100644
> --- a/package/libubootenv/Config.in
> +++ b/package/libubootenv/Config.in
> @@ -1,5 +1,6 @@
>   config BR2_PACKAGE_LIBUBOOTENV
>   	bool "libubootenv"
> +	depends on BR2_TOOLCHAIN_HAS_THREADS
>   	select BR2_PACKAGE_ZLIB
>   	help
>   	  libubootenv is a library that provides a hardware independent
> @@ -9,3 +10,6 @@ config BR2_PACKAGE_LIBUBOOTENV
>   	  new tools build from the library and not from U-Boot.
>   
>   	  https://github.com/sbabic/libubootenv/
> +
> +comment "libubootenv needs a toolchain w/ threads"
> +	depends on !BR2_TOOLCHAIN_HAS_THREADS
> 

-- 
Best regards,
Pierre-Jean Texier

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Thomas Petazzoni]

Hello,

On Mon,  3 Jun 2019 21:59:26 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

From a very quick glance at the code and a quick build test, the
<pthread.h> include doesn't seem to be necessary. Perhaps it should
simply be removed ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Pierre-Jean Texier]

Hello,

Le 04/06/2019 ? 09:07, Thomas Petazzoni a ?crit?:
> Hello,
> 
> On Mon,  3 Jun 2019 21:59:26 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> 
>> Fixes:
>>   - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> 
>  From a very quick glance at the code and a quick build test, the
> <pthread.h> include doesn't seem to be necessary. Perhaps it should
> simply be removed ?

Indeed, you are right.

If needed, I can send the patch upstream.
I've already updated this on my local branch [1]
and the build is now OK:

- br-arm-full-nothread [1/1]: OK

Thanks,

[1] - 
https://github.com/texierp/buildroot/commit/452941dd7a225e25ef16f71119b277f69eb6ec66
-- 
Best regards,
Pierre-Jean Texier

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Fabrice Fontaine]

Hello,

Le mar. 4 juin 2019 ? 14:05, Pierre-Jean Texier <pjtexier@koncepto.io> a ?crit :
>
> Hello,
>
> Le 04/06/2019 ? 09:07, Thomas Petazzoni a ?crit :
> > Hello,
> >
> > On Mon,  3 Jun 2019 21:59:26 +0200
> > Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> >
> >> Fixes:
> >>   - http://autobuild.buildroot.org/results/813e8951530c093f46b38bf8c3b467ab6535c95b
> >>
> >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> >
> >  From a very quick glance at the code and a quick build test, the
> > <pthread.h> include doesn't seem to be necessary. Perhaps it should
> > simply be removed ?
>
> Indeed, you are right.
>
> If needed, I can send the patch upstream.
I'll mark my patch as "Not applicable" in patchwork. Can you also send
your patch to buildroot?
> I've already updated this on my local branch [1]
> and the build is now OK:
>
> - br-arm-full-nothread [1/1]: OK
>
> Thanks,
>
> [1] -
> https://github.com/texierp/buildroot/commit/452941dd7a225e25ef16f71119b277f69eb6ec66
> --
> Best regards,
> Pierre-Jean Texier
Best Regards,

Fabrice

[Buildroot] [PATCH 1/1] package/libubootenv: needs threads

[Pierre-Jean Texier]

Hello,

Le 04/06/2019 ? 14:24, Fabrice Fontaine a ?crit?:
> I'll mark my patch as "Not applicable" in patchwork. Can you also send
> your patch to buildroot?

Sure, I will do.

Thanks

-- 
Best regards,
Pierre-Jean Texier