From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 1/4] autobuild-run: move creation of result directory to run_instance()
Date: Fri, 14 Jun 2019 16:25:36 +0530 [thread overview]
Message-ID: <20190614105539.16301-1-itsatharva@gmail.com> (raw)
We need the result directory to be present when the check_reproducibility()
function (implemented in the next patch) executes. As of now the results
directory is created in the send_results() function which executes after
check_reproducibility() will.
Signed-off-by: Atharva Lele <itsatharva@gmail.com>
---
Changes v4: Add new patch to series
---
scripts/autobuild-run | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index ef2f2a5..190a254 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -470,8 +470,6 @@ def send_results(result, **kwargs):
srcdir = os.path.join(idir, "buildroot")
resultdir = os.path.join(outputdir, "results")
- os.mkdir(resultdir)
-
shutil.copyfile(os.path.join(outputdir, ".config"),
os.path.join(resultdir, "config"))
shutil.copyfile(os.path.join(outputdir, "defconfig"),
@@ -647,6 +645,9 @@ def run_instance(**kwargs):
if ret != 0:
continue
+ resultdir = os.path.join(idir, "output", "results")
+ os.mkdir(resultdir)
+
ret = gen_config(**kwargs)
if ret != 0:
log_write(kwargs['log'], "WARN: failed to generate configuration")
--
2.20.1
next reply other threads:[~2019-06-14 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 10:55 Atharva Lele [this message]
2019-06-14 10:55 ` [Buildroot] [PATCH v4 2/4] autobuild-run: initial implementation of check_reproducibility() Atharva Lele
2019-06-14 10:55 ` [Buildroot] [PATCH v4 3/4] autobuild-run: initial implementation of do_reproducible_build() Atharva Lele
2019-06-14 10:55 ` [Buildroot] [PATCH v4 4/4] autobuild-run: do reproducible builds tests if BR2_REPRODUCIBLE=y Atharva Lele
2019-06-14 20:28 ` Yann E. MORIN
2019-06-14 20:26 ` [Buildroot] [PATCH v4 1/4] autobuild-run: move creation of result directory to run_instance() Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614105539.16301-1-itsatharva@gmail.com \
--to=itsatharva@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox