From: Atharva Lele <itsatharva@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v4 4/4] autobuild-run: do reproducible builds tests if BR2_REPRODUCIBLE=y
Date: Fri, 14 Jun 2019 16:25:39 +0530 [thread overview]
Message-ID: <20190614105539.16301-4-itsatharva@gmail.com> (raw)
In-Reply-To: <20190614105539.16301-1-itsatharva@gmail.com>
Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Reviewed-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
---
Changes v3 -> v4:
- Fix indentation level for if-else, otherwise file still remains open
for the duration of the build.
Changes v2 -> v3:
- use reproducible flag so that .config is not kept open for the entire
build duration. (suggested by arnout)
- remove reduntant logging (suggested by arnout)
Changes v1 -> v2:
- add trailing newline character to BR2_REPRODUCIBLE=y (suggested by arnout)
---
scripts/autobuild-run | 9 ++++++++-
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git a/scripts/autobuild-run b/scripts/autobuild-run
index b641694..6426c9e 100755
--- a/scripts/autobuild-run
+++ b/scripts/autobuild-run
@@ -727,7 +727,14 @@ def run_instance(**kwargs):
log_write(kwargs['log'], "WARN: failed to generate configuration")
continue
- ret = do_build(**kwargs)
+ # Check if the build test is supposed to be a reproducible test
+ outputdir = os.path.abspath(os.path.join(idir, "output"))
+ with open(os.path.join(outputdir, ".config"), "r") as fconf:
+ reproducible = "BR2_REPRODUCIBLE=y\n" in fconf.read()
+ if reproducible:
+ ret = do_reproducible_build(**kwargs)
+ else:
+ ret = do_build(**kwargs)
send_results(ret, **kwargs)
--
2.20.1
next prev parent reply other threads:[~2019-06-14 10:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-14 10:55 [Buildroot] [PATCH v4 1/4] autobuild-run: move creation of result directory to run_instance() Atharva Lele
2019-06-14 10:55 ` [Buildroot] [PATCH v4 2/4] autobuild-run: initial implementation of check_reproducibility() Atharva Lele
2019-06-14 10:55 ` [Buildroot] [PATCH v4 3/4] autobuild-run: initial implementation of do_reproducible_build() Atharva Lele
2019-06-14 10:55 ` Atharva Lele [this message]
2019-06-14 20:28 ` [Buildroot] [PATCH v4 4/4] autobuild-run: do reproducible builds tests if BR2_REPRODUCIBLE=y Yann E. MORIN
2019-06-14 20:26 ` [Buildroot] [PATCH v4 1/4] autobuild-run: move creation of result directory to run_instance() Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190614105539.16301-4-itsatharva@gmail.com \
--to=itsatharva@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox