* [Buildroot] [PATCH] modem-manager: depend on host-libglib2
@ 2019-06-16 10:11 Aleksander Morgado
2019-06-16 10:23 ` Baruch Siach
0 siblings, 1 reply; 4+ messages in thread
From: Aleksander Morgado @ 2019-06-16 10:11 UTC (permalink / raw)
To: buildroot
The build requires the gdbus-codegen tool from glib2, which isn't
installed in target.
Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
---
Hey,
I'm getting build failures like this one reported via email:
http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log
Not truly sure if this is the correct fix for the issue, but it looks like it could be?
What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.
Cheers!
---
package/modem-manager/modem-manager.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
index aa27dc9ce5..41e37bd655 100644
--- a/package/modem-manager/modem-manager.mk
+++ b/package/modem-manager/modem-manager.mk
@@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
-MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
+MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
MODEM_MANAGER_INSTALL_STAGING = YES
MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
--
2.22.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] modem-manager: depend on host-libglib2
2019-06-16 10:11 [Buildroot] [PATCH] modem-manager: depend on host-libglib2 Aleksander Morgado
@ 2019-06-16 10:23 ` Baruch Siach
2019-06-16 11:40 ` Aleksander Morgado
2019-06-16 11:45 ` Yann E. MORIN
0 siblings, 2 replies; 4+ messages in thread
From: Baruch Siach @ 2019-06-16 10:23 UTC (permalink / raw)
To: buildroot
Hi Aleksander,
On Sun, Jun 16 2019, Aleksander Morgado wrote:
> The build requires the gdbus-codegen tool from glib2, which isn't
> installed in target.
>
> Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> ---
>
> Hey,
>
> I'm getting build failures like this one reported via email:
> http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log
>
> Not truly sure if this is the correct fix for the issue, but it looks like it could be?
>
> What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.
>
> Cheers!
>
> ---
> package/modem-manager/modem-manager.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> index aa27dc9ce5..41e37bd655 100644
> --- a/package/modem-manager/modem-manager.mk
> +++ b/package/modem-manager/modem-manager.mk
> @@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
> +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
libglib2 depends on host-libglib2 already. So technically this doesn't
change anything.
Have you verified that the build failure is fixed with your patch
applied?
> MODEM_MANAGER_INSTALL_STAGING = YES
> MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 4+ messages in thread* [Buildroot] [PATCH] modem-manager: depend on host-libglib2
2019-06-16 10:23 ` Baruch Siach
@ 2019-06-16 11:40 ` Aleksander Morgado
2019-06-16 11:45 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Aleksander Morgado @ 2019-06-16 11:40 UTC (permalink / raw)
To: buildroot
> On Sun, Jun 16 2019, Aleksander Morgado wrote:
> > The build requires the gdbus-codegen tool from glib2, which isn't
> > installed in target.
> >
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >
> > Hey,
> >
> > I'm getting build failures like this one reported via email:
> > http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log
> >
> > Not truly sure if this is the correct fix for the issue, but it looks like it could be?
> >
> > What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.
> >
> > Cheers!
> >
> > ---
> > package/modem-manager/modem-manager.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > index aa27dc9ce5..41e37bd655 100644
> > --- a/package/modem-manager/modem-manager.mk
> > +++ b/package/modem-manager/modem-manager.mk
> > @@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> > MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> > MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> > MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> > -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
> > +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
>
> libglib2 depends on host-libglib2 already. So technically this doesn't
> change anything.
>
> Have you verified that the build failure is fixed with your patch
> applied?
>
See, I wasn't getting the build failure locally anyway myself... so
this was kind of a blind attempt of fixing this, which looks like it's
totally wrong :D
I got pointed to this not-yet-commited patch, which explains my issue
and why only gdbus-codegen (provided by gio) was failing and not
glib-mkenums (provided by glib):
https://patchwork.ozlabs.org/patch/1115572/
The MM build failure will definitely go away once that patch is
merged, sorry for the noise!
--
Aleksander
https://aleksander.es
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH] modem-manager: depend on host-libglib2
2019-06-16 10:23 ` Baruch Siach
2019-06-16 11:40 ` Aleksander Morgado
@ 2019-06-16 11:45 ` Yann E. MORIN
1 sibling, 0 replies; 4+ messages in thread
From: Yann E. MORIN @ 2019-06-16 11:45 UTC (permalink / raw)
To: buildroot
Baruch, Aleksander, Al,
On 2019-06-16 13:23 +0300, Baruch Siach spake thusly:
> On Sun, Jun 16 2019, Aleksander Morgado wrote:
> > The build requires the gdbus-codegen tool from glib2, which isn't
> > installed in target.
As I explained on IRC, this is already the case, via the dbus-glib ->
libglib2 -? host-libglib2 dependency chain.
So, as Baruch notes, this patch would probably not solve the issue.
Instead, we have a patch that should fix the issue:
https://patchwork.ozlabs.org/patch/1115572/
Regards,
Yann E. MORIN.
> > Signed-off-by: Aleksander Morgado <aleksander@aleksander.es>
> > ---
> >
> > Hey,
> >
> > I'm getting build failures like this one reported via email:
> > http://autobuild.buildroot.net/results/5d3e6449887b4cdbfbc0ddc672fa374896cfb102/build-end.log
> >
> > Not truly sure if this is the correct fix for the issue, but it looks like it could be?
> >
> > What I don't know is why gdbus-codegen isn't found, but glib-mkenums (also provided by glib2) doesn't have the same problem.
> >
> > Cheers!
> >
> > ---
> > package/modem-manager/modem-manager.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/modem-manager/modem-manager.mk b/package/modem-manager/modem-manager.mk
> > index aa27dc9ce5..41e37bd655 100644
> > --- a/package/modem-manager/modem-manager.mk
> > +++ b/package/modem-manager/modem-manager.mk
> > @@ -9,7 +9,7 @@ MODEM_MANAGER_SOURCE = ModemManager-$(MODEM_MANAGER_VERSION).tar.xz
> > MODEM_MANAGER_SITE = http://www.freedesktop.org/software/ModemManager
> > MODEM_MANAGER_LICENSE = GPL-2.0+ (programs, plugins), LGPL-2.0+ (libmm-glib)
> > MODEM_MANAGER_LICENSE_FILES = COPYING COPYING.LIB
> > -MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool libglib2
> > +MODEM_MANAGER_DEPENDENCIES = host-pkgconf host-intltool host-libglib2 libglib2
>
> libglib2 depends on host-libglib2 already. So technically this doesn't
> change anything.
>
> Have you verified that the build failure is fixed with your patch
> applied?
>
> > MODEM_MANAGER_INSTALL_STAGING = YES
> > MODEM_MANAGER_CONF_OPTS = --disable-more-warnings
>
> baruch
>
> --
> http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
> =}------------------------------------------------ooO--U--Ooo------------{=
> - baruch at tkos.co.il - tel: +972.52.368.4656, http://www.tkos.co.il -
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-06-16 11:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-16 10:11 [Buildroot] [PATCH] modem-manager: depend on host-libglib2 Aleksander Morgado
2019-06-16 10:23 ` Baruch Siach
2019-06-16 11:40 ` Aleksander Morgado
2019-06-16 11:45 ` Yann E. MORIN
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox