Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] package/coreutils: simplify the [ -> test symlink
@ 2019-06-22 13:19 Yann E. MORIN
  2019-06-22 15:50 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Yann E. MORIN @ 2019-06-22 13:19 UTC (permalink / raw)
  To: buildroot

Wheter we are mutli-call or multi-binaries, test is either a symlink to
coreutils or a standalone binary.

Consequently, test always exists, and so we can simplify the [ symlink.

Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Markus Mayer <mmayer@broadcom.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
---
 package/coreutils/coreutils.mk | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/package/coreutils/coreutils.mk b/package/coreutils/coreutils.mk
index 6b8f3ba4b8..55aa92e753 100644
--- a/package/coreutils/coreutils.mk
+++ b/package/coreutils/coreutils.mk
@@ -130,15 +130,9 @@ COREUTILS_CONF_OPTS += --enable-no-install-program=stdbuf
 endif
 
 # link for archaic shells
-ifeq ($(BR2_PACKAGE_COREUTILS_INDIVIDUAL_BINARIES),y)
 define COREUTILS_CREATE_TEST_SYMLINK
 	ln -fs test $(TARGET_DIR)/usr/bin/[
 endef
-else
-define COREUTILS_CREATE_TEST_SYMLINK
-	ln -fs coreutils $(TARGET_DIR)/usr/bin/[
-endef
-endif
 COREUTILS_POST_INSTALL_TARGET_HOOKS += COREUTILS_CREATE_TEST_SYMLINK
 
 # gnu thinks chroot is in bin, debian thinks it's in sbin
-- 
2.20.1

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH] package/coreutils: simplify the [ -> test symlink
  2019-06-22 13:19 [Buildroot] [PATCH] package/coreutils: simplify the [ -> test symlink Yann E. MORIN
@ 2019-06-22 15:50 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-06-22 15:50 UTC (permalink / raw)
  To: buildroot

On Sat, 22 Jun 2019 15:19:36 +0200
"Yann E. MORIN" <yann.morin.1998@free.fr> wrote:

> Wheter we are mutli-call or multi-binaries, test is either a symlink to
> coreutils or a standalone binary.
> 
> Consequently, test always exists, and so we can simplify the [ symlink.
> 
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Markus Mayer <mmayer@broadcom.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> ---
>  package/coreutils/coreutils.mk | 6 ------
>  1 file changed, 6 deletions(-)

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-06-22 15:50 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-22 13:19 [Buildroot] [PATCH] package/coreutils: simplify the [ -> test symlink Yann E. MORIN
2019-06-22 15:50 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox