From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
Date: Sun, 23 Jun 2019 21:39:33 +0200 [thread overview]
Message-ID: <20190623193933.GM13664@scaer> (raw)
In-Reply-To: <20190113214722.15104-1-ps.report@gmx.net>
Peter, All,
On 2019-01-13 22:47 +0100, Peter Seiderer spake thusly:
> Delivered libcdaudio configure tries to run a C++ check with the
> host C preprocessor. Fix it by enabling autoreconf (needs
> a patch for configure.ac/Makefile.am removing ancient lines).
>
> Fixes [1]:
>
> checking how to run the C++ preprocessor... /lib/cpp
> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
>
> Signed-off-by: Peter Seiderer <ps.report@gmx.net>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
Regards,
Yann E. MORIN.
> ---
> .../0001-libcdaudio-enable-autoreconf.patch | 43 +++++++++++++++++++
> package/libcdaudio/libcdaudio.mk | 3 ++
> 2 files changed, 46 insertions(+)
> create mode 100644 package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
>
> diff --git a/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
> new file mode 100644
> index 0000000000..ab2296c042
> --- /dev/null
> +++ b/package/libcdaudio/0001-libcdaudio-enable-autoreconf.patch
> @@ -0,0 +1,43 @@
> +From 9c2873b1d9292bcf43c862b6777d41c40521424c Mon Sep 17 00:00:00 2001
> +From: Peter Seiderer <ps.report@gmx.net>
> +Date: Sun, 13 Jan 2019 22:27:42 +0100
> +Subject: [PATCH] libcdaudio: enable autoreconf
> +
> +Fixes the following two autoreconf errors (by simple removing of the
> +two offending lines):
> +
> + configure.ac:20: error: automatic de-ANSI-fication support has been removed
> +
> + Makefile.am:2: error: automatic de-ANSI-fication support has been removed
> +
> +Signed-off-by: Peter Seiderer <ps.report@gmx.net>
> +---
> + Makefile.am | 1 -
> + configure.ac | 1 -
> + 2 files changed, 2 deletions(-)
> +
> +diff --git a/Makefile.am b/Makefile.am
> +index f639dd8..a32cfe6 100644
> +--- a/Makefile.am
> ++++ b/Makefile.am
> +@@ -1,5 +1,4 @@
> + ## Process this file with automake to produce Makefile.in
> +-AUTOMAKE_OPTIONS = ansi2knr
> + SUBDIRS = src
> +
> + bin_SCRIPTS = libcdaudio-config
> +diff --git a/configure.ac b/configure.ac
> +index bbdd42d..6699ceb 100644
> +--- a/configure.ac
> ++++ b/configure.ac
> +@@ -17,7 +17,6 @@ AM_CONFIG_HEADER(config.h)
> + AC_PROG_AWK
> + AC_PROG_CC
> + AC_PROG_CPP
> +-AM_C_PROTOTYPES
> + AM_PROG_CC_STDC
> + AC_PROG_INSTALL
> + AC_PROG_LN_S
> +--
> +2.20.1
> +
> diff --git a/package/libcdaudio/libcdaudio.mk b/package/libcdaudio/libcdaudio.mk
> index 5d421eba7a..e2c1496287 100644
> --- a/package/libcdaudio/libcdaudio.mk
> +++ b/package/libcdaudio/libcdaudio.mk
> @@ -11,4 +11,7 @@ LIBCDAUDIO_CONFIG_SCRIPTS = libcdaudio-config
> LIBCDAUDIO_LICENSE = GPL-2.0+
> LIBCDAUDIO_LICENSE_FILES = COPYING
>
> +# fix configure failure on host systems without C++ support
> +LIBCDAUDIO_AUTORECONF = YES
> +
> $(eval $(autotools-package))
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-06-23 19:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-13 21:47 [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support Peter Seiderer
2019-06-23 19:39 ` Yann E. MORIN [this message]
2019-06-23 19:46 ` Thomas Petazzoni
2019-06-25 9:05 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190623193933.GM13664@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox