Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support
Date: Tue, 25 Jun 2019 11:05:24 +0200	[thread overview]
Message-ID: <87sgryhw6j.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190623214605.14a93a24@windsurf> (Thomas Petazzoni's message of "Sun, 23 Jun 2019 21:46:05 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:

 > On Sun, 13 Jan 2019 22:47:22 +0100
 > Peter Seiderer <ps.report@gmx.net> wrote:

 >> Delivered libcdaudio configure tries to run a C++ check with the
 >> host C preprocessor. Fix it by enabling autoreconf  (needs
 >> a patch for configure.ac/Makefile.am removing ancient lines).
 >> 
 >> Fixes [1]:
 >> 
 >> checking how to run the C++ preprocessor... /lib/cpp
 >> configure: error: C++ preprocessor "/lib/cpp" fails sanity check
 >> 
 >> Signed-off-by: Peter Seiderer <ps.report@gmx.net>

 > Contrary to what your commit title says, the problem does not occur
 > when the host system lacks C++ support, it's when the target toolchain
 > doesn't have C++ support. I have an Arch Linux system here (which is
 > where the failure happens), and the host system has C++ support, but
 > doesn't provide /lib/cpp.

 > I fixed up the commit title, commit log, and comment in the .mk file
 > and applied.

Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2019-06-25  9:05 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-13 21:47 [Buildroot] [PATCH v1] libcdaudio: fix compile on host systems without C++ support Peter Seiderer
2019-06-23 19:39 ` Yann E. MORIN
2019-06-23 19:46 ` Thomas Petazzoni
2019-06-25  9:05   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87sgryhw6j.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox