[Buildroot] Generation of locales

[Buildroot] Generation of locales

[WK]

Hello,

I noticed that compiling buildroot a few times without "make clean" the 
size of locale-archive file in $(TARGET_DIR)/usr/lib/locale is increasing.

The strange thing is that it occures about three times and then it stops 
increasing.


My solution for this issue is following:

--- Makefile	2019-01-04 10:03:37.136971246 +0100
+++ Makefile	2019-01-04 10:39:15.298119675 +0100
@@ -647,6 +647,7 @@ PACKAGES += host-localedef

  define GENERATE_GLIBC_LOCALES
  	$(Q)mkdir -p $(TARGET_DIR)/usr/lib/locale/
+	$(Q)rm -f $(TARGET_DIR)/usr/lib/locale/locale-archive
  	$(Q)for locale in $(GLIBC_GENERATE_LOCALES) ; do \
  		inputfile=`echo $${locale} | cut -f1 -d'.'` ; \
  		charmap=`echo $${locale} | cut -f2 -d'.' -s` ; \



Is that patch proper as a fix for this problem? Or maybe there is better 
solution?


Kind Regards,
Witold Kowolik

[Buildroot] Generation of locales

[Thomas Petazzoni]

Hello Witold,

Sorry for the very long delay before this reply.

On Fri, 4 Jan 2019 11:38:01 +0100
WK <sdrb@onet.eu> wrote:

> I noticed that compiling buildroot a few times without "make clean" the 
> size of locale-archive file in $(TARGET_DIR)/usr/lib/locale is increasing.
> 
> The strange thing is that it occures about three times and then it stops 
> increasing.

I was not able to reproduce. I built the following defconfig:

BR2_arm=y
BR2_cortex_a8=y
BR2_TOOLCHAIN_EXTERNAL=y
BR2_TOOLCHAIN_EXTERNAL_LINARO_ARM=y
BR2_INIT_NONE=y
BR2_SYSTEM_BIN_SH_NONE=y
BR2_GENERATE_LOCALE="fr_FR.UTF-8 en_US.UTF-8"
# BR2_PACKAGE_BUSYBOX is not set
# BR2_TARGET_ROOTFS_TAR is not set

After the first build, the size of output/target/usr/lib/locale was:

$ du -sb output/target/usr/lib/locale/
1678944	output/target/usr/lib/locale/

Then I restarted "make" (without doing "make clean"), and looked at the
size again, and it was exactly the same.

Could you provide a defconfig + scenario that allows to reproduce the
issue, and indicate which version of Buildroot you're using ? We
recently updated localedef, perhaps the behavior changed ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com