[Buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor

[Buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor

[Evgeniy Didin]

This patch introduces recently released significant
update to ARC HS family: ARC HS48.

One of the major ARC HS48 features is dual-issue pipeline
which requires a little bit modified instruction scheduling compared
to single-issue cores (HS38), thus new "-mcpu/--with-cpu=hs4x".

Also to address some peculiarities of early designs based on
HS48 we introduced yet another "-mcpu/--with-cpu=hs4x_rel1" which
we're going to use as well on some of our development boards.

Note, there is a prerequisite patch:
	https://patchwork.ozlabs.org/patch/995220/

Signed-off-by: Evgeniy Didin <didin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: arc-buildroot at synopsys.com
---
 arch/Config.in.arc | 18 ++++++++++++++----
 1 file changed, 14 insertions(+), 4 deletions(-)

diff --git a/arch/Config.in.arc b/arch/Config.in.arc
index 69bb1504a9..8e9cd96dd2 100644
--- a/arch/Config.in.arc
+++ b/arch/Config.in.arc
@@ -30,12 +30,21 @@ config BR2_archs38_full
 
 	  It corresponds to "hs38_slc_full" ARC HS template in ARChitect.
 
+
+config BR2_archs4x_rel31
+        bool "ARC HS48 rel 31"
+        help
+	   Latest release of HS48 processor
+           - Dual- and quad multiply and MC oprations
+           - Double-precision FPU
+
+
 endchoice
 
 # Choice of atomic instructions presence
 config BR2_ARC_ATOMIC_EXT
 	bool "Atomic extension (LLOCK/SCOND instructions)"
-	default y if BR2_arc770d || BR2_archs38 || BR2_archs38_full
+	default y if BR2_arc770d || BR2_archs38 || BR2_archs38_full || BR2_archs4x_rel31
 
 config BR2_ARCH
 	default "arc"	if BR2_arcle
@@ -54,10 +63,11 @@ config BR2_GCC_TARGET_CPU
 	default "arc700" if BR2_arc770d
 	default "archs"	 if BR2_archs38
 	default "hs38_linux"	 if BR2_archs38_full
+	default "hs4x_rel31" if BR2_archs4x_rel31
 
 config BR2_READELF_ARCH_NAME
 	default "ARCompact"	if BR2_arc750d || BR2_arc770d
-	default "ARCv2"		if BR2_archs38 || BR2_archs38_full
+	default "ARCv2"		if BR2_archs38 || BR2_archs38_full || BR2_archs4x_rel31
 
 choice
 	prompt "MMU Page Size"
@@ -77,7 +87,7 @@ choice
 
 config BR2_ARC_PAGE_SIZE_4K
 	bool "4KB"
-	depends on BR2_arc770d || BR2_archs38 || BR2_archs38_full
+	depends on BR2_arc770d || BR2_archs38 || BR2_archs38_full || BR2_archs4x_rel31
 
 config BR2_ARC_PAGE_SIZE_8K
 	bool "8KB"
@@ -87,7 +97,7 @@ config BR2_ARC_PAGE_SIZE_8K
 
 config BR2_ARC_PAGE_SIZE_16K
 	bool "16KB"
-	depends on BR2_arc770d || BR2_archs38 || BR2_archs38_full
+	depends on BR2_arc770d || BR2_archs38 || BR2_archs38_full || BR2_archs4x_rel31
 
 endchoice
 
-- 
2.16.2

[Buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor

[Thomas Petazzoni]

Hello Evgeniy,

On Tue,  4 Jun 2019 08:39:27 +0300
Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote:

> This patch introduces recently released significant
> update to ARC HS family: ARC HS48.
> 
> One of the major ARC HS48 features is dual-issue pipeline
> which requires a little bit modified instruction scheduling compared
> to single-issue cores (HS38), thus new "-mcpu/--with-cpu=hs4x".
> 
> Also to address some peculiarities of early designs based on
> HS48 we introduced yet another "-mcpu/--with-cpu=hs4x_rel1" which

I guess you meant --with-cpu=hs4x_rel31 here, correct ?

Overall, I'm a bit confused by the naming and choice of options for the
ARC architecture.

The patch at https://patchwork.ozlabs.org/patch/995220/ adds a variant
for ARC HS38 with quad MAC and double precision FPU, and the gcc option
to enable it was named hs38_linux. It is really weird to use the name
of an operating system in a gcc architecture name option. Indeed, you
could very well run a different operating system than Linux. Don't take
it as an offense, but the logic used by RISC-V to name gcc options
looks a lot better: a number of letters than indicate with optional
features of the CPU core have been enabled in the design. This allows
gcc and therefore Buildroot to easily support possibly any combination
of CPU core design, rather than just a few selected combinations. But
well, I see that hs38_linux has been accepted into upstream gcc.

Regarding HS48, is "rel31" really part of the name ? Are you going to
update this with rel32, rel33, rel41, etc. ?

Or is this rel31 only because as explained in the commit log, it's for
early designs only ? And then you will add the real hs48 option that
will use --with-cpu=hs4x ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [arc-buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor

[Alexey Brodkin]

Hi Thomas,

> -----Original Message-----
> From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Sent: Monday, June 24, 2019 7:46 AM
> To: Evgeniy Didin <didin@synopsys.com>
> Cc: buildroot at busybox.net; arc-buildroot at synopsys.com; Alexey Brodkin <abrodkin@synopsys.com>
> Subject: Re: [arc-buildroot] [Buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor
> 
> Hello Evgeniy,
> 
> On Tue,  4 Jun 2019 08:39:27 +0300
> Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote:
> 
> > This patch introduces recently released significant
> > update to ARC HS family: ARC HS48.
> >
> > One of the major ARC HS48 features is dual-issue pipeline
> > which requires a little bit modified instruction scheduling compared
> > to single-issue cores (HS38), thus new "-mcpu/--with-cpu=hs4x".
> >
> > Also to address some peculiarities of early designs based on
> > HS48 we introduced yet another "-mcpu/--with-cpu=hs4x_rel1" which
> 
> I guess you meant --with-cpu=hs4x_rel31 here, correct ?

Right!

> Overall, I'm a bit confused by the naming and choice of options for the
> ARC architecture.
> 
> The patch at https://patchwork.ozlabs.org/patch/995220/ adds a variant
> for ARC HS38 with quad MAC and double precision FPU, and the gcc option
> to enable it was named hs38_linux. It is really weird to use the name
> of an operating system in a gcc architecture name option.

Well actually it's even more complicated :)

That name comes out of a "template" in our IP configuration tool which
in its turn was chosen to highlight that template purpose - it suits the
best systems developed for running Linux. And in fact it's not unusual name
as you may see more of that for ARC EM family, check
https://github.com/gcc-mirror/gcc/blob/master/gcc/config/arc/arc-cpus.def.

> ... but the logic used by RISC-V to name gcc options
> looks a lot better: a number of letters than indicate with optional
> features of the CPU core have been enabled in the design. This allows
> gcc and therefore Buildroot to easily support possibly any combination
> of CPU core design, rather than just a few selected combinations.

That's indeed an interesting point regrading RISC-V which we will
take into consideration as naming of mcpu's seems to be getting a bit
out of control. I guess the main difference between RISC-V and ARC is
RISC-V has more structured ABI versions while we on ARC have more flexibility.

But still what we have is what we have now and we'll need to leave with
it until we come up with something better.

> Regarding HS48, is "rel31" really part of the name ?

Correct, see https://github.com/foss-for-synopsys-dwc-arc-processors/gcc/blob/arc-2019.03/gcc/config/arc/arc-cpus.def#L67

> Are you going to update this with rel32, rel33, rel41, etc. ?

Well that's really hard to tell as even _rel31 was not planned but we
had to add it to address some peculiarities of a particular core revision
which is being implemented in real silicon.

But given your very good point above we need to revisit our naming
scheme to make it simpler and cleaner.

> Or is this rel31 only because as explained in the commit log, it's for
> early designs only ? And then you will add the real hs48 option that
> will use --with-cpu=hs4x ?

Right we were planning to add "hs4x" and "hs4xd" as well.
Most probably I explained our rationale for using mcpu's/with-cpu's
but will re-iterate on it once again so that maybe better solutions will be
offered by a casual readers...

We have a couple of families of ARC cores. Up-to-date ones are ARC EM (pretty simple
but very efficient 32-bit microcontrollers) and ARC HS (much more sophisticated
and powerful cores). EM family is of no interest here as it cannot have MMU so no
Linux on it.

ARC HS cores (as any other ARC cores) might be in its bare-minimal configuration
w/o even external memory, caches, multiplier, FPU - something like on-chip SRAM and ALU.
That's the basic template called HS34. Then we start adding other HW features and
getting other templates like those mentioned "hs38_linux", "hs4xd" etc, see this
nice article describing details of what is supported [1]

So looking at the table for ARC HS I'd propose to use simple "hs" for both
"--with-cpu" & "-mcpu" and then depending on which type of "template" (or whatever we
will call ARC core flavors) is selected by user add required set of discrete options like
"-mdiv-rem -mll64 -mmpy-option=plus_qmacw -mfpu=fpud_all" which in the end will be a
full equivalent of discussed "hs38_linux".

Before Yann's proposal [2] with ARCH_TOOLCHAIN_WRAPPER_OPTS it was not very
convenient as some packages which don't use CFLAGS could have been compiled without
all those handy HW features in mind. But if we configure GCC with "--with-cpu=hs38_linux"
then whatever is compiled with just arc-linux-gcc all HW features bundled in
"hs38_linux" will be used.

[1] https://github.com/foss-for-synopsys-dwc-arc-processors/toolchain/wiki/Understanding-GCC-mcpu-option
[2] http://lists.busybox.net/pipermail/buildroot/2019-June/251531.html

As always any input is much appreciated!

-Alexey

[Buildroot] [PATCH] ARC: Add support for ARC HS48 v3.1 processor

[Peter Korsgaard]

>>>>> "Evgeniy" == Evgeniy Didin <Evgeniy.Didin@synopsys.com> writes:

 > This patch introduces recently released significant
 > update to ARC HS family: ARC HS48.

 > One of the major ARC HS48 features is dual-issue pipeline
 > which requires a little bit modified instruction scheduling compared
 > to single-issue cores (HS38), thus new "-mcpu/--with-cpu=hs4x".

 > Also to address some peculiarities of early designs based on
 > HS48 we introduced yet another "-mcpu/--with-cpu=hs4x_rel1" which
 > we're going to use as well on some of our development boards.

 > Note, there is a prerequisite patch:
 > 	https://patchwork.ozlabs.org/patch/995220/

This kind of message should go after the --- line so it doesn't get
included in the commit message.

 > Signed-off-by: Evgeniy Didin <didin@synopsys.com>
 > Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Cc: arc-buildroot at synopsys.com

Committed after fixing a number of check-package warnings, thanks.

-- 
Bye, Peter Korsgaard