From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/checkpackagelib: CommentsMenusPackagesOrder: fix 'menuconfig' handling
Date: Sun, 14 Jul 2019 15:15:02 +0200 [thread overview]
Message-ID: <20190714131502.GC8912@scaer> (raw)
In-Reply-To: <20190714124400.29431-1-arnout@mind.be>
Arnout, All,
On 2019-07-14 14:44 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
> The CommentsMenusPackagesOrder check builds the 'state' to track the
> depth of menus and conditions. However, a menuconfig doesn't create a
> menu by itself - it is always followed by a condition that implies the
> menu. As a result, when unwinding the 'state', the level will be wrong.
>
> Fix this by checking for menu followed by a space, so it no longer
> matches menuconfig.
>
> Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/251214899
No, it does not fix it totally. It only fixes the python traceback.
The Kodi issues is till present.
Hint: the Kodi package is the only one that indents the "source" lines
with a TAB.
Regards,
Yann E. MORIN.
> Signed-off-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
> Cc: Jerzy Grzegorek <jerzy.m.grzegorek@gmail.com>
> ---
> utils/checkpackagelib/lib_config.py | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/utils/checkpackagelib/lib_config.py b/utils/checkpackagelib/lib_config.py
> index f0edb9993d..94faf1b0fc 100644
> --- a/utils/checkpackagelib/lib_config.py
> +++ b/utils/checkpackagelib/lib_config.py
> @@ -73,7 +73,7 @@ class CommentsMenusPackagesOrder(_CheckFunction):
>
> def check_line(self, lineno, text):
> if text.startswith("comment") or text.startswith("if") or \
> - text.startswith("menu"):
> + text.startswith("menu "):
>
> if text.startswith("comment"):
> if not self.state.endswith("-comment"):
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-07-14 13:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 12:44 [Buildroot] [PATCH] utils/checkpackagelib: CommentsMenusPackagesOrder: fix 'menuconfig' handling Arnout Vandecappelle
2019-07-14 13:15 ` Yann E. MORIN [this message]
2019-07-14 13:23 ` Yann E. MORIN
2019-07-14 18:50 ` Arnout Vandecappelle
2019-07-14 20:24 ` Arnout Vandecappelle
2019-07-14 20:47 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714131502.GC8912@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox