From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] utils/checkpackagelib: CommentsMenusPackagesOrder: fix 'menuconfig' handling
Date: Sun, 14 Jul 2019 15:23:29 +0200 [thread overview]
Message-ID: <20190714132329.GA25166@scaer> (raw)
In-Reply-To: <20190714131502.GC8912@scaer>
Arnout, Jerzy, All,
(sorry, I sent the previous one too quickly)
On 2019-07-14 15:15 +0200, Yann E. MORIN spake thusly:
> On 2019-07-14 14:44 +0200, Arnout Vandecappelle (Essensium/Mind) spake thusly:
[--SNIP--]
> > Fixes: https://gitlab.com/buildroot.org/buildroot/-/jobs/251214899
> No, it does not fix it totally. It only fixes the python traceback.
> The Kodi issues is till present.
> Hint: the Kodi package is the only one that indents the "source" lines
> with a TAB.
If one changes Kodi to not indent the source lines, then the issue
disappears. Of course, this is not the correct solution, but...
If one changes another package to also idnent the source lines with a
TAB, then the error happens there too (for example, fftw):
package/fftw/Config.in:18: Packages in: if BR2_PACKAGE_FFTW,
are not alphabetically ordered;
correct order: '-', '_', digits, capitals, lowercase;
first incorrect package: ftw/fftw-d
OK, so, weird. The package included is in fact fftw/fftw-double and only
part of the bname is reported.
But if one also looks more closely at the Kodi issue, packages names are
also incorrectly reported:
package/kodi/Config.in:303: Packages in: menu "Audio decoder addons",
[--SNIP--]
first incorrect package: kodi-audiodecoder
And in fact, there is one thing I don;t understand in utils/checkpackagelib/lib_config.py,
line 106:
new_package = text[17: -(len(self.filename)-5):]
Why are we using the current filename to strip away parts of the new
package filename?
Hope that helps.
Regards,
Yann E. MORIN.
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-07-14 13:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-14 12:44 [Buildroot] [PATCH] utils/checkpackagelib: CommentsMenusPackagesOrder: fix 'menuconfig' handling Arnout Vandecappelle
2019-07-14 13:15 ` Yann E. MORIN
2019-07-14 13:23 ` Yann E. MORIN [this message]
2019-07-14 18:50 ` Arnout Vandecappelle
2019-07-14 20:24 ` Arnout Vandecappelle
2019-07-14 20:47 ` Yann E. MORIN
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190714132329.GA25166@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox