* [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic)
@ 2019-07-14 14:29 Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 1/2 v2] toolchain: allow architectures to enforce compilation flags Yann E. MORIN
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Yann E. MORIN @ 2019-07-14 14:29 UTC (permalink / raw)
To: buildroot
Hello All!
This series makes it so that architectures can set compilation flags,
passed down via the wrapper.
This is then used by arc to enforce -matomic for those cores that need
it, namely arc7x0, as reported by Alexey:
https://patchwork.ozlabs.org/patch/1087480/
https://patchwork.ozlabs.org/patch/1087471/
Changes v1 -> v2;
- move condition that was previously in package/Makefile.in (Alexey)
Regards,
Yann E. MORIN.
The following changes since commit fb9c86a31c7933d2a320644be9cfff4be71a3206
package/imx-uuc: bump to version fc48b497fe961d601b4bcced807f562090854ec9 (2019-07-14 15:59:56 +0200)
are available in the git repository at:
git://git.buildroot.org/~ymorin/git/buildroot.git
for you to fetch changes up to 8d0887d8b7c56dd2b92314886f35bdaa7d57894d
arch/arc: always needs -matomic with atomix extensions (2019-07-14 16:28:43 +0200)
----------------------------------------------------------------
Yann E. MORIN (2):
toolchain: allow architectures to enforce compilation flags
arch/arc: always needs -matomic with atomix extensions
arch/arch.mk.arc | 4 ++++
package/Makefile.in | 4 ----
toolchain/toolchain-wrapper.mk | 1 +
3 files changed, 5 insertions(+), 4 deletions(-)
create mode 100644 arch/arch.mk.arc
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 1/2 v2] toolchain: allow architectures to enforce compilation flags
2019-07-14 14:29 [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Yann E. MORIN
@ 2019-07-14 14:29 ` Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions Yann E. MORIN
2019-07-16 17:52 ` [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Alexey Brodkin
2 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2019-07-14 14:29 UTC (permalink / raw)
To: buildroot
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Alexey Brodkin <abrodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
toolchain/toolchain-wrapper.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/toolchain/toolchain-wrapper.mk b/toolchain/toolchain-wrapper.mk
index ca66fa7ba4..8f872506ec 100644
--- a/toolchain/toolchain-wrapper.mk
+++ b/toolchain/toolchain-wrapper.mk
@@ -17,6 +17,7 @@ TOOLCHAIN_WRAPPER_ARGS = $($(PKG)_TOOLCHAIN_WRAPPER_ARGS)
TOOLCHAIN_WRAPPER_ARGS += -DBR_SYSROOT='"$(STAGING_SUBDIR)"'
TOOLCHAIN_WRAPPER_OPTS = \
+ $(ARCH_TOOLCHAIN_WRAPPER_OPTS) \
$(call qstrip,$(BR2_SSP_OPTION)) \
$(call qstrip,$(BR2_TARGET_OPTIMIZATION))
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions
2019-07-14 14:29 [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 1/2 v2] toolchain: allow architectures to enforce compilation flags Yann E. MORIN
@ 2019-07-14 14:29 ` Yann E. MORIN
2019-07-14 14:45 ` Yann E. MORIN
2019-07-16 17:52 ` [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Alexey Brodkin
2 siblings, 1 reply; 5+ messages in thread
From: Yann E. MORIN @ 2019-07-14 14:29 UTC (permalink / raw)
To: buildroot
As reported by Alexey:
https://patchwork.ozlabs.org/patch/1087480/
https://patchwork.ozlabs.org/patch/1087471/
Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Cc: Arnout Vandecappelle <arnout@mind.be>
---
Changes v1 -> v2:
- move the condition out of package/Makefile.in (Alexey)
---
arch/arch.mk.arc | 4 ++++
package/Makefile.in | 4 ----
2 files changed, 4 insertions(+), 4 deletions(-)
create mode 100644 arch/arch.mk.arc
diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc
new file mode 100644
index 0000000000..559216a733
--- /dev/null
+++ b/arch/arch.mk.arc
@@ -0,0 +1,4 @@
+# -matomic is always required when the ARC core has the atomic extensions
+ifeq ($(BR2_arc)$(BR2_ARC_ATOMIC_EXT),y)
+ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
+endif
diff --git a/package/Makefile.in b/package/Makefile.in
index f05b9cc3aa..0a7899c852 100644
--- a/package/Makefile.in
+++ b/package/Makefile.in
@@ -112,10 +112,6 @@ ifeq ($(BR2_xtensa),y)
TARGET_ABI += -mlongcalls -mauto-litpools
endif
-ifeq ($(BR2_arc)$(BR2_ARC_ATOMIC_EXT),yy)
-TARGET_ABI += -matomic
-endif
-
STAGING_SUBDIR = $(GNU_TARGET_NAME)/sysroot
STAGING_DIR = $(HOST_DIR)/$(STAGING_SUBDIR)
--
2.20.1
^ permalink raw reply related [flat|nested] 5+ messages in thread* [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions
2019-07-14 14:29 ` [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions Yann E. MORIN
@ 2019-07-14 14:45 ` Yann E. MORIN
0 siblings, 0 replies; 5+ messages in thread
From: Yann E. MORIN @ 2019-07-14 14:45 UTC (permalink / raw)
To: buildroot
All,
On 2019-07-14 16:29 +0200, Yann E. MORIN spake thusly:
> As reported by Alexey:
> https://patchwork.ozlabs.org/patch/1087480/
> https://patchwork.ozlabs.org/patch/1087471/
>
> Reported-by: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>
> Cc: Alexey Brodkin <Alexey.Brodkin@synopsys.com>
> Cc: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> Cc: Arnout Vandecappelle <arnout@mind.be>
>
> ---
> Changes v1 -> v2:
> - move the condition out of package/Makefile.in (Alexey)
> ---
> arch/arch.mk.arc | 4 ++++
> package/Makefile.in | 4 ----
> 2 files changed, 4 insertions(+), 4 deletions(-)
> create mode 100644 arch/arch.mk.arc
>
> diff --git a/arch/arch.mk.arc b/arch/arch.mk.arc
> new file mode 100644
> index 0000000000..559216a733
> --- /dev/null
> +++ b/arch/arch.mk.arc
> @@ -0,0 +1,4 @@
> +# -matomic is always required when the ARC core has the atomic extensions
> +ifeq ($(BR2_arc)$(BR2_ARC_ATOMIC_EXT),y)
Damned, I forgot to git-commit-amend... :-( It should be 'yy' rather
than a single ...
Regards,
Yann E. MORIN.
> +ARCH_TOOLCHAIN_WRAPPER_OPTS = -matomic
> +endif
> diff --git a/package/Makefile.in b/package/Makefile.in
> index f05b9cc3aa..0a7899c852 100644
> --- a/package/Makefile.in
> +++ b/package/Makefile.in
> @@ -112,10 +112,6 @@ ifeq ($(BR2_xtensa),y)
> TARGET_ABI += -mlongcalls -mauto-litpools
> endif
>
> -ifeq ($(BR2_arc)$(BR2_ARC_ATOMIC_EXT),yy)
> -TARGET_ABI += -matomic
> -endif
> -
> STAGING_SUBDIR = $(GNU_TARGET_NAME)/sysroot
> STAGING_DIR = $(HOST_DIR)/$(STAGING_SUBDIR)
>
> --
> 2.20.1
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic)
2019-07-14 14:29 [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 1/2 v2] toolchain: allow architectures to enforce compilation flags Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions Yann E. MORIN
@ 2019-07-16 17:52 ` Alexey Brodkin
2 siblings, 0 replies; 5+ messages in thread
From: Alexey Brodkin @ 2019-07-16 17:52 UTC (permalink / raw)
To: buildroot
Hi Yann, all,
> -----Original Message-----
> From: Yann E. MORIN <yann.morin.1998@gmail.com> On Behalf Of Yann E. MORIN
> Sent: Sunday, July 14, 2019 5:30 PM
> To: buildroot at buildroot.org
> Cc: Alexey Brodkin <abrodkin@synopsys.com>; Alexey Brodkin <abrodkin@synopsys.com>; Arnout
> Vandecappelle <arnout@mind.be>; Thomas Petazzoni <thomas.petazzoni@bootlin.com>; Yann E . MORIN
> <yann.morin.1998@free.fr>
> Subject: [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic)
>
> Hello All!
>
> This series makes it so that architectures can set compilation flags,
> passed down via the wrapper.
Works like a charm now for building Linux perf for ARC770 (finally)!
Thanks for doing that!
That said for entire series...
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-16 17:52 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-14 14:29 [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 1/2 v2] toolchain: allow architectures to enforce compilation flags Yann E. MORIN
2019-07-14 14:29 ` [Buildroot] [PATCH 2/2 v2] arch/arc: always needs -matomic with atomix extensions Yann E. MORIN
2019-07-14 14:45 ` Yann E. MORIN
2019-07-16 17:52 ` [Buildroot] [PATCH 0/2 v2] arch: allow passing compile flags (branch yem/arc-atomic) Alexey Brodkin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox