* [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
@ 2019-07-13 11:53 Giulio Benetti
2019-07-14 13:07 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2019-07-13 11:53 UTC (permalink / raw)
To: buildroot
With Microblaze Gcc version < 8.x the build hangs due to gcc bug
85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
shows up when building xlib_libXfont with optimization but not when
building with -O0. To work around this, if
BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
Fixes:
http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
index a1acfba83b..ba41970289 100644
--- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
+++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
@@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
endif
+XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+XLIB_LIBXFONT_CFLAGS += -O0
+endif
+
+XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
+
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
2019-07-13 11:53 [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180 Giulio Benetti
@ 2019-07-14 13:07 ` Thomas Petazzoni
2019-07-15 8:49 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-07-14 13:07 UTC (permalink / raw)
To: buildroot
Hello,
On Sat, 13 Jul 2019 13:53:09 +0200
Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
> With Microblaze Gcc version < 8.x the build hangs due to gcc bug
> 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
> shows up when building xlib_libXfont with optimization but not when
> building with -O0. To work around this, if
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
>
> Fixes:
> http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> index a1acfba83b..ba41970289 100644
> --- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> +++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> @@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
> XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
> endif
>
> +XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +XLIB_LIBXFONT_CFLAGS += -O0
> +endif
> +
> +XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
We normally use the <pkg>_CONF_ENV variable to override CFLAGS, so I
fixed that up and applied. Thanks!
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
2019-07-14 13:07 ` Thomas Petazzoni
@ 2019-07-15 8:49 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-07-15 8:49 UTC (permalink / raw)
To: buildroot
Hello Thomas,
Il 14/07/2019 15:07, Thomas Petazzoni ha scritto:
> Hello,
>
> On Sat, 13 Jul 2019 13:53:09 +0200
> Giulio Benetti <giulio.benetti@micronovasrl.com> wrote:
>
>> With Microblaze Gcc version < 8.x the build hangs due to gcc bug
>> 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
>> shows up when building xlib_libXfont with optimization but not when
>> building with -O0. To work around this, if
>> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
>> ---
>> package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
>> 1 file changed, 8 insertions(+)
>>
>> diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
>> index a1acfba83b..ba41970289 100644
>> --- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
>> +++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
>> @@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
>> XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
>> endif
>>
>> +XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
>> +
>> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
>> +XLIB_LIBXFONT_CFLAGS += -O0
>> +endif
>> +
>> +XLIB_LIBXFONT_CONF_OPTS += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
>
> We normally use the <pkg>_CONF_ENV variable to override CFLAGS, so I
> fixed that up and applied. Thanks!
You've changed and applied xlib_libXfont2, so I've sent a v2 patch for
xlib_libXfont using <pkg>_CONF_ENV.
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
@ 2019-07-15 8:46 Giulio Benetti
2019-07-15 8:47 ` Giulio Benetti
0 siblings, 1 reply; 5+ messages in thread
From: Giulio Benetti @ 2019-07-15 8:46 UTC (permalink / raw)
To: buildroot
With Microblaze Gcc version < 8.x the build hangs due to gcc bug
85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
shows up when building xlib_libXfont with optimization but not when
building with -O0. To work around this, if
BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
Fixes:
http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
---
package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
index a1acfba83b..eeddfeebc9 100644
--- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
+++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
@@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
endif
+XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
+
+ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
+XLIB_LIBXFONT_CFLAGS += -O0
+endif
+
+XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
+
$(eval $(autotools-package))
$(eval $(host-autotools-package))
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180
2019-07-15 8:46 Giulio Benetti
@ 2019-07-15 8:47 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2019-07-15 8:47 UTC (permalink / raw)
To: buildroot
This must have been v2. I resend. Sorry for the noise.
Il 15/07/2019 10:46, Giulio Benetti ha scritto:
> With Microblaze Gcc version < 8.x the build hangs due to gcc bug
> 85180: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=85180. The bug
> shows up when building xlib_libXfont with optimization but not when
> building with -O0. To work around this, if
> BR2_TOOLCHAIN_HAS_GCC_BUG_85180=y we force using -O0.
>
> Fixes:
> http://autobuild.buildroot.net/results/7c6/7c64becbf06a1e00e41b7ddb95dd0c65bf364eb7/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@micronovasrl.com>
> ---
> package/x11r7/xlib_libXfont/xlib_libXfont.mk | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/package/x11r7/xlib_libXfont/xlib_libXfont.mk b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> index a1acfba83b..eeddfeebc9 100644
> --- a/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> +++ b/package/x11r7/xlib_libXfont/xlib_libXfont.mk
> @@ -30,5 +30,13 @@ ifeq ($(BR2_microblaze),y)
> XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(TARGET_CFLAGS) -D__ELF__"
> endif
>
> +XLIB_LIBXFONT_CFLAGS = $(TARGET_CFLAGS)
> +
> +ifeq ($(BR2_TOOLCHAIN_HAS_GCC_BUG_85180),y)
> +XLIB_LIBXFONT_CFLAGS += -O0
> +endif
> +
> +XLIB_LIBXFONT_CONF_ENV += CFLAGS="$(XLIB_LIBXFONT_CFLAGS)"
> +
> $(eval $(autotools-package))
> $(eval $(host-autotools-package))
>
--
Giulio Benetti
CTO
MICRONOVA SRL
Sede: Via A. Niedda 3 - 35010 Vigonza (PD)
Tel. 049/8931563 - Fax 049/8931346
Cod.Fiscale - P.IVA 02663420285
Capitale Sociale ? 26.000 i.v.
Iscritta al Reg. Imprese di Padova N. 02663420285
Numero R.E.A. 258642
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-07-15 8:49 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-13 11:53 [Buildroot] [PATCH] package/x11r7/xlib_libXfont: work around gcc bug 85180 Giulio Benetti
2019-07-14 13:07 ` Thomas Petazzoni
2019-07-15 8:49 ` Giulio Benetti
-- strict thread matches above, loose matches on Subject: below --
2019-07-15 8:46 Giulio Benetti
2019-07-15 8:47 ` Giulio Benetti
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox