* [Buildroot] [PATCH 0/2] arch/csky: clean up conditions on gcc verssion (branch yem/arch-csky)
@ 2019-07-14 9:54 Yann E. MORIN
2019-07-14 9:54 ` [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port Yann E. MORIN
2019-07-14 9:54 ` [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions Yann E. MORIN
0 siblings, 2 replies; 10+ messages in thread
From: Yann E. MORIN @ 2019-07-14 9:54 UTC (permalink / raw)
To: buildroot
Hello All!
This little series makes use of the GCC_AT_LEAST_X symbols to restrict
the gcc versions usable for each C-SKY variants.
Regards,
Yann E. MORIN.
The following changes since commit d5225c5f6d1345bd08d968bf704e01c272537c48
package/{mesa3d, mesa3d-headers}: bump version to 19.0.8 (2019-07-14 00:36:51 +0200)
are available in the git repository at:
git://git.buildroot.org/~ymorin/git/buildroot.git
for you to fetch changes up to 52aa7c5a90e87a0e8a0e794487b61d3d4759d301
package/gcc: drop negative conditions on C-SKY for older versions (2019-07-14 11:50:43 +0200)
----------------------------------------------------------------
Yann E. MORIN (2):
arch/csky: restrict ck610 to the C-SKY gcc port
package/gcc: drop negative conditions on C-SKY for older versions
arch/Config.in | 3 +++
arch/Config.in.csky | 2 ++
package/gcc/Config.in.host | 8 +++-----
3 files changed, 8 insertions(+), 5 deletions(-)
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 10+ messages in thread* [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port 2019-07-14 9:54 [Buildroot] [PATCH 0/2] arch/csky: clean up conditions on gcc verssion (branch yem/arch-csky) Yann E. MORIN @ 2019-07-14 9:54 ` Yann E. MORIN 2019-07-15 16:02 ` Guo Ren 2019-07-15 23:08 ` Guo Ren 2019-07-14 9:54 ` [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions Yann E. MORIN 1 sibling, 2 replies; 10+ messages in thread From: Yann E. MORIN @ 2019-07-14 9:54 UTC (permalink / raw) To: buildroot As Guo explained, upstream gcc does not support abi-v1 (only abi-v2), but ck610 needs abi-v1 [0] [1] To simplify things, we make the whole C-SKY architecture require gcc-9 or later, and add a single exception in gcc to force the ck610 to use the C-SKY port. [0] http://lists.busybox.net/pipermail/buildroot/2019-July/254386.html [1] package/Makefile.in#73 Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Guo Ren <guoren@kernel.org> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Romain Naour <romain.naour@gmail.com> --- arch/Config.in | 3 +++ arch/Config.in.csky | 2 ++ package/gcc/Config.in.host | 3 +++ 3 files changed, 8 insertions(+) diff --git a/arch/Config.in b/arch/Config.in index d8d841b1a2..9d1a06872d 100644 --- a/arch/Config.in +++ b/arch/Config.in @@ -78,6 +78,9 @@ config BR2_aarch64_be config BR2_csky bool "csky" select BR2_ARCH_HAS_MMU_MANDATORY + # Most variants are support by gcc-9+, except one that is handled as a + # special exception in package/gcc/Config.in.host + select BR2_ARCH_NEEDS_GCC_AT_LEAST_9 help csky is processor IP from china. http://www.c-sky.com/ diff --git a/arch/Config.in.csky b/arch/Config.in.csky index 4bdfbfae4b..2cf31c88c6 100644 --- a/arch/Config.in.csky +++ b/arch/Config.in.csky @@ -5,6 +5,8 @@ choice Specific CPU variant to use config BR2_ck610 + # Not supported by upstream gc <= 9, and handled as a special + # exception in package/gcc/Config.in.host bool "ck610" config BR2_ck807 diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index 8b563c8f27..adc12e95ea 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -89,6 +89,9 @@ config BR2_GCC_VERSION_9_X # powerpc spe support has been deprecated since gcc 8.x. # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html depends on !BR2_powerpc_SPE + # C-SKY sk610 needs abiv1, which is not supported in + # upstream gcc + depends on !BR2_ck610 select BR2_TOOLCHAIN_GCC_AT_LEAST_9 endchoice -- 2.20.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port 2019-07-14 9:54 ` [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port Yann E. MORIN @ 2019-07-15 16:02 ` Guo Ren 2019-07-15 16:53 ` Yann E. MORIN 2019-07-15 23:08 ` Guo Ren 1 sibling, 1 reply; 10+ messages in thread From: Guo Ren @ 2019-07-15 16:02 UTC (permalink / raw) To: buildroot On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > As Guo explained, upstream gcc does not support abi-v1 (only abi-v2), but > ck610 needs abi-v1 [0] [1] > > To simplify things, we make the whole C-SKY architecture require gcc-9 > or later, and add a single exception in gcc to force the ck610 to use > the C-SKY port. > > [0] http://lists.busybox.net/pipermail/buildroot/2019-July/254386.html > [1] package/Makefile.in#73 > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Guo Ren <guoren@kernel.org> > Cc: Arnout Vandecappelle <arnout@mind.be> > Cc: Romain Naour <romain.naour@gmail.com> > --- > arch/Config.in | 3 +++ > arch/Config.in.csky | 2 ++ > package/gcc/Config.in.host | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/arch/Config.in b/arch/Config.in > index d8d841b1a2..9d1a06872d 100644 > --- a/arch/Config.in > +++ b/arch/Config.in > @@ -78,6 +78,9 @@ config BR2_aarch64_be > config BR2_csky > bool "csky" > select BR2_ARCH_HAS_MMU_MANDATORY > + # Most variants are support by gcc-9+, except one that is handled as a > + # special exception in package/gcc/Config.in.host > + select BR2_ARCH_NEEDS_GCC_AT_LEAST_9 We recommand using BR2_GCC_VERSION_CSKY not BR2_GCC_VERSION_9_X. I don't want GCC_9 as default for buildroot user and they could select it by themself. > help > csky is processor IP from china. > http://www.c-sky.com/ > diff --git a/arch/Config.in.csky b/arch/Config.in.csky > index 4bdfbfae4b..2cf31c88c6 100644 > --- a/arch/Config.in.csky > +++ b/arch/Config.in.csky > @@ -5,6 +5,8 @@ choice > Specific CPU variant to use > > config BR2_ck610 > + # Not supported by upstream gc <= 9, and handled as a special > + # exception in package/gcc/Config.in.host Acked. > bool "ck610" > > config BR2_ck807 > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index 8b563c8f27..adc12e95ea 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -89,6 +89,9 @@ config BR2_GCC_VERSION_9_X > # powerpc spe support has been deprecated since gcc 8.x. > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > depends on !BR2_powerpc_SPE > + # C-SKY sk610 needs abiv1, which is not supported in > + # upstream gcc > + depends on !BR2_ck610 Acked. > select BR2_TOOLCHAIN_GCC_AT_LEAST_9 > > endchoice > -- > 2.20.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port 2019-07-15 16:02 ` Guo Ren @ 2019-07-15 16:53 ` Yann E. MORIN 2019-07-15 23:06 ` Guo Ren 0 siblings, 1 reply; 10+ messages in thread From: Yann E. MORIN @ 2019-07-15 16:53 UTC (permalink / raw) To: buildroot Guo, All, On 2019-07-16 00:02 +0800, Guo Ren spake thusly: > On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > As Guo explained, upstream gcc does not support abi-v1 (only abi-v2), but > > ck610 needs abi-v1 [0] [1] > > > > To simplify things, we make the whole C-SKY architecture require gcc-9 > > or later, and add a single exception in gcc to force the ck610 to use > > the C-SKY port. > > > > [0] http://lists.busybox.net/pipermail/buildroot/2019-July/254386.html > > [1] package/Makefile.in#73 > > > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > > Cc: Guo Ren <guoren@kernel.org> > > Cc: Arnout Vandecappelle <arnout@mind.be> > > Cc: Romain Naour <romain.naour@gmail.com> > > --- > > arch/Config.in | 3 +++ > > arch/Config.in.csky | 2 ++ > > package/gcc/Config.in.host | 3 +++ > > 3 files changed, 8 insertions(+) > > > > diff --git a/arch/Config.in b/arch/Config.in > > index d8d841b1a2..9d1a06872d 100644 > > --- a/arch/Config.in > > +++ b/arch/Config.in > > @@ -78,6 +78,9 @@ config BR2_aarch64_be > > config BR2_csky > > bool "csky" > > select BR2_ARCH_HAS_MMU_MANDATORY > > + # Most variants are support by gcc-9+, except one that is handled as a > > + # special exception in package/gcc/Config.in.host > > + select BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > We recommand using BR2_GCC_VERSION_CSKY not BR2_GCC_VERSION_9_X. I > don't want GCC_9 as default for buildroot user and they could select > it by themself. This new 'select' does not change the pereferred gcc version. It just limits which ones are available. By selecting BR2_ARCH_NEEDS_GCC_AT_LEAST_9, we ensure that any version of gcc below 9.x are not visible. But the C-SKY specific gcc version, BR2_GCC_VERSION_CSKY, is not impacted by this restriction. So, with this patch, when BR2_csky=y: - with ck610, only BR2_GCC_VERSION_CSKY is available, labelled "gcc csky" in the gcc version selection, in menuconfig; - with any other variant, BR2_GCC_VERSION_CSKY and BR2_GCC_VERSION_9_X are both available, and BR2_GCC_VERSION_CSKY is the dfault. Does that explanations address your concerns? If so, I can respin the series with an expanded commit log. Thanks for the review! :-) Regards, Yann E. MORIN. > > help > > csky is processor IP from china. > > http://www.c-sky.com/ > > diff --git a/arch/Config.in.csky b/arch/Config.in.csky > > index 4bdfbfae4b..2cf31c88c6 100644 > > --- a/arch/Config.in.csky > > +++ b/arch/Config.in.csky > > @@ -5,6 +5,8 @@ choice > > Specific CPU variant to use > > > > config BR2_ck610 > > + # Not supported by upstream gc <= 9, and handled as a special > > + # exception in package/gcc/Config.in.host > Acked. > > > bool "ck610" > > > > config BR2_ck807 > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > > index 8b563c8f27..adc12e95ea 100644 > > --- a/package/gcc/Config.in.host > > +++ b/package/gcc/Config.in.host > > @@ -89,6 +89,9 @@ config BR2_GCC_VERSION_9_X > > # powerpc spe support has been deprecated since gcc 8.x. > > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > > depends on !BR2_powerpc_SPE > > + # C-SKY sk610 needs abiv1, which is not supported in > > + # upstream gcc > > + depends on !BR2_ck610 > Acked. > > > select BR2_TOOLCHAIN_GCC_AT_LEAST_9 > > > > endchoice > > -- > > 2.20.1 > > > > > -- > Best Regards > Guo Ren > > ML: https://lore.kernel.org/linux-csky/ -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port 2019-07-15 16:53 ` Yann E. MORIN @ 2019-07-15 23:06 ` Guo Ren 0 siblings, 0 replies; 10+ messages in thread From: Guo Ren @ 2019-07-15 23:06 UTC (permalink / raw) To: buildroot Acked, thx On Tue, Jul 16, 2019 at 12:53 AM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Guo, All, > > On 2019-07-16 00:02 +0800, Guo Ren spake thusly: > > On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > > > As Guo explained, upstream gcc does not support abi-v1 (only abi-v2), but > > > ck610 needs abi-v1 [0] [1] > > > > > > To simplify things, we make the whole C-SKY architecture require gcc-9 > > > or later, and add a single exception in gcc to force the ck610 to use > > > the C-SKY port. > > > > > > [0] http://lists.busybox.net/pipermail/buildroot/2019-July/254386.html > > > [1] package/Makefile.in#73 > > > > > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > > > Cc: Guo Ren <guoren@kernel.org> > > > Cc: Arnout Vandecappelle <arnout@mind.be> > > > Cc: Romain Naour <romain.naour@gmail.com> > > > --- > > > arch/Config.in | 3 +++ > > > arch/Config.in.csky | 2 ++ > > > package/gcc/Config.in.host | 3 +++ > > > 3 files changed, 8 insertions(+) > > > > > > diff --git a/arch/Config.in b/arch/Config.in > > > index d8d841b1a2..9d1a06872d 100644 > > > --- a/arch/Config.in > > > +++ b/arch/Config.in > > > @@ -78,6 +78,9 @@ config BR2_aarch64_be > > > config BR2_csky > > > bool "csky" > > > select BR2_ARCH_HAS_MMU_MANDATORY > > > + # Most variants are support by gcc-9+, except one that is handled as a > > > + # special exception in package/gcc/Config.in.host > > > + select BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > > We recommand using BR2_GCC_VERSION_CSKY not BR2_GCC_VERSION_9_X. I > > don't want GCC_9 as default for buildroot user and they could select > > it by themself. > > This new 'select' does not change the pereferred gcc version. It just > limits which ones are available. > > By selecting BR2_ARCH_NEEDS_GCC_AT_LEAST_9, we ensure that any version > of gcc below 9.x are not visible. > > But the C-SKY specific gcc version, BR2_GCC_VERSION_CSKY, is not > impacted by this restriction. > > So, with this patch, when BR2_csky=y: > > - with ck610, only BR2_GCC_VERSION_CSKY is available, labelled "gcc > csky" in the gcc version selection, in menuconfig; > > - with any other variant, BR2_GCC_VERSION_CSKY and BR2_GCC_VERSION_9_X > are both available, and BR2_GCC_VERSION_CSKY is the dfault. Great, thx for these patches and we'll improve GCC_9 continuously in future. -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port 2019-07-14 9:54 ` [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port Yann E. MORIN 2019-07-15 16:02 ` Guo Ren @ 2019-07-15 23:08 ` Guo Ren 1 sibling, 0 replies; 10+ messages in thread From: Guo Ren @ 2019-07-15 23:08 UTC (permalink / raw) To: buildroot Acked-by: Guo Ren <guoren@kernel.org> On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > As Guo explained, upstream gcc does not support abi-v1 (only abi-v2), but > ck610 needs abi-v1 [0] [1] > > To simplify things, we make the whole C-SKY architecture require gcc-9 > or later, and add a single exception in gcc to force the ck610 to use > the C-SKY port. > > [0] http://lists.busybox.net/pipermail/buildroot/2019-July/254386.html > [1] package/Makefile.in#73 > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Guo Ren <guoren@kernel.org> > Cc: Arnout Vandecappelle <arnout@mind.be> > Cc: Romain Naour <romain.naour@gmail.com> > --- > arch/Config.in | 3 +++ > arch/Config.in.csky | 2 ++ > package/gcc/Config.in.host | 3 +++ > 3 files changed, 8 insertions(+) > > diff --git a/arch/Config.in b/arch/Config.in > index d8d841b1a2..9d1a06872d 100644 > --- a/arch/Config.in > +++ b/arch/Config.in > @@ -78,6 +78,9 @@ config BR2_aarch64_be > config BR2_csky > bool "csky" > select BR2_ARCH_HAS_MMU_MANDATORY > + # Most variants are support by gcc-9+, except one that is handled as a > + # special exception in package/gcc/Config.in.host > + select BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > help > csky is processor IP from china. > http://www.c-sky.com/ > diff --git a/arch/Config.in.csky b/arch/Config.in.csky > index 4bdfbfae4b..2cf31c88c6 100644 > --- a/arch/Config.in.csky > +++ b/arch/Config.in.csky > @@ -5,6 +5,8 @@ choice > Specific CPU variant to use > > config BR2_ck610 > + # Not supported by upstream gc <= 9, and handled as a special > + # exception in package/gcc/Config.in.host > bool "ck610" > > config BR2_ck807 > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index 8b563c8f27..adc12e95ea 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -89,6 +89,9 @@ config BR2_GCC_VERSION_9_X > # powerpc spe support has been deprecated since gcc 8.x. > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > depends on !BR2_powerpc_SPE > + # C-SKY sk610 needs abiv1, which is not supported in > + # upstream gcc > + depends on !BR2_ck610 > select BR2_TOOLCHAIN_GCC_AT_LEAST_9 > > endchoice > -- > 2.20.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions 2019-07-14 9:54 [Buildroot] [PATCH 0/2] arch/csky: clean up conditions on gcc verssion (branch yem/arch-csky) Yann E. MORIN 2019-07-14 9:54 ` [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port Yann E. MORIN @ 2019-07-14 9:54 ` Yann E. MORIN 2019-07-15 15:52 ` Guo Ren 2019-07-15 23:07 ` Guo Ren 1 sibling, 2 replies; 10+ messages in thread From: Yann E. MORIN @ 2019-07-14 9:54 UTC (permalink / raw) To: buildroot Now that the C-SKY architecture requires gcc-9, we can drop the special conditions on the individual older versions. Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> Cc: Guo Ren <guoren@kernel.org> Cc: Arnout Vandecappelle <arnout@mind.be> Cc: Romain Naour <romain.naour@gmail.com> --- package/gcc/Config.in.host | 5 ----- 1 file changed, 5 deletions(-) diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host index adc12e95ea..a3ba7cf90d 100644 --- a/package/gcc/Config.in.host +++ b/package/gcc/Config.in.host @@ -32,7 +32,6 @@ config BR2_GCC_VERSION_4_9_X depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5 # Broken or unsupported architectures depends on !BR2_arc - depends on !BR2_csky depends on !BR2_or1k # musl on microblaze, ppc64 and mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_microblazeel || BR2_microblazebe)) @@ -47,7 +46,6 @@ config BR2_GCC_VERSION_5_X depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6 # Broken or unsupported architectures depends on !BR2_arc - depends on !BR2_csky depends on !BR2_or1k # musl on ppc64 and mips64 unsupported depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le)) @@ -61,7 +59,6 @@ config BR2_GCC_VERSION_6_X depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7 # Broken or unsupported architectures depends on !BR2_arc - depends on !BR2_csky depends on !BR2_or1k select BR2_TOOLCHAIN_GCC_AT_LEAST_6 @@ -69,7 +66,6 @@ config BR2_GCC_VERSION_7_X bool "gcc 7.x" depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_8 # Broken or unsupported architectures - depends on !BR2_csky depends on !BR2_or1k select BR2_TOOLCHAIN_GCC_AT_LEAST_7 @@ -77,7 +73,6 @@ config BR2_GCC_VERSION_8_X bool "gcc 8.x" depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_9 # Broken or unsupported architectures - depends on !BR2_csky depends on !BR2_or1k # powerpc spe support has been deprecated since gcc 8.x. # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html -- 2.20.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions 2019-07-14 9:54 ` [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions Yann E. MORIN @ 2019-07-15 15:52 ` Guo Ren 2019-07-15 19:57 ` Yann E. MORIN 2019-07-15 23:07 ` Guo Ren 1 sibling, 1 reply; 10+ messages in thread From: Guo Ren @ 2019-07-15 15:52 UTC (permalink / raw) To: buildroot Acked, Thx. On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Now that the C-SKY architecture requires gcc-9, we can drop the special > conditions on the individual older versions. > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Guo Ren <guoren@kernel.org> > Cc: Arnout Vandecappelle <arnout@mind.be> > Cc: Romain Naour <romain.naour@gmail.com> > --- > package/gcc/Config.in.host | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index adc12e95ea..a3ba7cf90d 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -32,7 +32,6 @@ config BR2_GCC_VERSION_4_9_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > # musl on microblaze, ppc64 and mips64 unsupported > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_microblazeel || BR2_microblazebe)) > @@ -47,7 +46,6 @@ config BR2_GCC_VERSION_5_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > # musl on ppc64 and mips64 unsupported > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le)) > @@ -61,7 +59,6 @@ config BR2_GCC_VERSION_6_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > select BR2_TOOLCHAIN_GCC_AT_LEAST_6 > > @@ -69,7 +66,6 @@ config BR2_GCC_VERSION_7_X > bool "gcc 7.x" > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_8 > # Broken or unsupported architectures > - depends on !BR2_csky > depends on !BR2_or1k > select BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > @@ -77,7 +73,6 @@ config BR2_GCC_VERSION_8_X > bool "gcc 8.x" > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > # Broken or unsupported architectures > - depends on !BR2_csky > depends on !BR2_or1k > # powerpc spe support has been deprecated since gcc 8.x. > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > -- > 2.20.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions 2019-07-15 15:52 ` Guo Ren @ 2019-07-15 19:57 ` Yann E. MORIN 0 siblings, 0 replies; 10+ messages in thread From: Yann E. MORIN @ 2019-07-15 19:57 UTC (permalink / raw) To: buildroot Guo, All, On 2019-07-15 23:52 +0800, Guo Ren spake thusly: > Acked, Thx. Thanks for the review. :-) Next time, can you please send a proper "Acked-by:" tag, so that patchwwork can pick it up, and thus it ends up in the commit when the patch is eventually applied? Thanks! Regards, Yann E. MORIN. > On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > > > Now that the C-SKY architecture requires gcc-9, we can drop the special > > conditions on the individual older versions. > > > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > > Cc: Guo Ren <guoren@kernel.org> > > Cc: Arnout Vandecappelle <arnout@mind.be> > > Cc: Romain Naour <romain.naour@gmail.com> > > --- > > package/gcc/Config.in.host | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > > index adc12e95ea..a3ba7cf90d 100644 > > --- a/package/gcc/Config.in.host > > +++ b/package/gcc/Config.in.host > > @@ -32,7 +32,6 @@ config BR2_GCC_VERSION_4_9_X > > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5 > > # Broken or unsupported architectures > > depends on !BR2_arc > > - depends on !BR2_csky > > depends on !BR2_or1k > > # musl on microblaze, ppc64 and mips64 unsupported > > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_microblazeel || BR2_microblazebe)) > > @@ -47,7 +46,6 @@ config BR2_GCC_VERSION_5_X > > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6 > > # Broken or unsupported architectures > > depends on !BR2_arc > > - depends on !BR2_csky > > depends on !BR2_or1k > > # musl on ppc64 and mips64 unsupported > > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le)) > > @@ -61,7 +59,6 @@ config BR2_GCC_VERSION_6_X > > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7 > > # Broken or unsupported architectures > > depends on !BR2_arc > > - depends on !BR2_csky > > depends on !BR2_or1k > > select BR2_TOOLCHAIN_GCC_AT_LEAST_6 > > > > @@ -69,7 +66,6 @@ config BR2_GCC_VERSION_7_X > > bool "gcc 7.x" > > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_8 > > # Broken or unsupported architectures > > - depends on !BR2_csky > > depends on !BR2_or1k > > select BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > > > @@ -77,7 +73,6 @@ config BR2_GCC_VERSION_8_X > > bool "gcc 8.x" > > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > > # Broken or unsupported architectures > > - depends on !BR2_csky > > depends on !BR2_or1k > > # powerpc spe support has been deprecated since gcc 8.x. > > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > > -- > > 2.20.1 > > > > > -- > Best Regards > Guo Ren > > ML: https://lore.kernel.org/linux-csky/ -- .-----------------.--------------------.------------------.--------------------. | Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: | | +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ | | +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no | | http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. | '------------------------------^-------^------------------^--------------------' ^ permalink raw reply [flat|nested] 10+ messages in thread
* [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions 2019-07-14 9:54 ` [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions Yann E. MORIN 2019-07-15 15:52 ` Guo Ren @ 2019-07-15 23:07 ` Guo Ren 1 sibling, 0 replies; 10+ messages in thread From: Guo Ren @ 2019-07-15 23:07 UTC (permalink / raw) To: buildroot Acked-by: Guo Ren <guoren@kernel.org> On Sun, Jul 14, 2019 at 5:54 PM Yann E. MORIN <yann.morin.1998@free.fr> wrote: > > Now that the C-SKY architecture requires gcc-9, we can drop the special > conditions on the individual older versions. > > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr> > Cc: Guo Ren <guoren@kernel.org> > Cc: Arnout Vandecappelle <arnout@mind.be> > Cc: Romain Naour <romain.naour@gmail.com> > --- > package/gcc/Config.in.host | 5 ----- > 1 file changed, 5 deletions(-) > > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host > index adc12e95ea..a3ba7cf90d 100644 > --- a/package/gcc/Config.in.host > +++ b/package/gcc/Config.in.host > @@ -32,7 +32,6 @@ config BR2_GCC_VERSION_4_9_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_5 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > # musl on microblaze, ppc64 and mips64 unsupported > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_microblazeel || BR2_microblazebe)) > @@ -47,7 +46,6 @@ config BR2_GCC_VERSION_5_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_6 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > # musl on ppc64 and mips64 unsupported > depends on !(BR2_TOOLCHAIN_USES_MUSL && (BR2_powerpc64 || BR2_powerpc64le)) > @@ -61,7 +59,6 @@ config BR2_GCC_VERSION_6_X > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_7 > # Broken or unsupported architectures > depends on !BR2_arc > - depends on !BR2_csky > depends on !BR2_or1k > select BR2_TOOLCHAIN_GCC_AT_LEAST_6 > > @@ -69,7 +66,6 @@ config BR2_GCC_VERSION_7_X > bool "gcc 7.x" > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_8 > # Broken or unsupported architectures > - depends on !BR2_csky > depends on !BR2_or1k > select BR2_TOOLCHAIN_GCC_AT_LEAST_7 > > @@ -77,7 +73,6 @@ config BR2_GCC_VERSION_8_X > bool "gcc 8.x" > depends on !BR2_ARCH_NEEDS_GCC_AT_LEAST_9 > # Broken or unsupported architectures > - depends on !BR2_csky > depends on !BR2_or1k > # powerpc spe support has been deprecated since gcc 8.x. > # https://gcc.gnu.org/ml/gcc/2018-04/msg00102.html > -- > 2.20.1 > -- Best Regards Guo Ren ML: https://lore.kernel.org/linux-csky/ ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2019-07-15 23:08 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-07-14 9:54 [Buildroot] [PATCH 0/2] arch/csky: clean up conditions on gcc verssion (branch yem/arch-csky) Yann E. MORIN 2019-07-14 9:54 ` [Buildroot] [PATCH 1/2] arch/csky: restrict ck610 to the C-SKY gcc port Yann E. MORIN 2019-07-15 16:02 ` Guo Ren 2019-07-15 16:53 ` Yann E. MORIN 2019-07-15 23:06 ` Guo Ren 2019-07-15 23:08 ` Guo Ren 2019-07-14 9:54 ` [Buildroot] [PATCH 2/2] package/gcc: drop negative conditions on C-SKY for older versions Yann E. MORIN 2019-07-15 15:52 ` Guo Ren 2019-07-15 19:57 ` Yann E. MORIN 2019-07-15 23:07 ` Guo Ren
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox