[Buildroot] [PATCH v2 1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs

[Buildroot] [PATCH v2 1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs

[Atharva Lele]

We don't use the GZIP environment variable to store GZIP options
anymore. So explicitly add -n argument to the GZIP call to ensure
reproducibility.

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
  - Reversed order of patches
---
 fs/common.mk | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/fs/common.mk b/fs/common.mk
index fceb38c5b9..ca46a331d6 100644
--- a/fs/common.mk
+++ b/fs/common.mk
@@ -115,7 +115,7 @@ ROOTFS_$(2)_FINAL_RECURSIVE_DEPENDENCIES = $$(sort \
 
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_GZIP),y)
 ROOTFS_$(2)_COMPRESS_EXT = .gz
-ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c
+ROOTFS_$(2)_COMPRESS_CMD = gzip -9 -c -n
 endif
 ifeq ($$(BR2_TARGET_ROOTFS_$(2)_BZIP2),y)
 ROOTFS_$(2)_COMPRESS_EXT = .bz2
-- 
2.22.0

[Buildroot] [PATCH v2 2/2] Makefile: don't export GZIP environment variable

[Atharva Lele]

We export GZIP = -n so that GZIP does not record original
name and timestamps. However..

GZIP environment variable is deprecated and soon will not be
supported in future GZIP versions. GZIP suggests the use of a
wrapper to pass options globally but it might be difficult to
implement in Buildroot. For now, we don't export the variable
and fix reproducibility issues per package as they show up in
Autobuilder.

Signed-off-by: Atharva Lele <itsatharva@gmail.com>
Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
---
Changes v1 -> v2:
  - Reversed order of patches
---
 Makefile | 1 -
 1 file changed, 1 deletion(-)

diff --git a/Makefile b/Makefile
index c98a0ed87e..9cce934990 100644
--- a/Makefile
+++ b/Makefile
@@ -248,7 +248,6 @@ ifeq ($(BR2_REPRODUCIBLE),y)
 export TZ = UTC
 export LANG = C
 export LC_ALL = C
-export GZIP = -n
 endif
 
 # To put more focus on warnings, be less verbose as default
-- 
2.22.0

[Buildroot] [PATCH v2 1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs

[Thomas Petazzoni]

Hello Atharva,

On Tue, 16 Jul 2019 23:12:13 +0530
Atharva Lele <itsatharva@gmail.com> wrote:

> We don't use the GZIP environment variable to store GZIP options
> anymore. So explicitly add -n argument to the GZIP call to ensure
> reproducibility.
> 
> Signed-off-by: Atharva Lele <itsatharva@gmail.com>
> Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
> ---
> Changes v1 -> v2:
>   - Reversed order of patches
> ---
>  fs/common.mk | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

Both applied, thanks! I had to reword a little bit the commit log of
PATCH 1/2, because the wording was no longer really appropriate after
you swapped the order of the two patches.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/2] fs/common.mk: do not store original names and timestamps when creating GZIP rootfs

[Peter Korsgaard]

>>>>> "Atharva" == Atharva Lele <itsatharva@gmail.com> writes:

 > We don't use the GZIP environment variable to store GZIP options
 > anymore. So explicitly add -n argument to the GZIP call to ensure
 > reproducibility.

 > Signed-off-by: Atharva Lele <itsatharva@gmail.com>
 > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2019.02.x and 2019.05.x, thanks.

-- 
Bye, Peter Korsgaard

[Buildroot] [PATCH v2 2/2] Makefile: don't export GZIP environment variable

[Peter Korsgaard]

>>>>> "Atharva" == Atharva Lele <itsatharva@gmail.com> writes:

 > We export GZIP = -n so that GZIP does not record original
 > name and timestamps. However..

 > GZIP environment variable is deprecated and soon will not be
 > supported in future GZIP versions. GZIP suggests the use of a
 > wrapper to pass options globally but it might be difficult to
 > implement in Buildroot. For now, we don't export the variable
 > and fix reproducibility issues per package as they show up in
 > Autobuilder.

 > Signed-off-by: Atharva Lele <itsatharva@gmail.com>
 > Acked-by: Yann E. MORIN <yann.morin.1998@free.fr>
 > ---
 > Changes v1 -> v2:
 >   - Reversed order of patches

Committed to 2019.02.x and 2019.05.x, thanks.

-- 
Bye, Peter Korsgaard