Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA
Date: Wed, 17 Jul 2019 08:43:47 +0200	[thread overview]
Message-ID: <20190717084347.784866e3@windsurf> (raw)
In-Reply-To: <20190716175830.604552-1-alex_y_xu@yahoo.ca>

Hello Alex,

On Tue, 16 Jul 2019 13:58:30 -0400
"Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:

> Signed-off-by: Alex Xu (Hello71) <alex_y_xu@yahoo.ca>

Thanks for your patch. However, the commit log is empty, and therefore
it doesn't carry any explanation as to why this change is necessary.
Could you give more details ?

> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
> index 1fd56ceaf6..c247fa89d0 100644
> --- a/package/python-idna/Config.in
> +++ b/package/python-idna/Config.in
> @@ -1,5 +1,6 @@
>  config BR2_PACKAGE_PYTHON_IDNA
>  	bool "python-idna"
> +        select BR2_PACKAGE_PYTHON3_UNICODEDATA

Nit: there is an indentation problem, we indent those lines with a tab,
not with spaces.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

  reply	other threads:[~2019-07-17  6:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-16 17:58 [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA Alex Xu
2019-07-17  6:43 ` Thomas Petazzoni [this message]
2019-07-17 19:12   ` [Buildroot] [PATCH v2] " Alex Xu
2019-07-18 20:27     ` Thomas Petazzoni
2019-08-04 20:13       ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190717084347.784866e3@windsurf \
    --to=thomas.petazzoni@bootlin.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox