From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] package/python-idna: select PYTHON3_UNICODEDATA
Date: Sun, 04 Aug 2019 22:13:23 +0200 [thread overview]
Message-ID: <87lfw8pu3g.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190718222738.6db4d00d@windsurf> (Thomas Petazzoni's message of "Thu, 18 Jul 2019 22:27:38 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Alex,
> Thanks for the new iteration of the patch. There was still an issue,
> but see below.
> On Wed, 17 Jul 2019 15:12:15 -0400
> "Alex Xu (Hello71)" <alex_y_xu@yahoo.ca> wrote:
>> diff --git a/package/python-idna/Config.in b/package/python-idna/Config.in
>> index 1fd56ceaf6..ddc2cd7d17 100644
>> --- a/package/python-idna/Config.in
>> +++ b/package/python-idna/Config.in
>> @@ -1,5 +1,6 @@
>> config BR2_PACKAGE_PYTHON_IDNA
>> bool "python-idna"
>> + select BR2_PACKAGE_PYTHON3_UNICODEDATA
> This only takes care of the case where python3 is used, by python-idna
> can also be used when python (2.x) is selected.
> So I changed this to:
> + select BR2_PACKAGE_PYTHON_UNICODEDATA if BR2_PACKAGE_PYTHON
> + select BR2_PACKAGE_PYTHON3_UNICODEDATA if BR2_PACKAGE_PYTHON3
> and applied.
Committed to 2019.02.x and 2019.05.x with the same fixes, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-08-04 20:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-16 17:58 [Buildroot] [PATCH] package/python-idna: select PYTHON3_UNICODEDATA Alex Xu
2019-07-17 6:43 ` Thomas Petazzoni
2019-07-17 19:12 ` [Buildroot] [PATCH v2] " Alex Xu
2019-07-18 20:27 ` Thomas Petazzoni
2019-08-04 20:13 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfw8pu3g.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox