* [Buildroot] [PATCH v13 1/5] package/libiberty: new package
@ 2019-08-04 0:14 aduskett at gmail.com
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
` (4 more replies)
0 siblings, 5 replies; 11+ messages in thread
From: aduskett at gmail.com @ 2019-08-04 0:14 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
Some packages, like prelink-cross, will want to use libiberty but do
not bundle their own instance (which is good!).
However, libiberty is made for being bundled in packages: all GNU
packages that use libiberty (gcc, binutils, gdb et al...) all have
their own bundled variant. This means that there is no official
upstream for libiberty; the closest being as part of the
combined binutils-gdb tree.
So we introduce a new host-only package, that installs just libiberty
from a binutils released tarball.
Again, as libiberty is usually bundled in packages, it usually only
install a static version. Furthermore, it does not obey to the usual
--enable-shared and --disable-static flags; it only ever builds a
static version.
Furthermore, this library is not built with -fPIC, but some packages
may pick it to build shared objects. This is the case for host-gdb,
for example, which accidentally picks that library instead of its
internal one.
So, rather than fix the various gdb versions and variants we can use,
we ensure that the libiberty we install is usable in shared objects,
and we ensure it is always built before host-gdb.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v1 -> v11:
- Add this patch to the series
DEVELOPERS | 1 +
package/libiberty/libiberty.hash | 2 ++
package/libiberty/libiberty.mk | 27 +++++++++++++++++++++++++++
3 files changed, 30 insertions(+)
create mode 100644 package/libiberty/libiberty.hash
create mode 100644 package/libiberty/libiberty.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 8a83f748d1..e9da0c7f50 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2362,6 +2362,7 @@ F: package/keyutils/
F: package/libbsd/
F: package/libedit/
F: package/libgsm/
+F: package/libiberty/
F: package/libinput/
F: package/libiscsi/
F: package/libpri/
diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
new file mode 100644
index 0000000000..270f38dfa7
--- /dev/null
+++ b/package/libiberty/libiberty.hash
@@ -0,0 +1,2 @@
+# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
+sha512 d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724afa1e43bd0db45cfc9916b41519b67dfce03232aa4978704492a6994a binutils-2.32.tar.xz
diff --git a/package/libiberty/libiberty.mk b/package/libiberty/libiberty.mk
new file mode 100644
index 0000000000..17976fdd4f
--- /dev/null
+++ b/package/libiberty/libiberty.mk
@@ -0,0 +1,27 @@
+################################################################################
+#
+# libiberty
+#
+################################################################################
+
+LIBIBERTY_VERSION = 2.32
+LIBIBERTY_SOURCE = binutils-$(LIBIBERTY_VERSION).tar.xz
+LIBIBERTY_SITE = $(BR2_GNU_MIRROR)/binutils
+LIBIBERTY_DL_SUBDIR = binutils
+LIBIBERTY_SUBDIR = libiberty
+
+# We explicitly disable multilib, as we do in binutils.
+# By default, libiberty installs nothing, so we must force it.
+HOST_LIBIBERTY_CONF_OPTS = \
+ --disable-multilib \
+ --enable-install-libiberty
+
+# Some packages (e.g. host-gdb) will pick this library and build shared
+# objects with it. But libiberty does not honour the --enable-shared and
+# --disable-static flags; it only ever builds a static library no matter
+# what. So we must force -fPIC in build flags.
+HOST_LIBIBERTY_CONF_ENV = \
+ CFLAGS="$(HOST_CFLAGS) -fPIC" \
+ LDFLAGS="$(HOST_LDFLAGS) -fPIC"
+
+$(eval $(host-autotools-package))
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 2/5] package/prelink-cross: new package
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
@ 2019-08-04 0:14 ` aduskett at gmail.com
2019-08-04 6:07 ` Yann E. MORIN
2019-08-04 8:16 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty aduskett at gmail.com
` (3 subsequent siblings)
4 siblings, 2 replies; 11+ messages in thread
From: aduskett at gmail.com @ 2019-08-04 0:14 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
Prelink-cross emulates a runtime linker for a given sysroot. This is
necessary to allow gobject-introspection to build its typelib files
during cross-compiling.
We're using a sha1 on the cross_prelink branch, as we need the
RTLD-enabled variant of prelink-cross.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v11 -> v12:
- Change version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2 as the commit
id b10e14218646d8b74773b82b0f8b395bce698fa2 no longer exists.
Changes v10 -> v11:
- adopted by Yann
- switch to a https git server
- drop the Config.in.host entry
- fix typo in commit log
Changes v9 -> v10:
- None
Changes v8 -> v9:
- Add the package to the DEVELOPERS file under my name.
- Bump version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2
- Add host-elfutils as a dependency.
Changes v7 -> v8:
- None
Changes v1 -> v7:
- Add patch to series.
DEVELOPERS | 1 +
package/prelink-cross/prelink-cross.hash | 3 +++
package/prelink-cross/prelink-cross.mk | 15 +++++++++++++++
3 files changed, 19 insertions(+)
create mode 100644 package/prelink-cross/prelink-cross.hash
create mode 100644 package/prelink-cross/prelink-cross.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index e9da0c7f50..407f3f1b1d 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -56,6 +56,7 @@ F: package/openjdk/
F: package/openjdk-bin/
F: package/php/
F: package/policycoreutils/
+F: package/prelink-cross/
F: package/python3/
F: package/python-flask-sqlalchemy/
F: package/python-mutagen/
diff --git a/package/prelink-cross/prelink-cross.hash b/package/prelink-cross/prelink-cross.hash
new file mode 100644
index 0000000000..3ac33ac3d0
--- /dev/null
+++ b/package/prelink-cross/prelink-cross.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 cb3f5d833cd74b7e90e38465c9c948b0f4138c017509cb91e391b0931063429e prelink-cross-a853a5d715d84eec93aa68e8f2df26b7d860f5b2.tar.gz
+sha256 b8a2f73f743dc1a51aff23f1aacbca4b868564db52496fa3c0caba755bfd1eaf COPYING
diff --git a/package/prelink-cross/prelink-cross.mk b/package/prelink-cross/prelink-cross.mk
new file mode 100644
index 0000000000..d97141bab4
--- /dev/null
+++ b/package/prelink-cross/prelink-cross.mk
@@ -0,0 +1,15 @@
+################################################################################
+#
+# host-prelink-cross
+#
+################################################################################
+
+HOST_PRELINK_CROSS_VERSION = a853a5d715d84eec93aa68e8f2df26b7d860f5b2
+HOST_PRELINK_CROSS_SITE = https://git.yoctoproject.org/git/prelink-cross
+HOST_PRELINK_CROSS_SITE_METHOD = git
+HOST_PRELINK_CROSS_LICENSE = GPL-2.0
+HOST_PRELINK_CROSS_LICENSE_FILES = COPYING
+HOST_PRELINK_CROSS_AUTORECONF = YES
+HOST_PRELINK_CROSS_DEPENDENCIES = host-elfutils host-libiberty
+
+$(eval $(host-autotools-package))
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
@ 2019-08-04 0:14 ` aduskett at gmail.com
2019-08-04 8:17 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation aduskett at gmail.com
` (2 subsequent siblings)
4 siblings, 1 reply; 11+ messages in thread
From: aduskett at gmail.com @ 2019-08-04 0:14 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
If present, GDB may use a system installed libiberty. As such, we must ensure
that host-libiberty is installed first.
Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
v1 -> v11:
- Add this patch to the series
package/gdb/gdb.mk | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
index 46d745a897..39d20be1aa 100644
--- a/package/gdb/gdb.mk
+++ b/package/gdb/gdb.mk
@@ -35,7 +35,9 @@ endif
# For the host variant, we really want to build with XML support,
# which is needed to read XML descriptions of target architectures. We
# also need ncurses.
-HOST_GDB_DEPENDENCIES = host-expat host-ncurses
+# As for libiberty, gdb may use a system-isntalled one if present, so
+# we must ensure ours is installed first.
+HOST_GDB_DEPENDENCIES = host-expat host-libiberty host-ncurses
# Disable building documentation
GDB_MAKE_OPTS += MAKEINFO=true
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
2019-08-04 0:14 ` [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty aduskett at gmail.com
@ 2019-08-04 0:14 ` aduskett at gmail.com
2019-08-04 22:05 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 5/5] package/gobject-introspection: new package aduskett at gmail.com
2019-08-04 22:23 ` [Buildroot] [PATCH v13 1/5] package/libiberty: " Arnout Vandecappelle
4 siblings, 1 reply; 11+ messages in thread
From: aduskett at gmail.com @ 2019-08-04 0:14 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
From: https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-devtools/meson/meson/
Meson exports a bunch of PKG_CONFIG_ variables which causes a double prefix for
the staging python include directory.
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v11 -> v12:
- Remove accidental copy and paste in the commit message.
Changes v1 -> v11:
- Add this patch to the series
...-environment-when-calling-pkg-config.patch | 48 +++++++++++++++++++
1 file changed, 48 insertions(+)
create mode 100644 package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
diff --git a/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch b/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
new file mode 100644
index 0000000000..a72be80bae
--- /dev/null
+++ b/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
@@ -0,0 +1,48 @@
+From 3cb2c811dc6d4890342afa5b709cd30cf7b8f3ca Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Mon, 19 Nov 2018 14:24:26 +0100
+Subject: [PATCH] python module: do not manipulate the environment when calling pkg-config
+
+From: https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-devtools/meson/meson/
+
+Meson exports a bunch of PKG_CONFIG_ variables which causes a double prefix to
+the python include directory.
+
+Upstream-Status: Inappropriate [embedded specific]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+
+---
+ mesonbuild/modules/python.py | 12 ------------
+ 1 file changed, 12 deletions(-)
+
+diff --git a/mesonbuild/modules/python.py b/mesonbuild/modules/python.py
+index 9cfbd6f..3ff687a 100644
+--- a/mesonbuild/modules/python.py
++++ b/mesonbuild/modules/python.py
+@@ -76,11 +76,6 @@ class PythonDependency(ExternalDependency):
+ old_pkg_libdir = os.environ.get('PKG_CONFIG_LIBDIR')
+ old_pkg_path = os.environ.get('PKG_CONFIG_PATH')
+
+- os.environ.pop('PKG_CONFIG_PATH', None)
+-
+- if pkg_libdir:
+- os.environ['PKG_CONFIG_LIBDIR'] = pkg_libdir
+-
+ try:
+ self.pkgdep = PkgConfigDependency('python-{}'.format(pkg_version), environment, kwargs)
+ mlog.debug('Found "python-{}" via pkgconfig lookup in LIBPC ({})'.format(pkg_version, pkg_libdir))
+@@ -89,13 +84,6 @@ class PythonDependency(ExternalDependency):
+ mlog.debug('"python-{}" could not be found in LIBPC ({})'.format(pkg_version, pkg_libdir))
+ mlog.debug(e)
+
+- if old_pkg_path is not None:
+- os.environ['PKG_CONFIG_PATH'] = old_pkg_path
+-
+- if old_pkg_libdir is not None:
+- os.environ['PKG_CONFIG_LIBDIR'] = old_pkg_libdir
+- else:
+- os.environ.pop('PKG_CONFIG_LIBDIR', None)
+ else:
+ mlog.debug('"python-{}" could not be found in LIBPC ({}), this is likely due to a relocated python installation'.format(pkg_version, pkg_libdir))
+
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 5/5] package/gobject-introspection: new package
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
` (2 preceding siblings ...)
2019-08-04 0:14 ` [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation aduskett at gmail.com
@ 2019-08-04 0:14 ` aduskett at gmail.com
2019-08-04 22:23 ` [Buildroot] [PATCH v13 1/5] package/libiberty: " Arnout Vandecappelle
4 siblings, 0 replies; 11+ messages in thread
From: aduskett at gmail.com @ 2019-08-04 0:14 UTC (permalink / raw)
To: buildroot
From: Adam Duskett <Aduskett@gmail.com>
GObject introspection is a middleware layer between C
libraries (using GObject) and language bindings. The C library
can be scanned at compile time and generate a metadata file,
in addition to the actual native C library. Then at runtime,
language bindings can read this metadata and automatically
provide bindings to call into the C library.
There's an XML format called GIR used by GObject-Introspection.
The purpose of it is to provide a standard structure to access the
complete available API that a library or other unit of code exports.
It is meant to be language agnostic using namespaces to separate
core, language or library specific functionality.
Cross-compiling gobject-introspection is not an easy task. The main
issue is that in the process of creating the XML files,
gobject-introspection must first run and scan the binary, which, if the
binary is cross-compiled, would not typically be possible from the host
system.
Because of this limitation, several wrappers are used to call instead
first out qemu which will then run the native scanner to create the
binaries.
There are seven total patches and four different wrapper files needed
to successfully cross-compile and run this package, many of them are
from open-embedded, but two of them are of my own doing.
1) Revert a previous, incomplete attempt at adding cross-compiling support.
2) Add support for cross compiling with meson.
3) Disable tests when cross-compiling.
4) Add support for the various wrappers. (See patch for details.)
5) Add an option to use a binary wrapper; this patch will force
giscanner to use a wrapper executable to run binaries it's producing,
instead of attempting to run them from the host.
6) Add an option to use an LDD wrapper, again, useful for cross-compiled
environments.
7) Add a --lib-dirs-envar option to pass to giscanner. (See patch for details.)
8) Add rpath-links to ccompiler: when passing the PACKAGE_GIR_EXTRA_LIBS_PATH
to the ccompiler.py script, ccompiler.py needs to add -Wl,-rpath-link to the
environment for the package to correctly link against the passed on paths.
9) Ignore error return codes from ldd-wrapper because prelink-rtld returns 127
when it can't find a library, which will break subprocess.check_output().
Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v10 -> v11:
- reorder config.in entries: arch deps first, then toolchain deps
and order packages deps alphabetically (Yann)
- drop dependency on threads, wchar, and !static: it's implicit from
glibc (Yann)
- Bump to version 1.60.2
- Switched to a meson build system as autotools is no longer supported with
gobject-introspection 1.60.x.
- Removed the following patches that are no longer needed:
- 0002-configure.ac-add-host-gi-gi-cross-wrapper-gi-ldd-wra.patch
- 0005-user-PYTHON_CONFIG-to-find-includes.patch
- 0008-fix-gobject-pc.file.patch
- Add the following patches:
- 0002-add-cross-compilation-support-to-meson.patch
- 0003-meson.build-disable-tests-when-cross-compiling.patch
- 0008-ignore-error-return-codes-from-ldd-wrapper.patch
Changes v9 -> v10:
- Makefile cleanup
- Fix license syntax (Thomas)
- Add libffi as a mandatory dependency (Thomas)
- remove --disalbe-static (Thomas)
- add --with-cairo if the cairo package is selected (Thomas)
- Change PYTHON_INCLUDES to PYTHON_CONFIG in gobject-introspection.mk
(Thomas)
- Use | for all sed functions (Thomas)
- Remove GOBJECT_INTROSPECTION_WRAPPERS (Thomas)
- Add GOBJECT_INTROSPECTION_REMOVE_DEVELOPMENT_FILES target finalize
hook. (Thomas)
- Use $(dirname $0) in wrappers instead of $STAGING_DIR (Thomas)
- Remove _GIR_EXTRA_LIBS_PATH in pkg-autotools.mk in favor of a
seperate patch. (Thomas)
Changes v8 -> v9:
- Create the $(STAGING_DIR)/usr/lib/gio/modules-dummy directory in the
GOBJECT_INTROSPECTION_POST_PATCH_HOOKS to prevent qemu from
segfaulting when g-ir-scanner-qemuwrapper is ran.
- Remove the $(STAGING_DIR) prefix from gobject-introspection-1.0.pc
to prevent pkg-config from appending a second staging_dir to the path
of the g-ir-compiler. This prevents packages such a gstreamer1 from
trying to call $(STAGING_DIR)/$(STAGING_DIR)/usr/bin/g-ir-compiler,
which will break the build.
Changes v7 -> v8:
- Add "select BR2_PACKAGE_HOST_PRELINK_CROSS" to Config.in
Changes v6 -> v7:
- Remove the cross-ldd script in favor of the prelink-cross package.
- Install the ldd and qemu wrappers in a post patch hook seperate of
the other wrappers.
- Set --enable-introspection-data in the configure options.
Changes v5 -> v6:
- Update gobject-introspection to 1.56.1
- Remove upstreamed 0008-add-Float128.patch
Changes v4 -> v5:
- Added a more detailed commit message (Yann)
- Removed $HOST_DIR/bin/qemu- at HOST_QEMU_ARCH@ @HOST_QEMU_CPU_TUNE@
in favor of @QEMU_USER@ (Thanks Yann)
Changes v3 -> v4:
- Removed RFC tag.
- Added 0007-Add-rpath-links-to-ccompiler.patch
- Removed config-paths-with-PKG_CONFIG_SYSROOT_DIR-.patch as it is not
Yocto specific.
- Added the _GIR_EXTRA_LIBS_PATH to pkg-autotools.mk. This allows
package specific Gir libraries to be passed on to
g-ir-scanner-qemuwrapper.
- Fixed a typo in g-ir-scanner-qemuwrapper.in.
- Remove BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS_TARGET in
favor of BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
Changes v2 -> v3:
- Removed Linux kernel dependency (baruch)
- Changed $(LINUX_VERSION) to $(BR2_TOOLCHAIN_HEADERS_AT_LEAST)
(baruch)
- Changed @LINUX_VERSION@ in g-ir-scanner-qemuwrapper.in to
@TOOLCHAIN_HEADERS_VERSION@ to match the above variable change.
- Added BR2_PACKAGE_GOBJECT_INTROSPECTION_ARCH_SUPPORTS_TARGET in
Config.in with only BR2_arm selected for now.
- Removed BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS in favor of the above
change.
- Added two new lines in the base Makefile which removes any remaining
.gir or .rnc files from the target filing system, as these are not
needed or runtime, only compile time.
Changes v1 -> v2:
- Fixed wrappers
- Added 0007-giscanner-add-a-lib-dirs-envvar-option.patch
- Added 0008-add-Float128.patch
DEVELOPERS | 1 +
package/Config.in | 1 +
...lete-upstream-attempt-at-cross-compi.patch | 33 ++++
...d-cross-compilation-support-to-meson.patch | 163 ++++++++++++++++++
...d-disable-tests-when-cross-compiling.patch | 27 +++
...canner-add-use-binary-wrapper-option.patch | 52 ++++++
...scanner-add-a-use-ldd-wrapper-option.patch | 48 ++++++
...scanner-add-a-lib-dirs-envvar-option.patch | 73 ++++++++
.../0007-Add-rpath-links-to-ccompiler.patch | 29 ++++
...-error-return-codes-from-ldd-wrapper.patch | 28 +++
package/gobject-introspection/Config.in | 26 +++
.../gobject-introspection/g-ir-compiler.in | 2 +
.../g-ir-scanner-lddwrapper.in | 2 +
.../g-ir-scanner-qemuwrapper.in | 17 ++
package/gobject-introspection/g-ir-scanner.in | 7 +
.../gobject-introspection.hash | 4 +
.../gobject-introspection.mk | 103 +++++++++++
17 files changed, 616 insertions(+)
create mode 100644 package/gobject-introspection/0001-Revert-an-incomplete-upstream-attempt-at-cross-compi.patch
create mode 100644 package/gobject-introspection/0002-add-cross-compilation-support-to-meson.patch
create mode 100644 package/gobject-introspection/0003-meson.build-disable-tests-when-cross-compiling.patch
create mode 100644 package/gobject-introspection/0004-giscanner-add-use-binary-wrapper-option.patch
create mode 100644 package/gobject-introspection/0005-giscanner-add-a-use-ldd-wrapper-option.patch
create mode 100644 package/gobject-introspection/0006-giscanner-add-a-lib-dirs-envvar-option.patch
create mode 100644 package/gobject-introspection/0007-Add-rpath-links-to-ccompiler.patch
create mode 100644 package/gobject-introspection/0008-ignore-error-return-codes-from-ldd-wrapper.patch
create mode 100644 package/gobject-introspection/Config.in
create mode 100644 package/gobject-introspection/g-ir-compiler.in
create mode 100644 package/gobject-introspection/g-ir-scanner-lddwrapper.in
create mode 100644 package/gobject-introspection/g-ir-scanner-qemuwrapper.in
create mode 100644 package/gobject-introspection/g-ir-scanner.in
create mode 100644 package/gobject-introspection/gobject-introspection.hash
create mode 100644 package/gobject-introspection/gobject-introspection.mk
diff --git a/DEVELOPERS b/DEVELOPERS
index 407f3f1b1d..f5c52b47e3 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -34,6 +34,7 @@ F: package/audit/
F: package/busybox/
F: package/checkpolicy/
F: package/cppdb/
+F: package/gobject-introspection/
F: package/gstreamer1/gstreamer1/
F: package/gstreamer1/gstreamer1-mm/
F: package/gstreamer1/gst1-plugins-bad/
diff --git a/package/Config.in b/package/Config.in
index f84effff01..8696864f47 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -1690,6 +1690,7 @@ menu "Other"
source "package/glibmm/Config.in"
source "package/glm/Config.in"
source "package/gmp/Config.in"
+ source "package/gobject-introspection/Config.in"
source "package/gsl/Config.in"
source "package/gtest/Config.in"
source "package/jemalloc/Config.in"
diff --git a/package/gobject-introspection/0001-Revert-an-incomplete-upstream-attempt-at-cross-compi.patch b/package/gobject-introspection/0001-Revert-an-incomplete-upstream-attempt-at-cross-compi.patch
new file mode 100644
index 0000000000..1e8bd3518a
--- /dev/null
+++ b/package/gobject-introspection/0001-Revert-an-incomplete-upstream-attempt-at-cross-compi.patch
@@ -0,0 +1,33 @@
+From 3a9d1e5ee0aae56fafec0beba2014c19e4ff310c Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Wed, 23 Mar 2016 17:07:28 +0200
+Subject: [PATCH] Revert an incomplete upstream attempt at cross-compile support
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ common.mk | 4 ----
+ giscanner/gdumpparser.py | 6 ------
+ 2 files changed, 10 deletions(-)
+
+diff --git a/giscanner/gdumpparser.py b/giscanner/gdumpparser.py
+index 1134f33..9bdc2bc 100644
+--- a/giscanner/gdumpparser.py
++++ b/giscanner/gdumpparser.py
+@@ -156,12 +156,6 @@ blob containing data gleaned from GObject's primitive introspection."""
+ out_path = os.path.join(self._binary.tmpdir, 'dump.xml')
+
+ args = []
+-
+- # Prepend the launcher command and arguments, if defined
+- launcher = os.environ.get('GI_CROSS_LAUNCHER')
+- if launcher:
+- args.extend(launcher.split())
+-
+ args.extend(self._binary.args)
+ args.append('--introspect-dump=%s,%s' % (in_path, out_path))
+
+--
+2.7.0
+
diff --git a/package/gobject-introspection/0002-add-cross-compilation-support-to-meson.patch b/package/gobject-introspection/0002-add-cross-compilation-support-to-meson.patch
new file mode 100644
index 0000000000..5e3ac59dd9
--- /dev/null
+++ b/package/gobject-introspection/0002-add-cross-compilation-support-to-meson.patch
@@ -0,0 +1,163 @@
+From 2b3bce1526b538dc2c7fa223eaf9808858aa1b06 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Thu, 15 Nov 2018 15:10:05 +0100
+Subject: [PATCH] add cross-compilation support to meson
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ gir/meson.build | 62 ++++++++++++++++++++++++++++++++++-------------
+ meson.build | 4 ++-
+ meson_options.txt | 20 +++++++++++++++
+ 3 files changed, 68 insertions(+), 18 deletions(-)
+
+diff --git a/gir/meson.build b/gir/meson.build
+index 85ae575..327c134 100644
+--- a/gir/meson.build
++++ b/gir/meson.build
+@@ -36,16 +36,29 @@ gir_files = [
+ typelibdir = join_paths(get_option('libdir'), 'girepository-1.0')
+ install_data(gir_files, install_dir: girdir)
+
+-scanner_command = [
+- python,
+- girscanner,
+- '--output=@OUTPUT@',
+- '--no-libtool',
+- '--quiet',
+- '--reparse-validate',
+- '--add-include-path', join_paths(meson.current_build_dir()),
+- '--add-include-path', join_paths(meson.current_source_dir()),
+-]
++if get_option('enable-host-gi')
++ scanner_command = [
++ 'g-ir-scanner',
++ '--output=@OUTPUT@',
++ '--no-libtool',
++ '--quiet',
++ '--reparse-validate',
++ '--add-include-path', join_paths(meson.current_build_dir()),
++ '--add-include-path', join_paths(meson.current_source_dir()),
++ ]
++else
++ scanner_command = [
++ python,
++ girscanner,
++ '--output=@OUTPUT@',
++ '--no-libtool',
++ '--quiet',
++ '--reparse-validate',
++ '--add-include-path', join_paths(meson.current_build_dir()),
++ '--add-include-path', join_paths(meson.current_source_dir()),
++ ]
++endif
++
+
+ dep_type = glib_dep.type_name()
+ if dep_type == 'internal'
+@@ -58,6 +71,12 @@ if dep_type == 'internal'
+ '--extra-library=glib-2.0', '--extra-library=gobject-2.0']
+ endif
+
++if get_option('enable-gi-cross-wrapper') != ''
++ scanner_command += ['--use-binary-wrapper=' + get_option('enable-gi-cross-wrapper')]
++endif
++if get_option('enable-gi-ldd-wrapper') != ''
++ scanner_command += ['--use-ldd-wrapper=' + get_option('enable-gi-ldd-wrapper')]
++endif
+ # Take a glob and print to newlines
+ globber = '''
+ from glob import glob
+@@ -84,8 +103,8 @@ glib_command = scanner_command + [
+
+ if dep_type == 'pkgconfig'
+ glib_command += ['--external-library', '--pkg=glib-2.0']
+- glib_libdir = glib_dep.get_pkgconfig_variable('libdir')
+- glib_incdir = join_paths(glib_dep.get_pkgconfig_variable('includedir'), 'glib-2.0')
++ glib_libdir = get_option('pkgconfig-sysroot-path') + glib_dep.get_pkgconfig_variable('libdir')
++ glib_incdir = get_option('pkgconfig-sysroot-path') + join_paths(glib_dep.get_pkgconfig_variable('includedir'), 'glib-2.0')
+ glib_libincdir = join_paths(glib_libdir, 'glib-2.0', 'include')
+ glib_files += join_paths(glib_incdir, 'gobject', 'glib-types.h')
+ glib_files += join_paths(glib_libincdir, 'glibconfig.h')
+@@ -339,7 +358,7 @@ endforeach
+ if giounix_dep.found()
+ if dep_type == 'pkgconfig'
+ gio_command += ['--pkg=gio-unix-2.0']
+- giounix_includedir = join_paths(giounix_dep.get_pkgconfig_variable('includedir'), 'gio-unix-2.0')
++ giounix_includedir = get_option('pkgconfig-sysroot-path') + join_paths(giounix_dep.get_pkgconfig_variable('includedir'), 'gio-unix-2.0')
+ # Get the installed gio-unix header list
+ ret = run_command(python, '-c', globber.format(join_paths(giounix_includedir, 'gio', '*.h')))
+ if ret.returncode() != 0
+@@ -422,15 +441,24 @@ gir_files += custom_target('gir-girepository',
+ )
+
+ typelibs = []
++if get_option('enable-gi-cross-wrapper') != ''
++ gircompiler_command = [get_option('enable-gi-cross-wrapper'), gircompiler.full_path(), '-o', '@OUTPUT@', '@INPUT@',
++ '--includedir', meson.current_build_dir(),
++ '--includedir', meson.current_source_dir(),
++ ]
++else
++ gircompiler_command = [gircompiler, '-o', '@OUTPUT@', '@INPUT@',
++ '--includedir', meson.current_build_dir(),
++ '--includedir', meson.current_source_dir(),
++ ]
++endif
++
+ foreach gir : gir_files
+ typelibs += custom_target('generate-typelib- at 0@'.format(gir).underscorify(),
+ input: gir,
+ output: '@BASENAME at .typelib',
+ depends: [gobject_gir, ],
+- command: [gircompiler, '-o', '@OUTPUT@', '@INPUT@',
+- '--includedir', meson.current_build_dir(),
+- '--includedir', meson.current_source_dir(),
+- ],
++ command: gircompiler_command,
+ install: true,
+ install_dir: typelibdir,
+ )
+diff --git a/meson.build b/meson.build
+index 95bbd2b..f7baefd 100644
+--- a/meson.build
++++ b/meson.build
+@@ -163,7 +163,9 @@ endif
+ subdir('girepository')
+ subdir('tools')
+ subdir('giscanner')
+-subdir('gir')
++if get_option('enable-introspection-data') == true
++ subdir('gir')
++endif
+ subdir('examples')
+ subdir('docs')
+ subdir('tests')
+diff --git a/meson_options.txt b/meson_options.txt
+index 445a68a..a325511 100644
+--- a/meson_options.txt
++++ b/meson_options.txt
+@@ -25,3 +25,23 @@ option('python', type: 'string', value: 'python3',
+ option('gir_dir_prefix', type: 'string',
+ description: 'Intermediate prefix for gir installation under ${prefix}'
+ )
++
++option('enable-host-gi', type: 'boolean', value : false,
++ description: 'Use gobject introspection tools installed in the host system (useful when cross-compiling)'
++)
++
++option('enable-gi-cross-wrapper', type: 'string',
++ description: 'Use a wrapper to run gicompiler and binaries produced by giscanner (useful when cross-compiling)'
++)
++
++option('enable-gi-ldd-wrapper', type: 'string',
++ description: 'Use a ldd wrapper instead of system ldd command in giscanner (useful when cross-compiling)'
++)
++
++option('enable-introspection-data', type: 'boolean', value : true,
++ description: 'Build introspection data (.gir and .typelib files) in addition to library and tools'
++)
++
++option('pkgconfig-sysroot-path', type: 'string',
++ description: 'Specify a sysroot path to prepend to pkgconfig output (useful when cross-compiling)'
++)
diff --git a/package/gobject-introspection/0003-meson.build-disable-tests-when-cross-compiling.patch b/package/gobject-introspection/0003-meson.build-disable-tests-when-cross-compiling.patch
new file mode 100644
index 0000000000..10d592272a
--- /dev/null
+++ b/package/gobject-introspection/0003-meson.build-disable-tests-when-cross-compiling.patch
@@ -0,0 +1,27 @@
+From 2c384187cc22113c0c9b1cd233948118f7c085ef Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Mon, 25 Mar 2019 13:28:48 +0100
+Subject: [PATCH] meson.build: disable tests when cross-compiling
+
+Upstream-Status: Submitted [https://gitlab.gnome.org/GNOME/gobject-introspection/merge_requests/64]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ meson.build | 4 +++-
+ 1 file changed, 3 insertions(+), 1 deletion(-)
+
+diff --git a/meson.build b/meson.build
+index 2544ff3..4c16fe5 100644
+--- a/meson.build
++++ b/meson.build
+@@ -168,7 +168,9 @@ if get_option('enable-introspection-data') == true
+ endif
+ subdir('examples')
+ subdir('docs')
+-subdir('tests')
++if not meson.is_cross_build()
++ subdir('tests')
++endif
+
+ install_data('Makefile.introspection', install_dir: join_paths(get_option('datadir'), 'gobject-introspection-1.0'))
+ install_data('m4/introspection.m4', install_dir: join_paths(get_option('datadir'), 'aclocal'))
diff --git a/package/gobject-introspection/0004-giscanner-add-use-binary-wrapper-option.patch b/package/gobject-introspection/0004-giscanner-add-use-binary-wrapper-option.patch
new file mode 100644
index 0000000000..cffc2d954d
--- /dev/null
+++ b/package/gobject-introspection/0004-giscanner-add-use-binary-wrapper-option.patch
@@ -0,0 +1,52 @@
+From 704b888d0abfb01067352c40156f49f655691c7c Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Mon, 19 Oct 2015 18:26:40 +0300
+Subject: [PATCH] giscanner: add --use-binary-wrapper option
+
+With this option, giscanner will use a wrapper executable to run
+binaries it's producing, instead of running them directly. This
+is useful when binaries are cross-compiled and cannot be run directly,
+but they can be run using for example QEMU emulation.
+
+Upstream-Status: Pending [review on oe-core list]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ giscanner/scannermain.py | 14 ++++++++++++++
+ 1 file changed, 14 insertions(+)
+
+diff --git a/giscanner/scannermain.py b/giscanner/scannermain.py
+index 633496f..d684cd0 100755
+--- a/giscanner/scannermain.py
++++ b/giscanner/scannermain.py
+@@ -120,6 +120,9 @@ def _get_option_parser():
+ parser.add_option("", "--program",
+ action="store", dest="program", default=None,
+ help="program to execute")
++ parser.add_option("", "--use-binary-wrapper",
++ action="store", dest="wrapper", default=None,
++ help="wrapper to use for running programs (useful when cross-compiling)")
+ parser.add_option("", "--program-arg",
+ action="append", dest="program_args", default=[],
+ help="extra arguments to program")
+@@ -417,6 +420,17 @@ def create_binary(transformer, options, args):
+ gdump_parser.get_error_quark_functions())
+
+ shlibs = resolve_shlibs(options, binary, options.libraries)
++ if options.wrapper:
++ # The wrapper needs the binary itself, not the libtool wrapper script,
++ # so we check if libtool has sneaked the binary into .libs subdirectory
++ # and adjust the path accordingly
++ import os.path
++ dir_name, binary_name = os.path.split(binary.args[0])
++ libtool_binary = os.path.join(dir_name, '.libs', binary_name)
++ if os.path.exists(libtool_binary):
++ binary.args[0] = libtool_binary
++ # Then prepend the wrapper to the command line to execute
++ binary.args = [options.wrapper] + binary.args
+ gdump_parser.set_introspection_binary(binary)
+ gdump_parser.parse()
+ return shlibs
+--
+2.7.0
+
diff --git a/package/gobject-introspection/0005-giscanner-add-a-use-ldd-wrapper-option.patch b/package/gobject-introspection/0005-giscanner-add-a-use-ldd-wrapper-option.patch
new file mode 100644
index 0000000000..386c1c34b0
--- /dev/null
+++ b/package/gobject-introspection/0005-giscanner-add-a-use-ldd-wrapper-option.patch
@@ -0,0 +1,48 @@
+From d4ad57fd4a32c4f0d2f0522a3090ef940746431b Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Fri, 30 Oct 2015 16:28:46 +0200
+Subject: [PATCH] giscanner: add a --use-ldd-wrapper option
+
+This is useful in cross-compile environments where system's ldd
+command does not work on binaries built for a different architecture
+
+Upstream-Status: Pending [review in oe-core]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ giscanner/scannermain.py | 3 +++
+ giscanner/shlibs.py | 4 +++-
+ 2 files changed, 6 insertions(+), 1 deletion(-)
+
+diff --git a/giscanner/scannermain.py b/giscanner/scannermain.py
+index d684cd0..1b3b369 100755
+--- a/giscanner/scannermain.py
++++ b/giscanner/scannermain.py
+@@ -123,6 +123,9 @@ def _get_option_parser():
+ parser.add_option("", "--use-binary-wrapper",
+ action="store", dest="wrapper", default=None,
+ help="wrapper to use for running programs (useful when cross-compiling)")
++ parser.add_option("", "--use-ldd-wrapper",
++ action="store", dest="ldd_wrapper", default=None,
++ help="wrapper to use instead of ldd (useful when cross-compiling)")
+ parser.add_option("", "--program-arg",
+ action="append", dest="program_args", default=[],
+ help="extra arguments to program")
+diff --git a/giscanner/shlibs.py b/giscanner/shlibs.py
+index c93d20c..c5b5942 100644
+--- a/giscanner/shlibs.py
++++ b/giscanner/shlibs.py
+@@ -97,7 +97,9 @@ def _resolve_non_libtool(options, binary, libraries):
+ args.extend(libtool)
+ args.append('--mode=execute')
+ platform_system = platform.system()
+- if platform_system == 'Darwin':
++ if options.ldd_wrapper:
++ args.extend([options.ldd_wrapper, binary.args[0]])
++ elif platform_system == 'Darwin':
+ args.extend(['otool', '-L', binary.args[0]])
+ else:
+ args.extend(['ldd', binary.args[0]])
+--
+2.7.0
+
diff --git a/package/gobject-introspection/0006-giscanner-add-a-lib-dirs-envvar-option.patch b/package/gobject-introspection/0006-giscanner-add-a-lib-dirs-envvar-option.patch
new file mode 100644
index 0000000000..06f5635610
--- /dev/null
+++ b/package/gobject-introspection/0006-giscanner-add-a-lib-dirs-envvar-option.patch
@@ -0,0 +1,73 @@
+From 3a9b3d8179b7eb9d2cc93da31578945bc03a45c3 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Fri, 27 Apr 2018 12:56:15 -0400
+Subject: [PATCH] giscanner: add a --lib-dirs-envvar option
+
+By default LD_LIBRARY_PATH is set to the list of target library paths;
+this breaks down in cross-compilation environment, as we need to run a
+native emulation wrapper rather than the target binary itself. This patch
+allows exporting those paths to a different environment variable
+which can be picked up and used by the wrapper.
+
+Upstream-Status: Pending
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ giscanner/ccompiler.py | 4 ++--
+ giscanner/dumper.py | 3 ++-
+ giscanner/scannermain.py | 3 +++
+ 3 files changed, 7 insertions(+), 3 deletions(-)
+
+diff --git a/giscanner/ccompiler.py b/giscanner/ccompiler.py
+index d10327c..6cf25d5 100644
+--- a/giscanner/ccompiler.py
++++ b/giscanner/ccompiler.py
+@@ -174,7 +174,7 @@ class CCompiler(object):
+
+ self._cflags_no_deprecation_warnings = "-Wno-deprecated-declarations"
+
+- def get_internal_link_flags(self, args, libtool, libraries, extra_libraries, libpaths):
++ def get_internal_link_flags(self, args, libtool, libraries, extra_libraries, libpaths, lib_dirs_envvar):
+ # An "internal" link is where the library to be introspected
+ # is being built in the current directory.
+
+@@ -184,7 +184,7 @@ class CCompiler(object):
+ if os.name == 'nt':
+ runtime_path_envvar = ['LIB', 'PATH']
+ else:
+- runtime_path_envvar = ['LD_LIBRARY_PATH', 'DYLD_FALLBACK_LIBRARY_PATH']
++ runtime_path_envvar = ['LD_LIBRARY_PATH', 'DYLD_FALLBACK_LIBRARY_PATH'] if not lib_dirs_envvar else [lib_dirs_envvar]
+ # Search the current directory first
+ # (This flag is not supported nor needed for Visual C++)
+ args.append('-L.')
+diff --git a/giscanner/dumper.py b/giscanner/dumper.py
+index 3c7220b..0abd565 100644
+--- a/giscanner/dumper.py
++++ b/giscanner/dumper.py
+@@ -244,7 +244,8 @@ class DumpCompiler(object):
+ libtool,
+ self._options.libraries,
+ self._options.extra_libraries,
+- self._options.library_paths)
++ self._options.library_paths,
++ self._options.lib_dirs_envvar)
+ args.extend(pkg_config_libs)
+
+ else:
+diff --git a/giscanner/scannermain.py b/giscanner/scannermain.py
+index d262785..51c9570 100755
+--- a/giscanner/scannermain.py
++++ b/giscanner/scannermain.py
+@@ -126,6 +126,9 @@ def _get_option_parser():
+ parser.add_option("", "--use-ldd-wrapper",
+ action="store", dest="ldd_wrapper", default=None,
+ help="wrapper to use instead of ldd (useful when cross-compiling)")
++ parser.add_option("", "--lib-dirs-envvar",
++ action="store", dest="lib_dirs_envvar", default=None,
++ help="environment variable to write a list of library directories to (for running the transient binary), instead of standard LD_LIBRARY_PATH")
+ parser.add_option("", "--program-arg",
+ action="append", dest="program_args", default=[],
+ help="extra arguments to program")
+--
+2.14.3
+
diff --git a/package/gobject-introspection/0007-Add-rpath-links-to-ccompiler.patch b/package/gobject-introspection/0007-Add-rpath-links-to-ccompiler.patch
new file mode 100644
index 0000000000..08835d3ecc
--- /dev/null
+++ b/package/gobject-introspection/0007-Add-rpath-links-to-ccompiler.patch
@@ -0,0 +1,29 @@
+From 72a427bc50daee8f1ded0e9221e53dbbf2a80f08 Mon Sep 17 00:00:00 2001
+From: Adam Duskett <aduskett@gmail.com>
+Date: Wed, 14 Mar 2018 12:07:10 -0400
+Subject: [PATCH] Add rpath links to ccompiler
+
+This patch allows gobject-introspection to process extra paths passed to the
+compiler via the GIR_EXTRA_LIBS_PATH variable.
+
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ giscanner/ccompiler.py | 2 ++
+ 1 file changed, 2 insertions(+)
+
+diff --git a/giscanner/ccompiler.py b/giscanner/ccompiler.py
+index a8bd5b1..51bb9bc 100644
+--- a/giscanner/ccompiler.py
++++ b/giscanner/ccompiler.py
+@@ -229,6 +229,8 @@ class CCompiler(object):
+
+ for envvar in runtime_path_envvar:
+ if envvar in os.environ:
++ for envvar_path in os.environ[envvar].split(':'):
++ args.append("-Wl,-rpath-link," + envvar_path)
+ os.environ[envvar] = \
+ os.pathsep.join(runtime_paths + [os.environ[envvar]])
+ else:
+--
+2.14.3
+
diff --git a/package/gobject-introspection/0008-ignore-error-return-codes-from-ldd-wrapper.patch b/package/gobject-introspection/0008-ignore-error-return-codes-from-ldd-wrapper.patch
new file mode 100644
index 0000000000..568758d332
--- /dev/null
+++ b/package/gobject-introspection/0008-ignore-error-return-codes-from-ldd-wrapper.patch
@@ -0,0 +1,28 @@
+From f742da8b3913f4818d3f419117076afe62f4dbf4 Mon Sep 17 00:00:00 2001
+From: Alexander Kanavin <alex.kanavin@gmail.com>
+Date: Wed, 5 Sep 2018 16:46:52 +0200
+Subject: [PATCH] giscanner: ignore error return codes from ldd-wrapper
+
+prelink-rtld, which we use instead of ldd returns 127 when it can't find a library.
+It is not an error per se, but it breaks subprocess.check_output().
+
+Upstream-Status: Inappropriate [oe-core specific]
+Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
+Signed-off-by: Adam Duskett <aduskett@gmail.com>
+---
+ giscanner/shlibs.py | 2 +-
+ 1 file changed, 1 insertion(+), 1 deletion(-)
+
+diff --git a/giscanner/shlibs.py b/giscanner/shlibs.py
+index d67df95..80352a6 100644
+--- a/giscanner/shlibs.py
++++ b/giscanner/shlibs.py
+@@ -102,7 +102,7 @@ def _resolve_non_libtool(options, binary, libraries):
+ args.extend(['otool', '-L', binary.args[0]])
+ else:
+ args.extend(['ldd', binary.args[0]])
+- output = subprocess.check_output(args)
++ output = subprocess.run(args, check=False, stdout=subprocess.PIPE).stdout
+ if isinstance(output, bytes):
+ output = output.decode("utf-8", "replace")
+
diff --git a/package/gobject-introspection/Config.in b/package/gobject-introspection/Config.in
new file mode 100644
index 0000000000..b93d5e4c45
--- /dev/null
+++ b/package/gobject-introspection/Config.in
@@ -0,0 +1,26 @@
+config BR2_PACKAGE_GOBJECT_INTROSPECTION
+ bool "gobject-introspection"
+ depends on BR2_USE_MMU # python3, libglib2
+ depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
+ depends on BR2_TOOLCHAIN_USES_GLIBC
+ select BR2_PACKAGE_HOST_PRELINK_CROSS
+ select BR2_PACKAGE_HOST_QEMU
+ select BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE
+ select BR2_PACKAGE_LIBFFI
+ select BR2_PACKAGE_LIBGLIB2
+ select BR2_PACKAGE_PYTHON3 if !BR2_PACKAGE_PYTHON
+ select BR2_PACKAGE_ZLIB
+ help
+ GObject introspection is a middleware layer between C
+ libraries (using GObject) and language bindings. The C library
+ can be scanned at compile time and generate a metadata file,
+ in addition to the actual native C library. Then at runtime,
+ language bindings can read this metadata and automatically
+ provide bindings to call into the C library.
+
+ https://wiki.gnome.org/action/show/Projects/GObjectIntrospection
+
+comment "gobject-introspection needs a glibc toolchain"
+ depends on BR2_USE_MMU
+ depends on BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS
+ depends on !BR2_TOOLCHAIN_USES_GLIBC
diff --git a/package/gobject-introspection/g-ir-compiler.in b/package/gobject-introspection/g-ir-compiler.in
new file mode 100644
index 0000000000..579fd53fa4
--- /dev/null
+++ b/package/gobject-introspection/g-ir-compiler.in
@@ -0,0 +1,2 @@
+#!/bin/sh
+$(dirname $0)/g-ir-scanner-qemuwrapper $(dirname $0)/g-ir-compiler.real "$@"
diff --git a/package/gobject-introspection/g-ir-scanner-lddwrapper.in b/package/gobject-introspection/g-ir-scanner-lddwrapper.in
new file mode 100644
index 0000000000..02f5c2883d
--- /dev/null
+++ b/package/gobject-introspection/g-ir-scanner-lddwrapper.in
@@ -0,0 +1,2 @@
+#!/bin/sh
+${HOST_DIR}/sbin/prelink-rtld --root=$(dirname $0)/../../ "$@"
diff --git a/package/gobject-introspection/g-ir-scanner-qemuwrapper.in b/package/gobject-introspection/g-ir-scanner-qemuwrapper.in
new file mode 100644
index 0000000000..b69222d27a
--- /dev/null
+++ b/package/gobject-introspection/g-ir-scanner-qemuwrapper.in
@@ -0,0 +1,17 @@
+#!/bin/sh
+
+# Pass -r to qemu-user as to trick glibc into not errorings out if the host kernel
+# is older than the target kernel.
+# Use a modules directory which does not exist so we don't load random things
+# which may then get deleted (or their dependencies) and potentially segfault
+GIO_MODULE_DIR=$(dirname $0)/../lib/gio/modules-dummy \
+ at QEMU_USER@ -r @TOOLCHAIN_HEADERS_VERSION@ \
+-L $(dirname $0)/../../ \
+-E LD_LIBRARY_PATH=$GIR_EXTRA_LIBS_PATH:.libs:$(dirname $0)/../lib:$(dirname $0)/../../lib \
+"$@"
+
+if [ $? -ne 0 ]; then
+ echo "If the above error message is about missing .so libraries, then setting up GIR_EXTRA_LIBS_PATH in the .mk file should help."
+ echo '(typically like this: GIR_EXTRA_LIBS_PATH="$(@D)/.libs")'
+ exit 1
+fi
diff --git a/package/gobject-introspection/g-ir-scanner.in b/package/gobject-introspection/g-ir-scanner.in
new file mode 100644
index 0000000000..09530aad56
--- /dev/null
+++ b/package/gobject-introspection/g-ir-scanner.in
@@ -0,0 +1,7 @@
+#!/bin/sh
+export GI_SCANNER_DISABLE_CACHE=1
+$HOST_DIR/bin/g-ir-scanner \
+--lib-dirs-envvar=GIR_EXTRA_LIBS_PATH \
+--use-binary-wrapper=$(dirname $0)/g-ir-scanner-qemuwrapper \
+--use-ldd-wrapper=$(dirname $0)/g-ir-scanner-lddwrapper \
+--add-include-path=$(dirname $0)/../share/gir-1.0 "$@"
diff --git a/package/gobject-introspection/gobject-introspection.hash b/package/gobject-introspection/gobject-introspection.hash
new file mode 100644
index 0000000000..86dcc691ae
--- /dev/null
+++ b/package/gobject-introspection/gobject-introspection.hash
@@ -0,0 +1,4 @@
+#From http://ftp.gnome.org/pub/GNOME/sources/gobject-introspection/1.60/gobject-introspection-1.60.2.sha256sum
+sha256 ffdfe2368fb2e34a547898b01aac0520d52d8627fdeb1c306559bcb503ab5e9c gobject-introspection-1.60.2.tar.xz
+sha256 d245807f90032872d1438d741ed21e2490e1175dc8aa3afa5ddb6c8e529b58e5 COPYING.LGPL
+sha256 32b1062f7da84967e7019d01ab805935caa7ab7321a7ced0e30ebe75e5df1670 COPYING.GPL
diff --git a/package/gobject-introspection/gobject-introspection.mk b/package/gobject-introspection/gobject-introspection.mk
new file mode 100644
index 0000000000..4393347260
--- /dev/null
+++ b/package/gobject-introspection/gobject-introspection.mk
@@ -0,0 +1,103 @@
+################################################################################
+#
+# gobject-introspection
+#
+################################################################################
+
+GOBJECT_INTROSPECTION_VERSION_MAJOR = 1.60
+GOBJECT_INTROSPECTION_VERSION = $(GOBJECT_INTROSPECTION_VERSION_MAJOR).2
+GOBJECT_INTROSPECTION_SITE = http://ftp.gnome.org/pub/GNOME/sources/gobject-introspection/$(GOBJECT_INTROSPECTION_VERSION_MAJOR)
+GOBJECT_INTROSPECTION_SOURCE = gobject-introspection-$(GOBJECT_INTROSPECTION_VERSION).tar.xz
+GOBJECT_INTROSPECTION_INSTALL_STAGING = YES
+GOBJECT_INTROSPECTION_AUTORECONF = YES
+GOBJECT_INTROSPECTION_LICENSE = LGPL-2.0+ or GPL-2.0+
+GOBJECT_INTROSPECTION_LICENSE_FILES = COPYING.LGPL COPYING.GPL
+
+GOBJECT_INTROSPECTION_DEPENDENCIES = \
+ host-autoconf-archive \
+ host-gobject-introspection \
+ host-prelink-cross \
+ python3 \
+ host-qemu \
+ libffi \
+ libglib2 \
+ zlib
+
+HOST_GOBJECT_INTROSPECTION_DEPENDENCIES = \
+ host-bison \
+ host-flex \
+ host-libglib2 \
+ host-python3
+
+# g-ir-scanner will default to /usr/bin/ld for linking if this is not set.
+GOBJECT_INTROSPECTION_NINJA_ENV += \
+ CC="$(TARGET_CC)"
+
+# Use the host gi-scanner to prevent the scanner from generating incorrect
+# elf classes.
+GOBJECT_INTROSPECTION_CONF_OPTS = \
+ -Denable-host-gi=true \
+ -Denable-gi-cross-wrapper="$(STAGING_DIR)/usr/bin/g-ir-scanner-qemuwrapper" \
+ -Denable-gi-ldd-wrapper="$(STAGING_DIR)/usr/bin/g-ir-scanner-lddwrapper" \
+ -Denable-introspection-data=true
+
+ifeq ($(BR2_PACKAGE_CAIRO),y)
+GOBJECT_INTROSPECTION_DEPENDENCIES += cairo
+GOBJECT_INTROSPECTION_CONF_OPTS += -Dcairo=true
+endif
+
+# GI_SCANNER_DISABLE_CACHE=1 prevents g-ir-scanner from writing cache data to $HOME
+HOST_GOBJECT_INTROSPECTION_CONF_ENV = \
+ GI_SCANNER_DISABLE_CACHE=1
+
+# GI_SCANNER_DISABLE_CACHE=1 prevents g-ir-scanner from writing cache data to $HOME
+GOBJECT_INTROSPECTION_CONF_ENV = \
+ GI_SCANNER_DISABLE_CACHE=1
+
+# Make sure g-ir-tool-template uses the host python.
+define GOBJECT_INTROSPECTION_FIX_TOOLTEMPLATE_PYTHON_PATH
+ $(SED) '1s%#!.*%#!$(HOST_DIR)/bin/python%' $(@D)/tools/g-ir-tool-template.in
+endef
+GOBJECT_INTROSPECTION_PRE_CONFIGURE_HOOKS += GOBJECT_INTROSPECTION_FIX_TOOLTEMPLATE_PYTHON_PATH
+HOST_GOBJECT_INTROSPECTION_PRE_CONFIGURE_HOOKS += GOBJECT_INTROSPECTION_FIX_TOOLTEMPLATE_PYTHON_PATH
+
+# These wrappers allow gobject-introspection to build the internal introspection
+# libraries during the build process.
+define GOBJECT_INTROSPECTION_INSTALL_PRE_WRAPPERS
+ $(INSTALL) -D -m 755 $(GOBJECT_INTROSPECTION_PKGDIR)/g-ir-scanner-lddwrapper.in \
+ $(STAGING_DIR)/usr/bin/g-ir-scanner-lddwrapper
+ $(INSTALL) -D -m 755 $(GOBJECT_INTROSPECTION_PKGDIR)/g-ir-scanner-qemuwrapper.in \
+ $(STAGING_DIR)/usr/bin/g-ir-scanner-qemuwrapper
+ $(SED) "s%@QEMU_USER@%$(QEMU_USER)%g" \
+ $(STAGING_DIR)/usr/bin/g-ir-scanner-qemuwrapper
+ $(SED) "s%@TOOLCHAIN_HEADERS_VERSION@%$(BR2_TOOLCHAIN_HEADERS_AT_LEAST)%g" \
+ $(STAGING_DIR)/usr/bin/g-ir-scanner-qemuwrapper
+ # Use a modules directory which does not exist so we don't load random things
+ # which may then get deleted (or their dependencies) and potentially segfault
+ mkdir -p $(STAGING_DIR)/usr/lib/gio/modules-dummy
+endef
+GOBJECT_INTROSPECTION_POST_PATCH_HOOKS += GOBJECT_INTROSPECTION_INSTALL_PRE_WRAPPERS
+
+# Move the real compiler and scanner to .real, and replace them with the wrappers.
+define GOBJECT_INTROSPECTION_INSTALL_WRAPPERS
+ # Move the real binaries to their names.real, then replace them with
+ # the wrappers.
+ $(foreach w,g-ir-compiler g-ir-scanner,
+ mv $(STAGING_DIR)/usr/bin/$(w) $(STAGING_DIR)/usr/bin/$(w).real
+ $(INSTALL) -D -m 755 \
+ $(GOBJECT_INTROSPECTION_PKGDIR)/$(w).in $(STAGING_DIR)/usr/bin/$(w)
+ )
+ $(SED) "s%toolsdir=.*%toolsdir=$(STAGING_DIR)/usr/bin%g" \
+ $(STAGING_DIR)/usr/lib/pkgconfig/gobject-introspection-1.0.pc
+endef
+GOBJECT_INTROSPECTION_POST_INSTALL_STAGING_HOOKS += GOBJECT_INTROSPECTION_INSTALL_WRAPPERS
+
+# Only .typelib files are needed to run.
+define GOBJECT_INTROSPECTION_REMOVE_DEVELOPMENT_FILES
+ find $(TARGET_DIR)/usr/share/ -name '*.gir' -print0 | xargs -0 rm -f
+ find $(TARGET_DIR)/usr/share/ -name '*.rnc' -print0 | xargs -0 rm -f
+endef
+GOBJECT_INTROSPECTION_TARGET_FINALIZE_HOOKS += GOBJECT_INTROSPECTION_REMOVE_DEVELOPMENT_FILES
+
+$(eval $(meson-package))
+$(eval $(host-meson-package))
--
2.21.0
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 2/5] package/prelink-cross: new package
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
@ 2019-08-04 6:07 ` Yann E. MORIN
2019-08-04 8:16 ` Arnout Vandecappelle
1 sibling, 0 replies; 11+ messages in thread
From: Yann E. MORIN @ 2019-08-04 6:07 UTC (permalink / raw)
To: buildroot
Adam, All,
On 2019-08-03 20:14 -0400, aduskett at gmail.com spake thusly:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Prelink-cross emulates a runtime linker for a given sysroot. This is
> necessary to allow gobject-introspection to build its typelib files
> during cross-compiling.
>
> We're using a sha1 on the cross_prelink branch, as we need the
> RTLD-enabled variant of prelink-cross.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v11 -> v12:
> - Change version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2 as the commit
> id b10e14218646d8b74773b82b0f8b395bce698fa2 no longer exists.
I was very discincerted by this comment: that a commit from upstream
disapeeared was not very conforting: what would guarantee that the new
commit we now choose will not disappear in the future?
So this had me check the upstream epository, and there is good news: 6
weeks ago, they did merge the cross_prelink branch into master. Wee! :-)
So, you may want to update this to use the HEAD of the master brnach,
which is currently d89fb6060e57f0aaa329de9ad81abe76c180ac66.
Regards,
Yann E. MORIN.
> Changes v10 -> v11:
> - adopted by Yann
> - switch to a https git server
> - drop the Config.in.host entry
> - fix typo in commit log
>
> Changes v9 -> v10:
> - None
>
> Changes v8 -> v9:
> - Add the package to the DEVELOPERS file under my name.
> - Bump version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2
> - Add host-elfutils as a dependency.
>
> Changes v7 -> v8:
> - None
>
> Changes v1 -> v7:
> - Add patch to series.
>
> DEVELOPERS | 1 +
> package/prelink-cross/prelink-cross.hash | 3 +++
> package/prelink-cross/prelink-cross.mk | 15 +++++++++++++++
> 3 files changed, 19 insertions(+)
> create mode 100644 package/prelink-cross/prelink-cross.hash
> create mode 100644 package/prelink-cross/prelink-cross.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index e9da0c7f50..407f3f1b1d 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -56,6 +56,7 @@ F: package/openjdk/
> F: package/openjdk-bin/
> F: package/php/
> F: package/policycoreutils/
> +F: package/prelink-cross/
> F: package/python3/
> F: package/python-flask-sqlalchemy/
> F: package/python-mutagen/
> diff --git a/package/prelink-cross/prelink-cross.hash b/package/prelink-cross/prelink-cross.hash
> new file mode 100644
> index 0000000000..3ac33ac3d0
> --- /dev/null
> +++ b/package/prelink-cross/prelink-cross.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256 cb3f5d833cd74b7e90e38465c9c948b0f4138c017509cb91e391b0931063429e prelink-cross-a853a5d715d84eec93aa68e8f2df26b7d860f5b2.tar.gz
> +sha256 b8a2f73f743dc1a51aff23f1aacbca4b868564db52496fa3c0caba755bfd1eaf COPYING
> diff --git a/package/prelink-cross/prelink-cross.mk b/package/prelink-cross/prelink-cross.mk
> new file mode 100644
> index 0000000000..d97141bab4
> --- /dev/null
> +++ b/package/prelink-cross/prelink-cross.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# host-prelink-cross
> +#
> +################################################################################
> +
> +HOST_PRELINK_CROSS_VERSION = a853a5d715d84eec93aa68e8f2df26b7d860f5b2
> +HOST_PRELINK_CROSS_SITE = https://git.yoctoproject.org/git/prelink-cross
> +HOST_PRELINK_CROSS_SITE_METHOD = git
> +HOST_PRELINK_CROSS_LICENSE = GPL-2.0
> +HOST_PRELINK_CROSS_LICENSE_FILES = COPYING
> +HOST_PRELINK_CROSS_AUTORECONF = YES
> +HOST_PRELINK_CROSS_DEPENDENCIES = host-elfutils host-libiberty
> +
> +$(eval $(host-autotools-package))
> --
> 2.21.0
>
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 2/5] package/prelink-cross: new package
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
2019-08-04 6:07 ` Yann E. MORIN
@ 2019-08-04 8:16 ` Arnout Vandecappelle
1 sibling, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2019-08-04 8:16 UTC (permalink / raw)
To: buildroot
Hi Adam,
I don't see any differences between v12 and v13, did I miss something?
I had already started applying (not pushed yet obviously) so it's important to
know. I did make a few modifications, which I'll indicate here...
On 04/08/2019 02:14, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Prelink-cross emulates a runtime linker for a given sysroot. This is
> necessary to allow gobject-introspection to build its typelib files
> during cross-compiling.
>
> We're using a sha1 on the cross_prelink branch, as we need the
> RTLD-enabled variant of prelink-cross.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v11 -> v12:
Ah, now I get it: this is actually v12 -> v13
> - Change version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2 as the commit
> id b10e14218646d8b74773b82b0f8b395bce698fa2 no longer exists.
>
> Changes v10 -> v11:
> - adopted by Yann
> - switch to a https git server
> - drop the Config.in.host entry
> - fix typo in commit log
>
> Changes v9 -> v10:
> - None
>
> Changes v8 -> v9:
> - Add the package to the DEVELOPERS file under my name.
> - Bump version to a853a5d715d84eec93aa68e8f2df26b7d860f5b2
> - Add host-elfutils as a dependency.
>
> Changes v7 -> v8:
> - None
>
> Changes v1 -> v7:
> - Add patch to series.
>
> DEVELOPERS | 1 +
> package/prelink-cross/prelink-cross.hash | 3 +++
> package/prelink-cross/prelink-cross.mk | 15 +++++++++++++++
> 3 files changed, 19 insertions(+)
> create mode 100644 package/prelink-cross/prelink-cross.hash
> create mode 100644 package/prelink-cross/prelink-cross.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index e9da0c7f50..407f3f1b1d 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -56,6 +56,7 @@ F: package/openjdk/
> F: package/openjdk-bin/
> F: package/php/
> F: package/policycoreutils/
> +F: package/prelink-cross/
> F: package/python3/
> F: package/python-flask-sqlalchemy/
> F: package/python-mutagen/
> diff --git a/package/prelink-cross/prelink-cross.hash b/package/prelink-cross/prelink-cross.hash
> new file mode 100644
> index 0000000000..3ac33ac3d0
> --- /dev/null
> +++ b/package/prelink-cross/prelink-cross.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256 cb3f5d833cd74b7e90e38465c9c948b0f4138c017509cb91e391b0931063429e prelink-cross-a853a5d715d84eec93aa68e8f2df26b7d860f5b2.tar.gz
> +sha256 b8a2f73f743dc1a51aff23f1aacbca4b868564db52496fa3c0caba755bfd1eaf COPYING
> diff --git a/package/prelink-cross/prelink-cross.mk b/package/prelink-cross/prelink-cross.mk
> new file mode 100644
> index 0000000000..d97141bab4
> --- /dev/null
> +++ b/package/prelink-cross/prelink-cross.mk
> @@ -0,0 +1,15 @@
> +################################################################################
> +#
> +# host-prelink-cross
> +#
> +################################################################################
> +
> +HOST_PRELINK_CROSS_VERSION = a853a5d715d84eec93aa68e8f2df26b7d860f5b2
> +HOST_PRELINK_CROSS_SITE = https://git.yoctoproject.org/git/prelink-cross
> +HOST_PRELINK_CROSS_SITE_METHOD = git
> +HOST_PRELINK_CROSS_LICENSE = GPL-2.0
> +HOST_PRELINK_CROSS_LICENSE_FILES = COPYING
> +HOST_PRELINK_CROSS_AUTORECONF = YES
I added a comment above:
# Sources from git, no configure script present
Regards,
Arnout
> +HOST_PRELINK_CROSS_DEPENDENCIES = host-elfutils host-libiberty
> +
> +$(eval $(host-autotools-package))
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty
2019-08-04 0:14 ` [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty aduskett at gmail.com
@ 2019-08-04 8:17 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2019-08-04 8:17 UTC (permalink / raw)
To: buildroot
On 04/08/2019 02:14, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> If present, GDB may use a system installed libiberty. As such, we must ensure
> that host-libiberty is installed first.
>
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> v1 -> v11:
> - Add this patch to the series
>
> package/gdb/gdb.mk | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/package/gdb/gdb.mk b/package/gdb/gdb.mk
> index 46d745a897..39d20be1aa 100644
> --- a/package/gdb/gdb.mk
> +++ b/package/gdb/gdb.mk
> @@ -35,7 +35,9 @@ endif
> # For the host variant, we really want to build with XML support,
> # which is needed to read XML descriptions of target architectures. We
> # also need ncurses.
> -HOST_GDB_DEPENDENCIES = host-expat host-ncurses
> +# As for libiberty, gdb may use a system-isntalled one if present, so
^^^installed
Regards,
Arnout
> +# we must ensure ours is installed first.
> +HOST_GDB_DEPENDENCIES = host-expat host-libiberty host-ncurses
>
> # Disable building documentation
> GDB_MAKE_OPTS += MAKEINFO=true
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation
2019-08-04 0:14 ` [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation aduskett at gmail.com
@ 2019-08-04 22:05 ` Arnout Vandecappelle
0 siblings, 0 replies; 11+ messages in thread
From: Arnout Vandecappelle @ 2019-08-04 22:05 UTC (permalink / raw)
To: buildroot
Hi Adam,
On 04/08/2019 02:14, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> From: https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-devtools/meson/meson/
>
> Meson exports a bunch of PKG_CONFIG_ variables which causes a double prefix for
> the staging python include directory.
For obvious reasons, I don't like patching a completely unrelated package.
It is true that this patch is valid in the Buildroot context (though it could
be explained a little better, I'll do that below). However, since I really don't
like patching packages, I've found an alternative solution: we can do the same
environment variable hacks for meson as we do in pkg-python. I'll send a patch
later, to replace this one. Could you give that a spin an submit a v14?
Here's the proposed addition to the commit message (in case we do need to keep
this patch):
--------
In the Buildroot context, using the PKG_CONFIG_LIBDIR from Python's sysconfig is
never appropriate. The sysconfig's LIBPC is set to $(HOST_DIR)/lib/pkgconfig,
because we use host python even when building for the target. Thus, for target
builds, using that value is clearly wrong. For host builds, it is correct, but
for host builds we anyway already pass PKG_CONFIG_LIBDIR in the environment.
Meson uses the following order of evaluation for pkg-config (taken from meson's
commit ab01db177):
1. use `pkg-config` with `PKG_CONFIG_LIBDIR=LIBPC` from python
2. use plain `PKG_CONFIG_{LIBDIR,PATH}` from the environment
3. try to extract the information from SYSCONFIG
It could be argued that 1 and 2 should be swapped (if PKG_CONFIG_* is passed in
the environment, it should override whatever preconfigured defaults are set
somewhere). However, that still wouldn't save us in Buildroot, because we don't
set PKG_CONFIG_LIBDIR in the environment for target builds; we only do that for
host builds.
Therefore, the only solution is patch meson in a non-upstreamable way to ignore
the LIBPC value from Python's sysconfig.
-------
>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v11 -> v12:
> - Remove accidental copy and paste in the commit message.
>
> Changes v1 -> v11:
> - Add this patch to the series
>
> ...-environment-when-calling-pkg-config.patch | 48 +++++++++++++++++++
> 1 file changed, 48 insertions(+)
> create mode 100644 package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
>
> diff --git a/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch b/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
> new file mode 100644
> index 0000000000..a72be80bae
> --- /dev/null
> +++ b/package/meson/0002-python-module-do-not-manipulate-the-environment-when-calling-pkg-config.patch
> @@ -0,0 +1,48 @@
> +From 3cb2c811dc6d4890342afa5b709cd30cf7b8f3ca Mon Sep 17 00:00:00 2001
> +From: Alexander Kanavin <alex.kanavin@gmail.com>
> +Date: Mon, 19 Nov 2018 14:24:26 +0100
> +Subject: [PATCH] python module: do not manipulate the environment when calling pkg-config
> +
> +From: https://github.com/openembedded/openembedded-core/blob/master/meta/recipes-devtools/meson/meson/
> +
> +Meson exports a bunch of PKG_CONFIG_ variables which causes a double prefix to
> +the python include directory.
> +
> +Upstream-Status: Inappropriate [embedded specific]
> +Signed-off-by: Alexander Kanavin <alex.kanavin@gmail.com>
> +Signed-off-by: Adam Duskett <aduskett@gmail.com>
> +
> +---
> + mesonbuild/modules/python.py | 12 ------------
> + 1 file changed, 12 deletions(-)
> +
> +diff --git a/mesonbuild/modules/python.py b/mesonbuild/modules/python.py
> +index 9cfbd6f..3ff687a 100644
> +--- a/mesonbuild/modules/python.py
> ++++ b/mesonbuild/modules/python.py
> +@@ -76,11 +76,6 @@ class PythonDependency(ExternalDependency):
> + old_pkg_libdir = os.environ.get('PKG_CONFIG_LIBDIR')
> + old_pkg_path = os.environ.get('PKG_CONFIG_PATH')
These are not used any more so they can also be removed.
Regards,
Arnout
> +
> +- os.environ.pop('PKG_CONFIG_PATH', None)
> +-
> +- if pkg_libdir:
> +- os.environ['PKG_CONFIG_LIBDIR'] = pkg_libdir
> +-
> + try:
> + self.pkgdep = PkgConfigDependency('python-{}'.format(pkg_version), environment, kwargs)
> + mlog.debug('Found "python-{}" via pkgconfig lookup in LIBPC ({})'.format(pkg_version, pkg_libdir))
> +@@ -89,13 +84,6 @@ class PythonDependency(ExternalDependency):
> + mlog.debug('"python-{}" could not be found in LIBPC ({})'.format(pkg_version, pkg_libdir))
> + mlog.debug(e)
> +
> +- if old_pkg_path is not None:
> +- os.environ['PKG_CONFIG_PATH'] = old_pkg_path
> +-
> +- if old_pkg_libdir is not None:
> +- os.environ['PKG_CONFIG_LIBDIR'] = old_pkg_libdir
> +- else:
> +- os.environ.pop('PKG_CONFIG_LIBDIR', None)
> + else:
> + mlog.debug('"python-{}" could not be found in LIBPC ({}), this is likely due to a relocated python installation'.format(pkg_version, pkg_libdir))
> +
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 1/5] package/libiberty: new package
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
` (3 preceding siblings ...)
2019-08-04 0:14 ` [Buildroot] [PATCH v13 5/5] package/gobject-introspection: new package aduskett at gmail.com
@ 2019-08-04 22:23 ` Arnout Vandecappelle
2019-08-05 11:39 ` ratbert90
4 siblings, 1 reply; 11+ messages in thread
From: Arnout Vandecappelle @ 2019-08-04 22:23 UTC (permalink / raw)
To: buildroot
On 04/08/2019 02:14, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Some packages, like prelink-cross, will want to use libiberty but do
> not bundle their own instance (which is good!).
>
> However, libiberty is made for being bundled in packages: all GNU
> packages that use libiberty (gcc, binutils, gdb et al...) all have
> their own bundled variant. This means that there is no official
> upstream for libiberty; the closest being as part of the
> combined binutils-gdb tree.
>
> So we introduce a new host-only package, that installs just libiberty
> from a binutils released tarball.
>
> Again, as libiberty is usually bundled in packages, it usually only
> install a static version. Furthermore, it does not obey to the usual
> --enable-shared and --disable-static flags; it only ever builds a
> static version.
>
> Furthermore, this library is not built with -fPIC, but some packages
> may pick it to build shared objects. This is the case for host-gdb,
> for example, which accidentally picks that library instead of its
> internal one.
>
> So, rather than fix the various gdb versions and variants we can use,
> we ensure that the libiberty we install is usable in shared objects,
> and we ensure it is always built before host-gdb.
This is all pretty annoying. As discussed on IRC, libiberty really is only
needed for prelink-cross. And in fact, in the latest prelink-cross master, only
a single function from it is used, from the execstack executable. That gives us
the six following possible solutions to the problem:
1. This one, which has the disadvantage that it may have insofar hidden effects
on packages, like it does on gdb.
2. A separate package like this one, but install it in a different place (e.g.
--prefix=$(HOST_DIR)/libiberty), or not install it at all and instead copy the
library to prelink-cross. This avoids any influence on other packages.
3. Define it as an _EXTRA_DOWNLOAD of prelink-cross. However, that would need
either additional patching of the prelink-cross build system, or essentially two
packages (two configures, to builds, ...) in the prelink-cross package.
4. Don't build execstack, either by patching Makefile.am, or by setting
HOST_PRELINK_CROSS_MAKE_OPTS = prelink and manually copying the prelink executable.
5. Copy the required files into prelink-cross sources and add them to
Makefile.am (as an upstreamable patch). It's a pretty big patch though, 8 files
are needed: ansidecl.h filenames.h lbasename.c libiberty.h lrealpath.c
make-relative-prefix.c safe-ctype.c safe-ctype.h
6. Patch execstack to not call make_relative_prefix, or make a simplified
implementation. That may be quite a bit of work.
However, solution 1 is still an option. So
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v1 -> v11:
> - Add this patch to the series
>
> DEVELOPERS | 1 +
> package/libiberty/libiberty.hash | 2 ++
> package/libiberty/libiberty.mk | 27 +++++++++++++++++++++++++++
> 3 files changed, 30 insertions(+)
> create mode 100644 package/libiberty/libiberty.hash
> create mode 100644 package/libiberty/libiberty.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 8a83f748d1..e9da0c7f50 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2362,6 +2362,7 @@ F: package/keyutils/
> F: package/libbsd/
> F: package/libedit/
> F: package/libgsm/
> +F: package/libiberty/
> F: package/libinput/
> F: package/libiscsi/
> F: package/libpri/
> diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
> new file mode 100644
> index 0000000000..270f38dfa7
> --- /dev/null
> +++ b/package/libiberty/libiberty.hash
> @@ -0,0 +1,2 @@
> +# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
> +sha512 d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724afa1e43bd0db45cfc9916b41519b67dfce03232aa4978704492a6994a binutils-2.32.tar.xz
> diff --git a/package/libiberty/libiberty.mk b/package/libiberty/libiberty.mk
> new file mode 100644
> index 0000000000..17976fdd4f
> --- /dev/null
> +++ b/package/libiberty/libiberty.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# libiberty
> +#
> +################################################################################
> +
> +LIBIBERTY_VERSION = 2.32
> +LIBIBERTY_SOURCE = binutils-$(LIBIBERTY_VERSION).tar.xz
> +LIBIBERTY_SITE = $(BR2_GNU_MIRROR)/binutils
> +LIBIBERTY_DL_SUBDIR = binutils
> +LIBIBERTY_SUBDIR = libiberty
> +
> +# We explicitly disable multilib, as we do in binutils.
> +# By default, libiberty installs nothing, so we must force it.
> +HOST_LIBIBERTY_CONF_OPTS = \
> + --disable-multilib \
> + --enable-install-libiberty
> +
> +# Some packages (e.g. host-gdb) will pick this library and build shared
> +# objects with it. But libiberty does not honour the --enable-shared and
> +# --disable-static flags; it only ever builds a static library no matter
> +# what. So we must force -fPIC in build flags.
> +HOST_LIBIBERTY_CONF_ENV = \
> + CFLAGS="$(HOST_CFLAGS) -fPIC" \
> + LDFLAGS="$(HOST_LDFLAGS) -fPIC"
> +
> +$(eval $(host-autotools-package))
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* [Buildroot] [PATCH v13 1/5] package/libiberty: new package
2019-08-04 22:23 ` [Buildroot] [PATCH v13 1/5] package/libiberty: " Arnout Vandecappelle
@ 2019-08-05 11:39 ` ratbert90
0 siblings, 0 replies; 11+ messages in thread
From: ratbert90 @ 2019-08-05 11:39 UTC (permalink / raw)
To: buildroot
Hey Yann and Thomas, if possible I would like your opinion on this as well.
Thanks!
Adam
________________________________
From: Arnout Vandecappelle <arnout@mind.be>
Sent: Sunday, August 4, 2019 18:23
To: aduskett at gmail.com; buildroot at buildroot.org
Cc: Yann E. MORIN
Subject: Re: [Buildroot] [PATCH v13 1/5] package/libiberty: new package
On 04/08/2019 02:14, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
>
> Some packages, like prelink-cross, will want to use libiberty but do
> not bundle their own instance (which is good!).
>
> However, libiberty is made for being bundled in packages: all GNU
> packages that use libiberty (gcc, binutils, gdb et al...) all have
> their own bundled variant. This means that there is no official
> upstream for libiberty; the closest being as part of the
> combined binutils-gdb tree.
>
> So we introduce a new host-only package, that installs just libiberty
> from a binutils released tarball.
>
> Again, as libiberty is usually bundled in packages, it usually only
> install a static version. Furthermore, it does not obey to the usual
> --enable-shared and --disable-static flags; it only ever builds a
> static version.
>
> Furthermore, this library is not built with -fPIC, but some packages
> may pick it to build shared objects. This is the case for host-gdb,
> for example, which accidentally picks that library instead of its
> internal one.
>
> So, rather than fix the various gdb versions and variants we can use,
> we ensure that the libiberty we install is usable in shared objects,
> and we ensure it is always built before host-gdb.
This is all pretty annoying. As discussed on IRC, libiberty really is only
needed for prelink-cross. And in fact, in the latest prelink-cross master, only
a single function from it is used, from the execstack executable. That gives us
the six following possible solutions to the problem:
1. This one, which has the disadvantage that it may have insofar hidden effects
on packages, like it does on gdb.
2. A separate package like this one, but install it in a different place (e.g.
--prefix=$(HOST_DIR)/libiberty), or not install it at all and instead copy the
library to prelink-cross. This avoids any influence on other packages.
3. Define it as an _EXTRA_DOWNLOAD of prelink-cross. However, that would need
either additional patching of the prelink-cross build system, or essentially two
packages (two configures, to builds, ...) in the prelink-cross package.
4. Don't build execstack, either by patching Makefile.am, or by setting
HOST_PRELINK_CROSS_MAKE_OPTS = prelink and manually copying the prelink executable.
5. Copy the required files into prelink-cross sources and add them to
Makefile.am (as an upstreamable patch). It's a pretty big patch though, 8 files
are needed: ansidecl.h filenames.h lbasename.c libiberty.h lrealpath.c
make-relative-prefix.c safe-ctype.c safe-ctype.h
6. Patch execstack to not call make_relative_prefix, or make a simplified
implementation. That may be quite a bit of work.
However, solution 1 is still an option. So
Acked-by: Arnout Vandecappelle (Essensium/Mind) <arnout@mind.be>
Regards,
Arnout
> Signed-off-by: "Yann E. MORIN" <yann.morin.1998@free.fr>
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>
> ---
> Changes v1 -> v11:
> - Add this patch to the series
>
> DEVELOPERS | 1 +
> package/libiberty/libiberty.hash | 2 ++
> package/libiberty/libiberty.mk | 27 +++++++++++++++++++++++++++
> 3 files changed, 30 insertions(+)
> create mode 100644 package/libiberty/libiberty.hash
> create mode 100644 package/libiberty/libiberty.mk
>
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 8a83f748d1..e9da0c7f50 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2362,6 +2362,7 @@ F: package/keyutils/
> F: package/libbsd/
> F: package/libedit/
> F: package/libgsm/
> +F: package/libiberty/
> F: package/libinput/
> F: package/libiscsi/
> F: package/libpri/
> diff --git a/package/libiberty/libiberty.hash b/package/libiberty/libiberty.hash
> new file mode 100644
> index 0000000000..270f38dfa7
> --- /dev/null
> +++ b/package/libiberty/libiberty.hash
> @@ -0,0 +1,2 @@
> +# From ftp://gcc.gnu.org/pub/binutils/releases/sha512.sum
> +sha512 d326408f12a03d9a61a9de56584c2af12f81c2e50d2d7e835d51565df8314df01575724afa1e43bd0db45cfc9916b41519b67dfce03232aa4978704492a6994a binutils-2.32.tar.xz
> diff --git a/package/libiberty/libiberty.mk b/package/libiberty/libiberty.mk
> new file mode 100644
> index 0000000000..17976fdd4f
> --- /dev/null
> +++ b/package/libiberty/libiberty.mk
> @@ -0,0 +1,27 @@
> +################################################################################
> +#
> +# libiberty
> +#
> +################################################################################
> +
> +LIBIBERTY_VERSION = 2.32
> +LIBIBERTY_SOURCE = binutils-$(LIBIBERTY_VERSION).tar.xz
> +LIBIBERTY_SITE = $(BR2_GNU_MIRROR)/binutils
> +LIBIBERTY_DL_SUBDIR = binutils
> +LIBIBERTY_SUBDIR = libiberty
> +
> +# We explicitly disable multilib, as we do in binutils.
> +# By default, libiberty installs nothing, so we must force it.
> +HOST_LIBIBERTY_CONF_OPTS = \
> + --disable-multilib \
> + --enable-install-libiberty
> +
> +# Some packages (e.g. host-gdb) will pick this library and build shared
> +# objects with it. But libiberty does not honour the --enable-shared and
> +# --disable-static flags; it only ever builds a static library no matter
> +# what. So we must force -fPIC in build flags.
> +HOST_LIBIBERTY_CONF_ENV = \
> + CFLAGS="$(HOST_CFLAGS) -fPIC" \
> + LDFLAGS="$(HOST_LDFLAGS) -fPIC"
> +
> +$(eval $(host-autotools-package))
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190805/8b178b7e/attachment.html>
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-05 11:39 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-04 0:14 [Buildroot] [PATCH v13 1/5] package/libiberty: new package aduskett at gmail.com
2019-08-04 0:14 ` [Buildroot] [PATCH v13 2/5] package/prelink-cross: " aduskett at gmail.com
2019-08-04 6:07 ` Yann E. MORIN
2019-08-04 8:16 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 3/5] package/gdb: depend on libiberty aduskett at gmail.com
2019-08-04 8:17 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 4/5] package/meson: prevent python include path manipulation aduskett at gmail.com
2019-08-04 22:05 ` Arnout Vandecappelle
2019-08-04 0:14 ` [Buildroot] [PATCH v13 5/5] package/gobject-introspection: new package aduskett at gmail.com
2019-08-04 22:23 ` [Buildroot] [PATCH v13 1/5] package/libiberty: " Arnout Vandecappelle
2019-08-05 11:39 ` ratbert90
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox