* [Buildroot] [PATCH] package/evtest: fix build with musl libc
@ 2019-08-18 7:23 Baruch Siach
2019-08-19 13:42 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2019-08-18 7:23 UTC (permalink / raw)
To: buildroot
Add a patch adding missing limits.h header include.
Fixes:
http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
.../0001-Add-missing-limits.h-include.patch | 38 +++++++++++++++++++
1 file changed, 38 insertions(+)
create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
diff --git a/package/evtest/0001-Add-missing-limits.h-include.patch b/package/evtest/0001-Add-missing-limits.h-include.patch
new file mode 100644
index 000000000000..6c7fc90482bb
--- /dev/null
+++ b/package/evtest/0001-Add-missing-limits.h-include.patch
@@ -0,0 +1,38 @@
+From 7d7c5a81b0e2f3321d269b7acc450d1eec7a910b Mon Sep 17 00:00:00 2001
+From: Baruch Siach <baruch@tkos.co.il>
+Date: Sun, 18 Aug 2019 09:57:23 +0300
+Subject: [PATCH] Add missing limits.h include
+MIME-Version: 1.0
+Content-Type: text/plain; charset=UTF-8
+Content-Transfer-Encoding: 8bit
+
+Fixes build with musl libc that does not include limits.h indirectly via
+other headers.
+
+evtest.c: In function ?scan_devices?:
+evtest.c:886:14: error: ?PATH_MAX? undeclared (first use in this function); did you mean INT8_MAX??
+ char fname[PATH_MAX];
+ ^~~~~~~~
+
+Signed-off-by: Baruch Siach <baruch@tkos.co.il>
+---
+Upstream status: sent to input-tools at lists.freedesktop.org (moderated)
+
+ evtest.c | 1 +
+ 1 file changed, 1 insertion(+)
+
+diff --git a/evtest.c b/evtest.c
+index 37d4f8540333..548c203564d3 100644
+--- a/evtest.c
++++ b/evtest.c
+@@ -56,6 +56,7 @@
+ #include <getopt.h>
+ #include <ctype.h>
+ #include <signal.h>
++#include <limits.h>
+ #include <sys/time.h>
+ #include <sys/types.h>
+ #include <unistd.h>
+--
+2.23.0.rc1
+
--
2.23.0.rc1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/evtest: fix build with musl libc
2019-08-18 7:23 [Buildroot] [PATCH] package/evtest: fix build with musl libc Baruch Siach
@ 2019-08-19 13:42 ` Thomas Petazzoni
2019-08-19 13:46 ` Baruch Siach
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-08-19 13:42 UTC (permalink / raw)
To: buildroot
On Sun, 18 Aug 2019 10:23:10 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> Add a patch adding missing limits.h header include.
>
> Fixes:
> http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
> http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
> http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/
>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> .../0001-Add-missing-limits.h-include.patch | 38 +++++++++++++++++++
> 1 file changed, 38 insertions(+)
> create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/evtest: fix build with musl libc
2019-08-19 13:42 ` Thomas Petazzoni
@ 2019-08-19 13:46 ` Baruch Siach
2019-08-19 13:56 ` Thomas Petazzoni
0 siblings, 1 reply; 5+ messages in thread
From: Baruch Siach @ 2019-08-19 13:46 UTC (permalink / raw)
To: buildroot
Hi Thomas,
On Mon, Aug 19, 2019 at 03:42:10PM +0200, Thomas Petazzoni wrote:
> On Sun, 18 Aug 2019 10:23:10 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
>
> > Add a patch adding missing limits.h header include.
> >
> > Fixes:
> > http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
> > http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
> > http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/
> >
> > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > ---
> > .../0001-Add-missing-limits.h-include.patch | 38 +++++++++++++++++++
> > 1 file changed, 38 insertions(+)
> > create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
>
> Applied to master, thanks.
This fixes an issue in next after the last evtest version bump. Sorry for not
mentioning that in subject.
baruch
--
http://baruch.siach.name/blog/ ~. .~ Tk Open Systems
=}------------------------------------------------ooO--U--Ooo------------{=
- baruch at tkos.co.il - tel: +972.2.679.5364, http://www.tkos.co.il -
^ permalink raw reply [flat|nested] 5+ messages in thread* [Buildroot] [PATCH] package/evtest: fix build with musl libc
2019-08-19 13:46 ` Baruch Siach
@ 2019-08-19 13:56 ` Thomas Petazzoni
2019-09-02 15:19 ` Peter Korsgaard
0 siblings, 1 reply; 5+ messages in thread
From: Thomas Petazzoni @ 2019-08-19 13:56 UTC (permalink / raw)
To: buildroot
Hello Baruch,
On Mon, 19 Aug 2019 16:46:15 +0300
Baruch Siach <baruch@tkos.co.il> wrote:
> Hi Thomas,
>
> On Mon, Aug 19, 2019 at 03:42:10PM +0200, Thomas Petazzoni wrote:
> > On Sun, 18 Aug 2019 10:23:10 +0300
> > Baruch Siach <baruch@tkos.co.il> wrote:
> >
> > > Add a patch adding missing limits.h header include.
> > >
> > > Fixes:
> > > http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
> > > http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
> > > http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/
> > >
> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> > > ---
> > > .../0001-Add-missing-limits.h-include.patch | 38 +++++++++++++++++++
> > > 1 file changed, 38 insertions(+)
> > > create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
> >
> > Applied to master, thanks.
>
> This fixes an issue in next after the last evtest version bump. Sorry for not
> mentioning that in subject.
Ah indeed, I didn't realize that, and didn't check the autobuilder
references. The patch applies fine to master though, and will cause no
harm. So I just cherry-picked it in next. I don't think it's worth the
effort reverting on master (unless you see a reason to do so ?).
Best regards,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* [Buildroot] [PATCH] package/evtest: fix build with musl libc
2019-08-19 13:56 ` Thomas Petazzoni
@ 2019-09-02 15:19 ` Peter Korsgaard
0 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2019-09-02 15:19 UTC (permalink / raw)
To: buildroot
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Baruch,
> On Mon, 19 Aug 2019 16:46:15 +0300
> Baruch Siach <baruch@tkos.co.il> wrote:
>> Hi Thomas,
>>
>> On Mon, Aug 19, 2019 at 03:42:10PM +0200, Thomas Petazzoni wrote:
>> > On Sun, 18 Aug 2019 10:23:10 +0300
>> > Baruch Siach <baruch@tkos.co.il> wrote:
>> >
>> > > Add a patch adding missing limits.h header include.
>> > >
>> > > Fixes:
>> > > http://autobuild.buildroot.net/results/c5f1b95741b37f6d949b3407fff901a960c6b781/
>> > > http://autobuild.buildroot.net/results/b09a6b340f0a96081a55764b5dad0c2c31240cef/
>> > > http://autobuild.buildroot.net/results/90c7a092a5492699406d3f46e0039d253146b6b7/
>> > >
>> > > Signed-off-by: Baruch Siach <baruch@tkos.co.il>
>> > > ---
>> > > .../0001-Add-missing-limits.h-include.patch | 38 +++++++++++++++++++
>> > > 1 file changed, 38 insertions(+)
>> > > create mode 100644 package/evtest/0001-Add-missing-limits.h-include.patch
>> >
>> > Applied to master, thanks.
>>
>> This fixes an issue in next after the last evtest version bump. Sorry for not
>> mentioning that in subject.
> Ah indeed, I didn't realize that, and didn't check the autobuilder
> references. The patch applies fine to master though, and will cause no
> harm. So I just cherry-picked it in next. I don't think it's worth the
> effort reverting on master (unless you see a reason to do so ?).
I missed that as well, so I've applied to 2019.02.x and 2019.05.x.
Oh well, shouldn't cause any harm.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-09-02 15:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-08-18 7:23 [Buildroot] [PATCH] package/evtest: fix build with musl libc Baruch Siach
2019-08-19 13:42 ` Thomas Petazzoni
2019-08-19 13:46 ` Baruch Siach
2019-08-19 13:56 ` Thomas Petazzoni
2019-09-02 15:19 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox