[Buildroot] [PATCH 1/1] package/lrzip: new package

[Buildroot] [PATCH 1/1] package/lrzip: new package

[sam at gpsm.co.uk]

From: Sam Lancia <sam@gpsm.co.uk>

lrzip is a compression utility that excels at compressing
large files (usually > 10-50 MB)

Signed-off-by: Sam Lancia <sam@gpsm.co.uk>
---
 DEVELOPERS                              |  3 +++
 package/Config.in                       |  1 +
 package/lrzip/0001-missing-stdarg.patch | 15 +++++++++++++++
 package/lrzip/Config.in                 | 23 +++++++++++++++++++++++
 package/lrzip/lrzip.hash                |  3 +++
 package/lrzip/lrzip.mk                  | 14 ++++++++++++++
 6 files changed, 59 insertions(+)
 create mode 100644 package/lrzip/0001-missing-stdarg.patch
 create mode 100644 package/lrzip/Config.in
 create mode 100644 package/lrzip/lrzip.hash
 create mode 100644 package/lrzip/lrzip.mk

diff --git a/DEVELOPERS b/DEVELOPERS
index 0905237790..69d26d8de4 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -2027,6 +2027,9 @@ N:	Sam Bobroff <sam.bobroff@au1.ibm.com>
 F:	arch/Config.in.powerpc
 F:	package/librtas/
 
+N:	Sam Lancia <sam@gpsm.co.uk>
+F:	package/lrzip/
+
 N:	Samuel Martin <s.martin49@gmail.com>
 F:	package/armadillo/
 F:	package/canfestival/
diff --git a/package/Config.in b/package/Config.in
index 9336261c5d..c313fd55a5 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -67,6 +67,7 @@ menu "Compressors and decompressors"
 	source "package/brotli/Config.in"
 	source "package/bzip2/Config.in"
 	source "package/gzip/Config.in"
+	source "package/lrzip/Config.in"
 	source "package/lz4/Config.in"
 	source "package/lzip/Config.in"
 	source "package/lzop/Config.in"
diff --git a/package/lrzip/0001-missing-stdarg.patch b/package/lrzip/0001-missing-stdarg.patch
new file mode 100644
index 0000000000..7a19bc2834
--- /dev/null
+++ b/package/lrzip/0001-missing-stdarg.patch
@@ -0,0 +1,15 @@
+Lrzip.h: add missing header for va_list on some platforms
+
+Signed-off-by: Sam Lancia <sam@gpsm.co.uk>
+
+--- a/Lrzip.h
++++ b/Lrzip.h
+@@ -20,6 +20,7 @@
+ #ifndef LIBLRZIP_H
+ #define LIBLRZIP_H
+ 
++#include <stdarg.h>
+ #include <stdbool.h>
+ #include <stdio.h>
+ #ifdef _WIN32
+
diff --git a/package/lrzip/Config.in b/package/lrzip/Config.in
new file mode 100644
index 0000000000..e18d65550f
--- /dev/null
+++ b/package/lrzip/Config.in
@@ -0,0 +1,23 @@
+config BR2_PACKAGE_LRZIP
+	bool "lrzip"
+	depends on BR2_USE_MMU # fork()
+	depends on BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
+	select BR2_PACKAGE_ZLIB
+	select BR2_PACKAGE_LZO
+	select BR2_PACKAGE_BZIP2
+	help
+	  A compression utility that excels at compressing large files
+	  (usually > 10-50 MB). Larger files and/or more free RAM means
+	  that the utility will be able to more effectively compress
+	  your files (ie: faster / smaller size), especially if the
+	  filesize(s) exceed 100 MB. You can either choose to optimise
+	  for speed (fast compression / decompression) or size,
+	  but not both.
+
+	  https://github.com/ckolivas/lrzip
+
+comment "lrzip needs a toolchain w/ wchar"
+	depends on BR2_USE_MMU
+	depends on !BR2_USE_WCHAR
+	depends on BR2_TOOLCHAIN_HAS_THREADS
diff --git a/package/lrzip/lrzip.hash b/package/lrzip/lrzip.hash
new file mode 100644
index 0000000000..bdf63f0ed8
--- /dev/null
+++ b/package/lrzip/lrzip.hash
@@ -0,0 +1,3 @@
+# Locally computed:
+sha256 10315c20d5a47590e7220c210735ba169677824d5672509266682eccec84d952  lrzip-0.631.tar.gz
+sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  COPYING
diff --git a/package/lrzip/lrzip.mk b/package/lrzip/lrzip.mk
new file mode 100644
index 0000000000..8f4cba5303
--- /dev/null
+++ b/package/lrzip/lrzip.mk
@@ -0,0 +1,14 @@
+################################################################################
+#
+# lrzip
+#
+################################################################################
+
+LRZIP_VERSION = 0.631
+LRZIP_SITE = $(call github,ckolivas,lrzip,v$(LRZIP_VERSION))
+LRZIP_AUTORECONF = YES
+LRZIP_LICENSE = GPL-2.0
+LRZIP_LICENSE_FILES = COPYING
+LRZIP_DEPENDENCIES = zlib lzo bzip2
+
+$(eval $(autotools-package))
-- 
2.17.1

[Buildroot] [PATCH 1/1] package/lrzip: new package

[Thomas Petazzoni]

Hello,

Thanks for this new version. When sending a new version for a patch, it
is customary to use:

 [PATCH v2]

as the patch prefix, which you can do using "git format-patch -v2".

And also, to include a changelog of the changes between the v1 and v2,
below the "---", i.e...

On Sat,  7 Sep 2019 21:11:15 +0100
sam at gpsm.co.uk wrote:

> From: Sam Lancia <sam@gpsm.co.uk>
> 
> lrzip is a compression utility that excels at compressing
> large files (usually > 10-50 MB)
> 
> Signed-off-by: Sam Lancia <sam@gpsm.co.uk>
> ---

... here.


> diff --git a/package/lrzip/0001-missing-stdarg.patch b/package/lrzip/0001-missing-stdarg.patch
> new file mode 100644
> index 0000000000..7a19bc2834
> --- /dev/null
> +++ b/package/lrzip/0001-missing-stdarg.patch
> @@ -0,0 +1,15 @@
> +Lrzip.h: add missing header for va_list on some platforms
> +
> +Signed-off-by: Sam Lancia <sam@gpsm.co.uk>

We would like patches for projects that are hosted on Git to be
generated using git format-patch. So, grab the Git repo of the upstream
project, and make a proper commit. This way, you can also easily send a
pull request to the upstream lrzip project.

However, was this sufficient to fix all build issues ? Indeed stdarg.h
was missing, but there were also some bswap related problems.

> +comment "lrzip needs a toolchain w/ wchar"
> +	depends on BR2_USE_MMU
> +	depends on !BR2_USE_WCHAR
> +	depends on BR2_TOOLCHAIN_HAS_THREADS

No, that's not the proper way. It should be:

comment "lrzip needs a toolchain w/ wchar, threads"
	depends on BR2_USE_MMU
	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/lrzip: new package

[Sam Lancia]

Thanks for the help Thomas.

Have updated the patch. No other changes seem to be required, the bswap
issues appear to be warnings. utils/test-pkg passes

On Sat, 7 Sep 2019 at 21:35, Thomas Petazzoni <thomas.petazzoni@bootlin.com>
wrote:

> Hello,
>
> Thanks for this new version. When sending a new version for a patch, it
> is customary to use:
>
>  [PATCH v2]
>
> as the patch prefix, which you can do using "git format-patch -v2".
>
> And also, to include a changelog of the changes between the v1 and v2,
> below the "---", i.e...
>
> On Sat,  7 Sep 2019 21:11:15 +0100
> sam at gpsm.co.uk wrote:
>
> > From: Sam Lancia <sam@gpsm.co.uk>
> >
> > lrzip is a compression utility that excels at compressing
> > large files (usually > 10-50 MB)
> >
> > Signed-off-by: Sam Lancia <sam@gpsm.co.uk>
> > ---
>
> ... here.
>
>
> > diff --git a/package/lrzip/0001-missing-stdarg.patch
> b/package/lrzip/0001-missing-stdarg.patch
> > new file mode 100644
> > index 0000000000..7a19bc2834
> > --- /dev/null
> > +++ b/package/lrzip/0001-missing-stdarg.patch
> > @@ -0,0 +1,15 @@
> > +Lrzip.h: add missing header for va_list on some platforms
> > +
> > +Signed-off-by: Sam Lancia <sam@gpsm.co.uk>
>
> We would like patches for projects that are hosted on Git to be
> generated using git format-patch. So, grab the Git repo of the upstream
> project, and make a proper commit. This way, you can also easily send a
> pull request to the upstream lrzip project.
>
> However, was this sufficient to fix all build issues ? Indeed stdarg.h
> was missing, but there were also some bswap related problems.
>
> > +comment "lrzip needs a toolchain w/ wchar"
> > +     depends on BR2_USE_MMU
> > +     depends on !BR2_USE_WCHAR
> > +     depends on BR2_TOOLCHAIN_HAS_THREADS
>
> No, that's not the proper way. It should be:
>
> comment "lrzip needs a toolchain w/ wchar, threads"
>         depends on BR2_USE_MMU
>         depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>
> Thanks!
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190908/f20c11c5/attachment-0001.html>