Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version
@ 2019-09-11 17:17 Fabrice Fontaine
  2019-09-12 11:53 ` Thomas Petazzoni
  2019-09-12 17:36 ` Thomas Huth
  0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-09-11 17:17 UTC (permalink / raw)
  To: buildroot

In order for the ascii-invaders version to match what is given by
release-monitoring.org, the 'v' prefix should be encoded in
ASCII_INVADERS_SITE and not ASCII_INVADERS_VERSION.

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/ascii-invaders/ascii-invaders.hash | 2 +-
 package/ascii-invaders/ascii-invaders.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/ascii-invaders/ascii-invaders.hash b/package/ascii-invaders/ascii-invaders.hash
index b4805e7b1d..e8d482b2aa 100644
--- a/package/ascii-invaders/ascii-invaders.hash
+++ b/package/ascii-invaders/ascii-invaders.hash
@@ -1,5 +1,5 @@
 # Locally calculated
-sha512	326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7	v1.0.1.tar.gz
+sha512	326708ffc2c277e04575920c58f6a267e0bf46f8d2a3dbca9b5c317fb01006d4f673ab35f92f292549cc52dbee4400a84c85478eb81b9bd7703689a705547bc7	1.0.1.tar.gz
 
 # Hash for license file
 sha512	1e455684996d7733b2f1ccd4606d034694d16ceff6ede6125d7f1537d20dabe05976cca4cef5cbf6c31352cbd62a515fd8e34a2ffb54dae1181c1116b24c6cf7	LICENSE
diff --git a/package/ascii-invaders/ascii-invaders.mk b/package/ascii-invaders/ascii-invaders.mk
index c91e0eeaa8..fc1a019291 100644
--- a/package/ascii-invaders/ascii-invaders.mk
+++ b/package/ascii-invaders/ascii-invaders.mk
@@ -4,9 +4,9 @@
 #
 ################################################################################
 
-ASCII_INVADERS_VERSION = v1.0.1
+ASCII_INVADERS_VERSION = 1.0.1
 ASCII_INVADERS_SOURCE = $(ASCII_INVADERS_VERSION).tar.gz
-ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,$(ASCII_INVADERS_VERSION))
+ASCII_INVADERS_SITE = $(call github,macdice,ascii-invaders,v$(ASCII_INVADERS_VERSION))
 ASCII_INVADERS_DEPENDENCIES = ncurses
 ASCII_INVADERS_LICENSE = GPL-2.0+
 ASCII_INVADERS_LICENSE_FILES = LICENSE
-- 
2.23.0.rc1

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version
  2019-09-11 17:17 [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version Fabrice Fontaine
@ 2019-09-12 11:53 ` Thomas Petazzoni
  2019-09-12 17:36 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-09-12 11:53 UTC (permalink / raw)
  To: buildroot

Hello Fabrice,

On Wed, 11 Sep 2019 19:17:29 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> In order for the ascii-invaders version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> ASCII_INVADERS_SITE and not ASCII_INVADERS_VERSION.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ascii-invaders/ascii-invaders.hash | 2 +-
>  package/ascii-invaders/ascii-invaders.mk   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Applied to master, thanks. I also did a followup commit to drop the
_SOURCE variable, which was not needed, and caused the tarball to be
named just after the version, instead of using the typical
name-version.tar.gz naming.

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 3+ messages in thread

* [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version
  2019-09-11 17:17 [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version Fabrice Fontaine
  2019-09-12 11:53 ` Thomas Petazzoni
@ 2019-09-12 17:36 ` Thomas Huth
  1 sibling, 0 replies; 3+ messages in thread
From: Thomas Huth @ 2019-09-12 17:36 UTC (permalink / raw)
  To: buildroot

Am Wed, 11 Sep 2019 19:17:29 +0200
schrieb Fabrice Fontaine <fontaine.fabrice@gmail.com>:

> In order for the ascii-invaders version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> ASCII_INVADERS_SITE and not ASCII_INVADERS_VERSION.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/ascii-invaders/ascii-invaders.hash | 2 +-
>  package/ascii-invaders/ascii-invaders.mk   | 4 ++--
>  2 files changed, 3 insertions(+), 3 deletions(-)

Acked-by: Thomas Huth <huth@tuxfamily.org>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-09-12 17:36 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-11 17:17 [Buildroot] [PATCH 1/1] package/ascii-invaders: fixup the 'v' prefix in the version Fabrice Fontaine
2019-09-12 11:53 ` Thomas Petazzoni
2019-09-12 17:36 ` Thomas Huth

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox