* [Buildroot] [PATCH 1/1] package/openvmtools: source default file
@ 2019-09-17 9:31 Simon Rowe
2019-09-17 19:40 ` Thomas Petazzoni
2019-09-26 8:50 ` Peter Korsgaard
0 siblings, 2 replies; 4+ messages in thread
From: Simon Rowe @ 2019-09-17 9:31 UTC (permalink / raw)
To: buildroot
In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
(if it present)
Signed-off-by: Simon Rowe <simon.rowe@citrix.com>
---
package/openvmtools/S10vmtoolsd | 2 ++
1 file changed, 2 insertions(+)
diff --git a/package/openvmtools/S10vmtoolsd b/package/openvmtools/S10vmtoolsd
index 6afb9ca..5fdb568 100644
--- a/package/openvmtools/S10vmtoolsd
+++ b/package/openvmtools/S10vmtoolsd
@@ -7,6 +7,8 @@ EXEC="/usr/bin/vmtoolsd"
ARGS="-b"
PID="/var/run/vmtoolsd.pid"
+[ -r /etc/default/vmtoolsd ] && . /etc/default/vmtoolsd
+
case "$1" in
start)
printf "Starting vmtoolsd: "
--
1.8.3.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvmtools: source default file
2019-09-17 9:31 [Buildroot] [PATCH 1/1] package/openvmtools: source default file Simon Rowe
@ 2019-09-17 19:40 ` Thomas Petazzoni
2019-09-18 8:11 ` Simon Rowe
2019-09-26 8:50 ` Peter Korsgaard
1 sibling, 1 reply; 4+ messages in thread
From: Thomas Petazzoni @ 2019-09-17 19:40 UTC (permalink / raw)
To: buildroot
Hello Simon,
On Tue, 17 Sep 2019 10:31:41 +0100
Simon Rowe <simon.rowe@citrix.com> wrote:
> In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
> (if it present)
>
> Signed-off-by: Simon Rowe <simon.rowe@citrix.com>
> ---
> package/openvmtools/S10vmtoolsd | 2 ++
> 1 file changed, 2 insertions(+)
Applied to master, thanks. However, it would be nice to convert this
init script to our new "template", which can be seen in
package/busybox/S01syslogd.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvmtools: source default file
2019-09-17 19:40 ` Thomas Petazzoni
@ 2019-09-18 8:11 ` Simon Rowe
0 siblings, 0 replies; 4+ messages in thread
From: Simon Rowe @ 2019-09-18 8:11 UTC (permalink / raw)
To: buildroot
On 17/09/2019 20:40, Thomas Petazzoni wrote:
> Applied to master, thanks. However, it would be nice to convert this
> init script to our new "template", which can be seen in
> package/busybox/S01syslogd.
Sure, I create a patch for that,
Simon
^ permalink raw reply [flat|nested] 4+ messages in thread
* [Buildroot] [PATCH 1/1] package/openvmtools: source default file
2019-09-17 9:31 [Buildroot] [PATCH 1/1] package/openvmtools: source default file Simon Rowe
2019-09-17 19:40 ` Thomas Petazzoni
@ 2019-09-26 8:50 ` Peter Korsgaard
1 sibling, 0 replies; 4+ messages in thread
From: Peter Korsgaard @ 2019-09-26 8:50 UTC (permalink / raw)
To: buildroot
>>>>> "Simon" == Simon Rowe <simon.rowe@citrix.com> writes:
> In the SYSV init script allow /etc/default/vmtoolsd to override $ARGS
> (if it present)
> Signed-off-by: Simon Rowe <simon.rowe@citrix.com>
Committed to 2019.02.x, 2019.05.x and 2019.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-09-26 8:50 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-17 9:31 [Buildroot] [PATCH 1/1] package/openvmtools: source default file Simon Rowe
2019-09-17 19:40 ` Thomas Petazzoni
2019-09-18 8:11 ` Simon Rowe
2019-09-26 8:50 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox