From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/xdebug: new package
Date: Mon, 23 Sep 2019 15:59:32 +0200 [thread overview]
Message-ID: <20190923155932.1790cb65@windsurf> (raw)
In-Reply-To: <0c8218be-8091-e801-cee8-c256a6a67205@mind.be>
On Mon, 23 Sep 2019 15:27:21 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > diff --git a/package/Config.in b/package/Config.in
> > index 2fc11065f6..95115ec469 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> > source "package/valgrind/Config.in"
> > source "package/vmtouch/Config.in"
> > source "package/whetstone/Config.in"
> > + source "package/xdebug/Config.in"
>
> Hm. IIUC, this is really a PHP extension, *not* a debugger that happens to use
> PHP internally. Therefore, I would think that it fits more in the "External php
> extensions" menu.
Agreed, if it's a PHP extension, it should go in the PHP extensions
menu, and be called "php-xdebug".
> > index 0000000000..c0abb71896
> > --- /dev/null
> > +++ b/package/xdebug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_XDEBUG
> > + bool "xdebug"
> > + select BR2_PACKAGE_PHP
>
> If you select a package, you have to copy its dependencies.
>
> However, for a PHP package, it's more appropriate to depend on it I think. Note
> that if you move it to the external php extensions menu that dependency will be
> implicit.
If it goes in the PHP extensions menu, then it will automatically be
inside a "if BR2_PACKAGE_PHP...endif" block.
> Note also that normally, PHP extensions can only be built for !STATIC. Did you
> run test-pkg?
... and in a if !BR2_STATIC_LIBS..endif block.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-09-23 13:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 10:17 [Buildroot] [PATCH 1/1] package/xdebug: new package Nicolas Carrier
2019-09-23 13:27 ` Arnout Vandecappelle
2019-09-23 13:59 ` Thomas Petazzoni [this message]
2019-09-23 15:03 ` Nicolas Carrier
2019-09-23 15:01 ` Nicolas Carrier
2019-09-23 15:05 ` Arnout Vandecappelle
2019-09-23 15:24 ` Nicolas Carrier
2019-09-23 15:03 ` Nicolas Carrier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190923155932.1790cb65@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox