* [Buildroot] [PATCH 1/1] package/xdebug: new package
@ 2019-09-23 10:17 Nicolas Carrier
2019-09-23 13:27 ` Arnout Vandecappelle
0 siblings, 1 reply; 8+ messages in thread
From: Nicolas Carrier @ 2019-09-23 10:17 UTC (permalink / raw)
To: buildroot
Extension for PHP to assist with debugging and development.
Signed-off-by: Nicolas Carrier <nicolas.carrier@orolia.com>
---
package/Config.in | 1 +
package/xdebug/Config.in | 7 +++++++
package/xdebug/xdebug.hash | 3 +++
package/xdebug/xdebug.mk | 25 +++++++++++++++++++++++++
4 files changed, 36 insertions(+)
create mode 100644 package/xdebug/Config.in
create mode 100644 package/xdebug/xdebug.hash
create mode 100644 package/xdebug/xdebug.mk
diff --git a/package/Config.in b/package/Config.in
index 2fc11065f6..95115ec469 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
source "package/valgrind/Config.in"
source "package/vmtouch/Config.in"
source "package/whetstone/Config.in"
+ source "package/xdebug/Config.in"
endmenu
menu "Development tools"
diff --git a/package/xdebug/Config.in b/package/xdebug/Config.in
new file mode 100644
index 0000000000..c0abb71896
--- /dev/null
+++ b/package/xdebug/Config.in
@@ -0,0 +1,7 @@
+config BR2_PACKAGE_XDEBUG
+ bool "xdebug"
+ select BR2_PACKAGE_PHP
+
+ help
+ Extension for PHP to assist with debugging and development.
+ Web page: http://xdebug.org
diff --git a/package/xdebug/xdebug.hash b/package/xdebug/xdebug.hash
new file mode 100644
index 0000000000..a477a41d80
--- /dev/null
+++ b/package/xdebug/xdebug.hash
@@ -0,0 +1,3 @@
+# Locally computed
+sha256 86df1c16f31a11ed242adbaba7f13290af23ac57e1095a02faceb41ea833f729 xdebug-2.7.0.tar.gz
+sha256 ef479ee1a3da3f933e0d046ca8cd0c14601f29b2c0c41cc60c9388546a4e0272 LICENSE
diff --git a/package/xdebug/xdebug.mk b/package/xdebug/xdebug.mk
new file mode 100644
index 0000000000..8c156c4297
--- /dev/null
+++ b/package/xdebug/xdebug.mk
@@ -0,0 +1,25 @@
+################################################################################
+#
+# xdebug
+#
+################################################################################
+
+XDEBUG_VERSION = 2.7.0
+XDEBUG_SITE = $(call github,xdebug,xdebug,$(XDEBUG_VERSION))
+XDEBUG_INSTALL_STAGING = YES
+XDEBUG_LICENSE = xdebug-license
+XDEBUG_LICENSE_FILES = LICENSE
+XDEBUG_DEPENDENCIES = php host-autoconf
+XDEBUG_CONF_OPTS = --enable-xdebug --with-php-config=$(STAGING_DIR)/usr/bin/php-config\
+ --with-xdebug=$(STAGING_DIR)/usr
+
+define XDEBUG_PHPIZE
+ (cd $(@D); \
+ PHP_AUTOCONF=$(HOST_DIR)/usr/bin/autoconf \
+ PHP_AUTOHEADER=$(HOST_DIR)/usr/bin/autoheader \
+ $(STAGING_DIR)/usr/bin/phpize)
+endef
+
+XDEBUG_PRE_CONFIGURE_HOOKS += XDEBUG_PHPIZE
+
+$(eval $(autotools-package))
--
2.20.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 10:17 [Buildroot] [PATCH 1/1] package/xdebug: new package Nicolas Carrier
@ 2019-09-23 13:27 ` Arnout Vandecappelle
2019-09-23 13:59 ` Thomas Petazzoni
` (2 more replies)
0 siblings, 3 replies; 8+ messages in thread
From: Arnout Vandecappelle @ 2019-09-23 13:27 UTC (permalink / raw)
To: buildroot
Hi Nicolas,
On 23/09/2019 12:17, Nicolas Carrier wrote:
> Extension for PHP to assist with debugging and development.
>
> Signed-off-by: Nicolas Carrier <nicolas.carrier@orolia.com>
> ---
> package/Config.in | 1 +
> package/xdebug/Config.in | 7 +++++++
> package/xdebug/xdebug.hash | 3 +++
> package/xdebug/xdebug.mk | 25 +++++++++++++++++++++++++
> 4 files changed, 36 insertions(+)
> create mode 100644 package/xdebug/Config.in
> create mode 100644 package/xdebug/xdebug.hash
> create mode 100644 package/xdebug/xdebug.mk
>
> diff --git a/package/Config.in b/package/Config.in
> index 2fc11065f6..95115ec469 100644
> --- a/package/Config.in
> +++ b/package/Config.in
> @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> source "package/valgrind/Config.in"
> source "package/vmtouch/Config.in"
> source "package/whetstone/Config.in"
> + source "package/xdebug/Config.in"
Hm. IIUC, this is really a PHP extension, *not* a debugger that happens to use
PHP internally. Therefore, I would think that it fits more in the "External php
extensions" menu.
But others may disagree...
> endmenu
>
> menu "Development tools"
> diff --git a/package/xdebug/Config.in b/package/xdebug/Config.in
> new file mode 100644
> index 0000000000..c0abb71896
> --- /dev/null
> +++ b/package/xdebug/Config.in
> @@ -0,0 +1,7 @@
> +config BR2_PACKAGE_XDEBUG
> + bool "xdebug"
> + select BR2_PACKAGE_PHP
If you select a package, you have to copy its dependencies.
However, for a PHP package, it's more appropriate to depend on it I think. Note
that if you move it to the external php extensions menu that dependency will be
implicit.
Note also that normally, PHP extensions can only be built for !STATIC. Did you
run test-pkg?
> +
As check-package will tell you, there should be no empty line here.
> + help
> + Extension for PHP to assist with debugging and development.
> + Web page: http://xdebug.org
As check-package will tell you, there should be an empty line before the URL,
and there's shouldn't be a "Web page: " in front of it.
> diff --git a/package/xdebug/xdebug.hash b/package/xdebug/xdebug.hash
> new file mode 100644
> index 0000000000..a477a41d80
> --- /dev/null
> +++ b/package/xdebug/xdebug.hash
> @@ -0,0 +1,3 @@
> +# Locally computed
> +sha256 86df1c16f31a11ed242adbaba7f13290af23ac57e1095a02faceb41ea833f729 xdebug-2.7.0.tar.gz
> +sha256 ef479ee1a3da3f933e0d046ca8cd0c14601f29b2c0c41cc60c9388546a4e0272 LICENSE
> diff --git a/package/xdebug/xdebug.mk b/package/xdebug/xdebug.mk
> new file mode 100644
> index 0000000000..8c156c4297
> --- /dev/null
> +++ b/package/xdebug/xdebug.mk
> @@ -0,0 +1,25 @@
> +################################################################################
> +#
> +# xdebug
> +#
> +################################################################################
> +
> +XDEBUG_VERSION = 2.7.0
There is a 2.7.2 version since May...
> +XDEBUG_SITE = $(call github,xdebug,xdebug,$(XDEBUG_VERSION))
> +XDEBUG_INSTALL_STAGING = YES
> +XDEBUG_LICENSE = xdebug-license
XDEBUG_LICENSE = Xdebug License (PHP-3.0-like)
> +XDEBUG_LICENSE_FILES = LICENSE
> +XDEBUG_DEPENDENCIES = php host-autoconf
> +XDEBUG_CONF_OPTS = --enable-xdebug --with-php-config=$(STAGING_DIR)/usr/bin/php-config\
> + --with-xdebug=$(STAGING_DIR)/usr
Nowadays, we prefer to have one option per line in most cases, so:
XDEBUG_CONF_OPTS = \
--enable-xdebug \
--with-php-config=$(STAGING_DIR)/usr/bin/php-config \
--with-xdebug=$(STAGING_DIR)/usr
Also note the space before the backslash.
Regards,
Arnout
> +
> +define XDEBUG_PHPIZE
> + (cd $(@D); \
> + PHP_AUTOCONF=$(HOST_DIR)/usr/bin/autoconf \
> + PHP_AUTOHEADER=$(HOST_DIR)/usr/bin/autoheader \
> + $(STAGING_DIR)/usr/bin/phpize)
> +endef
> +
> +XDEBUG_PRE_CONFIGURE_HOOKS += XDEBUG_PHPIZE
> +
> +$(eval $(autotools-package))
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 13:27 ` Arnout Vandecappelle
@ 2019-09-23 13:59 ` Thomas Petazzoni
2019-09-23 15:03 ` Nicolas Carrier
2019-09-23 15:01 ` Nicolas Carrier
2019-09-23 15:03 ` Nicolas Carrier
2 siblings, 1 reply; 8+ messages in thread
From: Thomas Petazzoni @ 2019-09-23 13:59 UTC (permalink / raw)
To: buildroot
On Mon, 23 Sep 2019 15:27:21 +0200
Arnout Vandecappelle <arnout@mind.be> wrote:
> > diff --git a/package/Config.in b/package/Config.in
> > index 2fc11065f6..95115ec469 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> > source "package/valgrind/Config.in"
> > source "package/vmtouch/Config.in"
> > source "package/whetstone/Config.in"
> > + source "package/xdebug/Config.in"
>
> Hm. IIUC, this is really a PHP extension, *not* a debugger that happens to use
> PHP internally. Therefore, I would think that it fits more in the "External php
> extensions" menu.
Agreed, if it's a PHP extension, it should go in the PHP extensions
menu, and be called "php-xdebug".
> > index 0000000000..c0abb71896
> > --- /dev/null
> > +++ b/package/xdebug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_XDEBUG
> > + bool "xdebug"
> > + select BR2_PACKAGE_PHP
>
> If you select a package, you have to copy its dependencies.
>
> However, for a PHP package, it's more appropriate to depend on it I think. Note
> that if you move it to the external php extensions menu that dependency will be
> implicit.
If it goes in the PHP extensions menu, then it will automatically be
inside a "if BR2_PACKAGE_PHP...endif" block.
> Note also that normally, PHP extensions can only be built for !STATIC. Did you
> run test-pkg?
... and in a if !BR2_STATIC_LIBS..endif block.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 13:27 ` Arnout Vandecappelle
2019-09-23 13:59 ` Thomas Petazzoni
@ 2019-09-23 15:01 ` Nicolas Carrier
2019-09-23 15:05 ` Arnout Vandecappelle
2019-09-23 15:03 ` Nicolas Carrier
2 siblings, 1 reply; 8+ messages in thread
From: Nicolas Carrier @ 2019-09-23 15:01 UTC (permalink / raw)
To: buildroot
Hello,
First of all, thank you for taking the time to review my patch.
On Mon, 2019-09-23 at 15:27 +0200, Arnout Vandecappelle wrote:
> Hi Nicolas,
>
> On 23/09/2019 12:17, Nicolas Carrier wrote:
> > Extension for PHP to assist with debugging and development.
> >
> > Signed-off-by: Nicolas Carrier <nicolas.carrier@orolia.com>
> > ---
> > package/Config.in | 1 +
> > package/xdebug/Config.in | 7 +++++++
> > package/xdebug/xdebug.hash | 3 +++
> > package/xdebug/xdebug.mk | 25 +++++++++++++++++++++++++
> > 4 files changed, 36 insertions(+)
> > create mode 100644 package/xdebug/Config.in
> > create mode 100644 package/xdebug/xdebug.hash
> > create mode 100644 package/xdebug/xdebug.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index 2fc11065f6..95115ec469 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> > source "package/valgrind/Config.in"
> > source "package/vmtouch/Config.in"
> > source "package/whetstone/Config.in"
> > + source "package/xdebug/Config.in"
>
> Hm. IIUC, this is really a PHP extension, *not* a debugger that
> happens to use
> PHP internally. Therefore, I would think that it fits more in the
> "External php
> extensions" menu.
>
> But others may disagree...
Ok, originally, I was wondering whether it should go to Debugging or
Development tools ^^
I'll put it in "External php extensions" then.
>
> > endmenu
> >
> > menu "Development tools"
> > diff --git a/package/xdebug/Config.in b/package/xdebug/Config.in
> > new file mode 100644
> > index 0000000000..c0abb71896
> > --- /dev/null
> > +++ b/package/xdebug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_XDEBUG
> > + bool "xdebug"
> > + select BR2_PACKAGE_PHP
>
> If you select a package, you have to copy its dependencies.
>
> However, for a PHP package, it's more appropriate to depend on it I
> think. Note
> that if you move it to the external php extensions menu that
> dependency will be
> implicit.
>
Ok
> Note also that normally, PHP extensions can only be built for
> !STATIC. Did you
> run test-pkg?
No, I didn't, it seems that I read the contributor documentation too
fast...
I'm going to fix that.
>
> > +
>
> As check-package will tell you, there should be no empty line here.
>
> > + help
> > + Extension for PHP to assist with debugging and development.
> > + Web page: http://xdebug.org
>
> As check-package will tell you, there should be an empty line before
> the URL,
> and there's shouldn't be a "Web page: " in front of it.
>
Ok, will fix
> > diff --git a/package/xdebug/xdebug.hash
> > b/package/xdebug/xdebug.hash
> > new file mode 100644
> > index 0000000000..a477a41d80
> > --- /dev/null
> > +++ b/package/xdebug/xdebug.hash
> > @@ -0,0 +1,3 @@
> > +# Locally computed
> > +sha256
> > 86df1c16f31a11ed242adbaba7f13290af23ac57e1095a02faceb41ea833f729 x
> > debug-2.7.0.tar.gz
> > +sha256
> > ef479ee1a3da3f933e0d046ca8cd0c14601f29b2c0c41cc60c9388546a4e0272 L
> > ICENSE
> > diff --git a/package/xdebug/xdebug.mk b/package/xdebug/xdebug.mk
> > new file mode 100644
> > index 0000000000..8c156c4297
> > --- /dev/null
> > +++ b/package/xdebug/xdebug.mk
> > @@ -0,0 +1,25 @@
> > +##################################################################
> > ##############
> > +#
> > +# xdebug
> > +#
> > +##################################################################
> > ##############
> > +
> > +XDEBUG_VERSION = 2.7.0
>
> There is a 2.7.2 version since May...
Well, the thing is that the 2.7.0 version is what's in use at Orolia
ATM, so I'm quite confident that this version would work properly.
I was also thinking that a later patch could bump the version once it'd
be properly tested.
So you think that I should bump to 2.7.2 directly?
> > +XDEBUG_SITE = $(call github,xdebug,xdebug,$(XDEBUG_VERSION))
> > +XDEBUG_INSTALL_STAGING = YES
> > +XDEBUG_LICENSE = xdebug-license
>
> XDEBUG_LICENSE = Xdebug License (PHP-3.0-like)
>
> > +XDEBUG_LICENSE_FILES = LICENSE
> > +XDEBUG_DEPENDENCIES = php host-autoconf
> > +XDEBUG_CONF_OPTS = --enable-xdebug --with-php-
> > config=$(STAGING_DIR)/usr/bin/php-config\
> > + --with-xdebug=$(STAGING_DIR)/usr
>
> Nowadays, we prefer to have one option per line in most cases, so:
>
> XDEBUG_CONF_OPTS = \
> --enable-xdebug \
> --with-php-config=$(STAGING_DIR)/usr/bin/php-config \
> --with-xdebug=$(STAGING_DIR)/usr
>
> Also note the space before the backslash.
Ok, thank you, I'm going to fix that too.
> Regards,
> Arnout
>
> > +
> > +define XDEBUG_PHPIZE
> > + (cd $(@D); \
> > + PHP_AUTOCONF=$(HOST_DIR)/usr/bin/autoconf \
> > + PHP_AUTOHEADER=$(HOST_DIR)/usr/bin/autoheader \
> > + $(STAGING_DIR)/usr/bin/phpize)
> > +endef
> > +
> > +XDEBUG_PRE_CONFIGURE_HOOKS += XDEBUG_PHPIZE
> > +
> > +$(eval $(autotools-package))
> >
> ATTENTION: This email came from an external source.
> Do not open attachments or click on links from unknown senders or
> unexpected emails.
Regards.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 13:59 ` Thomas Petazzoni
@ 2019-09-23 15:03 ` Nicolas Carrier
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Carrier @ 2019-09-23 15:03 UTC (permalink / raw)
To: buildroot
Hello,
Thank you for the review
On Mon, 2019-09-23 at 15:59 +0200, Thomas Petazzoni wrote:
> On Mon, 23 Sep 2019 15:27:21 +0200
> Arnout Vandecappelle <arnout@mind.be> wrote:
>
> > > diff --git a/package/Config.in b/package/Config.in
> > > index 2fc11065f6..95115ec469 100644
> > > --- a/package/Config.in
> > > +++ b/package/Config.in
> > > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> > > source "package/valgrind/Config.in"
> > > source "package/vmtouch/Config.in"
> > > source "package/whetstone/Config.in"
> > > + source "package/xdebug/Config.in"
> >
> > Hm. IIUC, this is really a PHP extension, *not* a debugger that
> > happens to use
> > PHP internally. Therefore, I would think that it fits more in the
> > "External php
> > extensions" menu.
>
> Agreed, if it's a PHP extension, it should go in the PHP extensions
> menu, and be called "php-xdebug".
Ok, will do
>
> > > index 0000000000..c0abb71896
> > > --- /dev/null
> > > +++ b/package/xdebug/Config.in
> > > @@ -0,0 +1,7 @@
> > > +config BR2_PACKAGE_XDEBUG
> > > + bool "xdebug"
> > > + select BR2_PACKAGE_PHP
> >
> > If you select a package, you have to copy its dependencies.
> >
> > However, for a PHP package, it's more appropriate to depend on it
> > I think. Note
> > that if you move it to the external php extensions menu that
> > dependency will be
> > implicit.
>
> If it goes in the PHP extensions menu, then it will automatically be
> inside a "if BR2_PACKAGE_PHP...endif" block.
>
> > Note also that normally, PHP extensions can only be built for
> > !STATIC. Did you
> > run test-pkg?
>
> ... and in a if !BR2_STATIC_LIBS..endif block.
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
> ATTENTION: This email came from an external source.
> Do not open attachments or click on links from unknown senders or
> unexpected emails.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 13:27 ` Arnout Vandecappelle
2019-09-23 13:59 ` Thomas Petazzoni
2019-09-23 15:01 ` Nicolas Carrier
@ 2019-09-23 15:03 ` Nicolas Carrier
2 siblings, 0 replies; 8+ messages in thread
From: Nicolas Carrier @ 2019-09-23 15:03 UTC (permalink / raw)
To: buildroot
Hello,
First of all, thank you for taking the time to review my patch.
On Mon, 2019-09-23 at 15:27 +0200, Arnout Vandecappelle wrote:
> Hi Nicolas,
>
> On 23/09/2019 12:17, Nicolas Carrier wrote:
> > Extension for PHP to assist with debugging and development.
> >
> > Signed-off-by: Nicolas Carrier <nicolas.carrier@orolia.com>
> > ---
> > package/Config.in | 1 +
> > package/xdebug/Config.in | 7 +++++++
> > package/xdebug/xdebug.hash | 3 +++
> > package/xdebug/xdebug.mk | 25 +++++++++++++++++++++++++
> > 4 files changed, 36 insertions(+)
> > create mode 100644 package/xdebug/Config.in
> > create mode 100644 package/xdebug/xdebug.hash
> > create mode 100644 package/xdebug/xdebug.mk
> >
> > diff --git a/package/Config.in b/package/Config.in
> > index 2fc11065f6..95115ec469 100644
> > --- a/package/Config.in
> > +++ b/package/Config.in
> > @@ -141,6 +141,7 @@ menu "Debugging, profiling and benchmark"
> > source "package/valgrind/Config.in"
> > source "package/vmtouch/Config.in"
> > source "package/whetstone/Config.in"
> > + source "package/xdebug/Config.in"
>
> Hm. IIUC, this is really a PHP extension, *not* a debugger that
> happens to use
> PHP internally. Therefore, I would think that it fits more in the
> "External php
> extensions" menu.
>
> But others may disagree...
Ok, originally, I was wondering whether it should go to Debugging or
Development tools ^^
I'll put it in "External php extensions" then.
>
>
> > endmenu
> >
> > menu "Development tools"
> > diff --git a/package/xdebug/Config.in b/package/xdebug/Config.in
> > new file mode 100644
> > index 0000000000..c0abb71896
> > --- /dev/null
> > +++ b/package/xdebug/Config.in
> > @@ -0,0 +1,7 @@
> > +config BR2_PACKAGE_XDEBUG
> > + bool "xdebug"
> > + select BR2_PACKAGE_PHP
>
> If you select a package, you have to copy its dependencies.
>
> However, for a PHP package, it's more appropriate to depend on it I
> think. Note
> that if you move it to the external php extensions menu that
> dependency will be
> implicit.
>
Ok
> Note also that normally, PHP extensions can only be built for
> !STATIC. Did you
> run test-pkg?
No, I didn't, it seems that I read the contributor documentation too
fast...
I'm going to fix that.
>
>
> > +
>
> As check-package will tell you, there should be no empty line here.
>
> > + help
> > + Extension for PHP to assist with debugging and development.
> > + Web page: http://xdebug.org
>
> As check-package will tell you, there should be an empty line before
> the URL,
> and there's shouldn't be a "Web page: " in front of it.
>
Ok, will fix
> > diff --git a/package/xdebug/xdebug.hash
> > b/package/xdebug/xdebug.hash
> > new file mode 100644
> > index 0000000000..a477a41d80
> > --- /dev/null
> > +++ b/package/xdebug/xdebug.hash
> > @@ -0,0 +1,3 @@
> > +# Locally computed
> > +sha256
> > 86df1c16f31a11ed242adbaba7f13290af23ac57e1095a02faceb41ea833f729 x
> > debug-2.7.0.tar.gz
> > +sha256
> > ef479ee1a3da3f933e0d046ca8cd0c14601f29b2c0c41cc60c9388546a4e0272 L
> > ICENSE
> > diff --git a/package/xdebug/xdebug.mk b/package/xdebug/xdebug.mk
> > new file mode 100644
> > index 0000000000..8c156c4297
> > --- /dev/null
> > +++ b/package/xdebug/xdebug.mk
> > @@ -0,0 +1,25 @@
> > +##################################################################
> > ##############
> > +#
> > +# xdebug
> > +#
> > +##################################################################
> > ##############
> > +
> > +XDEBUG_VERSION = 2.7.0
>
> There is a 2.7.2 version since May...
Well, the thing is that the 2.7.0 version is what's in use at Orolia
ATM, so I'm quite confident that this version would work properly.
I was also thinking that a later patch could bump the version once it'd
be properly tested.
So you think that I should bump to 2.7.2 directly?
>
> > +XDEBUG_SITE = $(call github,xdebug,xdebug,$(XDEBUG_VERSION))
> > +XDEBUG_INSTALL_STAGING = YES
> > +XDEBUG_LICENSE = xdebug-license
>
> XDEBUG_LICENSE = Xdebug License (PHP-3.0-like)
>
> > +XDEBUG_LICENSE_FILES = LICENSE
> > +XDEBUG_DEPENDENCIES = php host-autoconf
> > +XDEBUG_CONF_OPTS = --enable-xdebug --with-php-
> > config=$(STAGING_DIR)/usr/bin/php-config\
> > + --with-xdebug=$(STAGING_DIR)/usr
>
> Nowadays, we prefer to have one option per line in most cases, so:
>
> XDEBUG_CONF_OPTS = \
> --enable-xdebug \
> --with-php-config=$(STAGING_DIR)/usr/bin/php-config \
> --with-xdebug=$(STAGING_DIR)/usr
>
> Also note the space before the backslash.
Ok, thank you, I'm going to fix that too.
>
> Regards,
> Arnout
>
> > +
> > +define XDEBUG_PHPIZE
> > + (cd $(@D); \
> > + PHP_AUTOCONF=$(HOST_DIR)/usr/bin/autoconf \
> > + PHP_AUTOHEADER=$(HOST_DIR)/usr/bin/autoheader \
> > + $(STAGING_DIR)/usr/bin/phpize)
> > +endef
> > +
> > +XDEBUG_PRE_CONFIGURE_HOOKS += XDEBUG_PHPIZE
> > +
> > +$(eval $(autotools-package))
> >
> ATTENTION: This email came from an external source.
> Do not open attachments or click on links from unknown senders or
> unexpected emails.
Regards.
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 15:01 ` Nicolas Carrier
@ 2019-09-23 15:05 ` Arnout Vandecappelle
2019-09-23 15:24 ` Nicolas Carrier
0 siblings, 1 reply; 8+ messages in thread
From: Arnout Vandecappelle @ 2019-09-23 15:05 UTC (permalink / raw)
To: buildroot
On 23/09/2019 17:01, Nicolas Carrier wrote:
>>> +XDEBUG_VERSION = 2.7.0
>> There is a 2.7.2 version since May...
> Well, the thing is that the 2.7.0 version is what's in use at Orolia
> ATM, so I'm quite confident that this version would work properly.
> I was also thinking that a later patch could bump the version once it'd
> be properly tested.
>
> So you think that I should bump to 2.7.2 directly?
If you can test it, please bump directly to 2.7.2, yes. If you can't (don't
have the time), please add to the commit message something like "Version 2.7.2
is out already, but this version hasn't been tested so let's stick to 2.7.0".
"Test it" means a basic runtime smoke test. I.e. start the debugger on an
actual target. It doesn't mean you have to test all features.
Regards,
Arnout
^ permalink raw reply [flat|nested] 8+ messages in thread
* [Buildroot] [PATCH 1/1] package/xdebug: new package
2019-09-23 15:05 ` Arnout Vandecappelle
@ 2019-09-23 15:24 ` Nicolas Carrier
0 siblings, 0 replies; 8+ messages in thread
From: Nicolas Carrier @ 2019-09-23 15:24 UTC (permalink / raw)
To: buildroot
Ok, thank you again, I'll do a resubmit as soon as I can.
Regards.
Nicolas CARRIER | Senior Development Engineer | nicolas.carrier at orolia.com<mailto:prenom.nom@orolia.com>
________________________________
From: Arnout Vandecappelle <arnout@mind.be>
Sent: Monday, September 23, 2019 5:05 PM
To: Nicolas Carrier <nicolas.carrier@orolia.com>; buildroot at buildroot.org <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH 1/1] package/xdebug: new package
On 23/09/2019 17:01, Nicolas Carrier wrote:
>>> +XDEBUG_VERSION = 2.7.0
>> There is a 2.7.2 version since May...
> Well, the thing is that the 2.7.0 version is what's in use at Orolia
> ATM, so I'm quite confident that this version would work properly.
> I was also thinking that a later patch could bump the version once it'd
> be properly tested.
>
> So you think that I should bump to 2.7.2 directly?
If you can test it, please bump directly to 2.7.2, yes. If you can't (don't
have the time), please add to the commit message something like "Version 2.7.2
is out already, but this version hasn't been tested so let's stick to 2.7.0".
"Test it" means a basic runtime smoke test. I.e. start the debugger on an
actual target. It doesn't mean you have to test all features.
Regards,
Arnout
ATTENTION: This email came from an external source.
Do not open attachments or click on links from unknown senders or unexpected emails.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20190923/8cf7004e/attachment.html>
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-09-23 15:24 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-09-23 10:17 [Buildroot] [PATCH 1/1] package/xdebug: new package Nicolas Carrier
2019-09-23 13:27 ` Arnout Vandecappelle
2019-09-23 13:59 ` Thomas Petazzoni
2019-09-23 15:03 ` Nicolas Carrier
2019-09-23 15:01 ` Nicolas Carrier
2019-09-23 15:05 ` Arnout Vandecappelle
2019-09-23 15:24 ` Nicolas Carrier
2019-09-23 15:03 ` Nicolas Carrier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox