From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libhttpserver: new package
Date: Tue, 24 Sep 2019 09:47:36 +0200 [thread overview]
Message-ID: <20190924094736.7e1530f7@windsurf> (raw)
In-Reply-To: <CADGPgeAthWJO_LokTuri+513d0nTeAvzvFqv6z4EeLuzHQtmpA@mail.gmail.com>
On Tue, 24 Sep 2019 09:22:37 +0200
Stephan Hoffmann <stephan.hoffmann@ext.grandcentrix.net> wrote:
> > We need a Signed-off-by line (at least from you) in this patch. Also,
> > if it comes from upstream, a link to the upstream commit is good to
> > have.
> >
> Is there any mechanism allowing to cherry pick a commit from the upstream
> repo instead of providing a patch file? I don't really feel good about
> modifying the patch file;-)
We prefer to have patches locally instead of downloading them, because
the hash of patches generated by Github is not stable.
We have numerous patches locally in package directories, and changing
their commit log is perfectly fine.
See for example
package/fastd/0003-cipher-remove-aes128-ctr-NaCl-implementation.patch
how the Signed-off-by line and reference to the upstream commit was
added.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2019-09-24 7:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-23 11:52 [Buildroot] [PATCH] libhttpserver: new package stephan.hoffmann at ext.grandcentrix.net
2019-09-23 13:56 ` Thomas Petazzoni
2019-09-24 7:22 ` Stephan Hoffmann
2019-09-24 7:47 ` Thomas Petazzoni [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190924094736.7e1530f7@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox