* [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10
@ 2019-10-02 17:51 Fabrice Fontaine
2019-10-02 18:11 ` Bernd Kuhls
2019-10-02 19:04 ` Thomas Petazzoni
0 siblings, 2 replies; 3+ messages in thread
From: Fabrice Fontaine @ 2019-10-02 17:51 UTC (permalink / raw)
To: buildroot
Fixes:
- http://autobuild.buildroot.org/results/991dd1d74f00f027a905d2ec3ad1a1b2b723f978
Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
package/znc/znc.mk | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/package/znc/znc.mk b/package/znc/znc.mk
index 78e1410b68..54dc63f4ea 100644
--- a/package/znc/znc.mk
+++ b/package/znc/znc.mk
@@ -11,6 +11,11 @@ ZNC_LICENSE_FILES = LICENSE
ZNC_DEPENDENCIES = host-pkgconf
ZNC_CONF_OPTS = -DWANT_CYRUS=OFF -DWANT_I18N=OFF -DWANT_PERL=OFF
+# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
+# disable a try_run() call in the FindThreads tests, which caused a
+# build failure when cross-compiling.
+ZNC_CONF_OPTS += -DTHREADS_PTHREAD_ARG=OFF
+
ifeq ($(BR2_PACKAGE_ICU),y)
ZNC_DEPENDENCIES += icu
ZNC_CONF_OPTS += -DWANT_ICU=ON
--
2.23.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10
2019-10-02 17:51 [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10 Fabrice Fontaine
@ 2019-10-02 18:11 ` Bernd Kuhls
2019-10-02 19:04 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Bernd Kuhls @ 2019-10-02 18:11 UTC (permalink / raw)
To: buildroot
Am Wed, 02 Oct 2019 19:51:20 +0200 schrieb Fabrice Fontaine:
> +# Before CMake 3.10, passing THREADS_PTHREAD_ARG=OFF was needed to
Hi,
good catch, the old cmake version was the reason why I could not
reproduce the error here (cmake version 3.13.4).
Reviewed-by: Bernd Kuhls <bernd.kuhls@t-online.de>
Regards, Bernd
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10
2019-10-02 17:51 [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10 Fabrice Fontaine
2019-10-02 18:11 ` Bernd Kuhls
@ 2019-10-02 19:04 ` Thomas Petazzoni
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Petazzoni @ 2019-10-02 19:04 UTC (permalink / raw)
To: buildroot
On Wed, 2 Oct 2019 19:51:20 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> Fixes:
> - http://autobuild.buildroot.org/results/991dd1d74f00f027a905d2ec3ad1a1b2b723f978
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> package/znc/znc.mk | 5 +++++
> 1 file changed, 5 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-10-02 19:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-10-02 17:51 [Buildroot] [PATCH 1/1] package/znc: fix build with cmake < 3.10 Fabrice Fontaine
2019-10-02 18:11 ` Bernd Kuhls
2019-10-02 19:04 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox