* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-03 14:04 [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path James Hilliard
@ 2019-10-03 18:14 ` Carlos Santos
2019-10-04 8:16 ` Thomas Petazzoni
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Carlos Santos @ 2019-10-03 18:14 UTC (permalink / raw)
To: buildroot
On Thu, Oct 3, 2019 at 11:04 AM James Hilliard
<james.hilliard1@gmail.com> wrote:
>
> Per upstream commit bf12e1fa9f48e8ee91a2869e69484c70595b5160
> https://cdn.kernel.org/pub/linux/utils/nfs-utils/1.3.4/1.3.4-Changelog
>
> Currently nfs-utils_env.sh is installed in a
> directory that is own by systemd. They requested
> via https://bugzilla.redhat.com/show_bug.cgi?id=1303113
> to move the script into /usr/libexec/nfs-utils
>
> As such we must update the installation path for nfs-utils_env.sh.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 9d3e5e7563..cb2caa03f0 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -93,7 +93,7 @@ define NFS_UTILS_INSTALL_INIT_SYSTEMD
> $(TARGET_DIR)/etc/systemd/system/remote-fs.target.wants/nfs-client.target
>
> $(INSTALL) -D -m 0755 package/nfs-utils/nfs-utils_env.sh \
> - $(TARGET_DIR)/usr/lib/systemd/scripts/nfs-utils_env.sh
> + $(TARGET_DIR)/usr/libexec/nfs-utils/nfs-utils_env.sh
>
> $(INSTALL) -D -m 0644 package/nfs-utils/nfs-utils_tmpfiles.conf \
> $(TARGET_DIR)/usr/lib/tmpfiles.d/nfs-utils.conf
> --
> 2.20.1
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
Tested-by: Carlos Santos <unixmania@gmail.com>
^ permalink raw reply [flat|nested] 7+ messages in thread* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-03 14:04 [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path James Hilliard
2019-10-03 18:14 ` Carlos Santos
@ 2019-10-04 8:16 ` Thomas Petazzoni
2019-10-04 12:43 ` James Hilliard
2019-10-05 21:35 ` Thomas Petazzoni
2019-10-28 9:39 ` Peter Korsgaard
3 siblings, 1 reply; 7+ messages in thread
From: Thomas Petazzoni @ 2019-10-04 8:16 UTC (permalink / raw)
To: buildroot
Hello James,
On Thu, 3 Oct 2019 08:04:10 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Per upstream commit bf12e1fa9f48e8ee91a2869e69484c70595b5160
> https://cdn.kernel.org/pub/linux/utils/nfs-utils/1.3.4/1.3.4-Changelog
>
> Currently nfs-utils_env.sh is installed in a
> directory that is own by systemd. They requested
> via https://bugzilla.redhat.com/show_bug.cgi?id=1303113
> to move the script into /usr/libexec/nfs-utils
>
> As such we must update the installation path for nfs-utils_env.sh.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> index 9d3e5e7563..cb2caa03f0 100644
> --- a/package/nfs-utils/nfs-utils.mk
> +++ b/package/nfs-utils/nfs-utils.mk
> @@ -93,7 +93,7 @@ define NFS_UTILS_INSTALL_INIT_SYSTEMD
> $(TARGET_DIR)/etc/systemd/system/remote-fs.target.wants/nfs-client.target
>
> $(INSTALL) -D -m 0755 package/nfs-utils/nfs-utils_env.sh \
> - $(TARGET_DIR)/usr/lib/systemd/scripts/nfs-utils_env.sh
> + $(TARGET_DIR)/usr/libexec/nfs-utils/nfs-utils_env.sh
If I get it correctly looking at upstream commit
bf12e1fa9f48e8ee91a2869e69484c70595b5160, this script is only used from
nfs-config.service, and we are not installing nfs-config.service. So
what is the impact ?
Also, could you indicate if this issue is applicable to 2019.02.x,
2019.05.x and 2019.08.x ? I guess it depends on which version of
nfs-utils is currently shipped in those branches, and whether they have
bf12e1fa9f48e8ee91a2869e69484c70595b5160 or not.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-04 8:16 ` Thomas Petazzoni
@ 2019-10-04 12:43 ` James Hilliard
2019-10-04 12:55 ` Thomas Petazzoni
0 siblings, 1 reply; 7+ messages in thread
From: James Hilliard @ 2019-10-04 12:43 UTC (permalink / raw)
To: buildroot
On Fri, Oct 4, 2019 at 10:16 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> Hello James,
>
> On Thu, 3 Oct 2019 08:04:10 -0600
> James Hilliard <james.hilliard1@gmail.com> wrote:
>
> > Per upstream commit bf12e1fa9f48e8ee91a2869e69484c70595b5160
> > https://cdn.kernel.org/pub/linux/utils/nfs-utils/1.3.4/1.3.4-Changelog
> >
> > Currently nfs-utils_env.sh is installed in a
> > directory that is own by systemd. They requested
> > via https://bugzilla.redhat.com/show_bug.cgi?id=1303113
> > to move the script into /usr/libexec/nfs-utils
> >
> > As such we must update the installation path for nfs-utils_env.sh.
> >
> > Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> > ---
> > package/nfs-utils/nfs-utils.mk | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/package/nfs-utils/nfs-utils.mk b/package/nfs-utils/nfs-utils.mk
> > index 9d3e5e7563..cb2caa03f0 100644
> > --- a/package/nfs-utils/nfs-utils.mk
> > +++ b/package/nfs-utils/nfs-utils.mk
> > @@ -93,7 +93,7 @@ define NFS_UTILS_INSTALL_INIT_SYSTEMD
> > $(TARGET_DIR)/etc/systemd/system/remote-fs.target.wants/nfs-client.target
> >
> > $(INSTALL) -D -m 0755 package/nfs-utils/nfs-utils_env.sh \
> > - $(TARGET_DIR)/usr/lib/systemd/scripts/nfs-utils_env.sh
> > + $(TARGET_DIR)/usr/libexec/nfs-utils/nfs-utils_env.sh
>
> If I get it correctly looking at upstream commit
> bf12e1fa9f48e8ee91a2869e69484c70595b5160, this script is only used from
> nfs-config.service, and we are not installing nfs-config.service. So
> what is the impact ?
The package itself handles nfs-config.service installation so we do use it.
See:
http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=systemd/Makefile.am;h=03f96e93dccf814f7c8aee5cc9a78083231fefb3;hb=188354e57dd8476e66ce30d647180a106da29b88#l8
>
> Also, could you indicate if this issue is applicable to 2019.02.x,
> 2019.05.x and 2019.08.x ? I guess it depends on which version of
> nfs-utils is currently shipped in those branches, and whether they have
> bf12e1fa9f48e8ee91a2869e69484c70595b5160 or not.
It was broken by buildroot commit 06445ee36dee49555599bc9c963201bce237ab64
so anything before that should be fine.
>
> Thanks,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-04 12:43 ` James Hilliard
@ 2019-10-04 12:55 ` Thomas Petazzoni
0 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2019-10-04 12:55 UTC (permalink / raw)
To: buildroot
On Fri, 4 Oct 2019 14:43:18 +0200
James Hilliard <james.hilliard1@gmail.com> wrote:
> > If I get it correctly looking at upstream commit
> > bf12e1fa9f48e8ee91a2869e69484c70595b5160, this script is only used from
> > nfs-config.service, and we are not installing nfs-config.service. So
> > what is the impact ?
> The package itself handles nfs-config.service installation so we do use it.
> See:
> http://git.linux-nfs.org/?p=steved/nfs-utils.git;a=blob;f=systemd/Makefile.am;h=03f96e93dccf814f7c8aee5cc9a78083231fefb3;hb=188354e57dd8476e66ce30d647180a106da29b88#l8
OK.
> > Also, could you indicate if this issue is applicable to 2019.02.x,
> > 2019.05.x and 2019.08.x ? I guess it depends on which version of
> > nfs-utils is currently shipped in those branches, and whether they have
> > bf12e1fa9f48e8ee91a2869e69484c70595b5160 or not.
> It was broken by buildroot commit 06445ee36dee49555599bc9c963201bce237ab64
> so anything before that should be fine.
OK, so 2019.08.x is affected, but not 2019.05.x and 2019.02.x.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-03 14:04 [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path James Hilliard
2019-10-03 18:14 ` Carlos Santos
2019-10-04 8:16 ` Thomas Petazzoni
@ 2019-10-05 21:35 ` Thomas Petazzoni
2019-10-28 9:39 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Thomas Petazzoni @ 2019-10-05 21:35 UTC (permalink / raw)
To: buildroot
On Thu, 3 Oct 2019 08:04:10 -0600
James Hilliard <james.hilliard1@gmail.com> wrote:
> Per upstream commit bf12e1fa9f48e8ee91a2869e69484c70595b5160
> https://cdn.kernel.org/pub/linux/utils/nfs-utils/1.3.4/1.3.4-Changelog
>
> Currently nfs-utils_env.sh is installed in a
> directory that is own by systemd. They requested
> via https://bugzilla.redhat.com/show_bug.cgi?id=1303113
> to move the script into /usr/libexec/nfs-utils
>
> As such we must update the installation path for nfs-utils_env.sh.
>
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
> ---
> package/nfs-utils/nfs-utils.mk | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 7+ messages in thread
* [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path
2019-10-03 14:04 [Buildroot] [PATCH 1/1] package/nfs-utils: fix nfs-utils_env.sh path James Hilliard
` (2 preceding siblings ...)
2019-10-05 21:35 ` Thomas Petazzoni
@ 2019-10-28 9:39 ` Peter Korsgaard
3 siblings, 0 replies; 7+ messages in thread
From: Peter Korsgaard @ 2019-10-28 9:39 UTC (permalink / raw)
To: buildroot
>>>>> "James" == James Hilliard <james.hilliard1@gmail.com> writes:
> Per upstream commit bf12e1fa9f48e8ee91a2869e69484c70595b5160
> https://cdn.kernel.org/pub/linux/utils/nfs-utils/1.3.4/1.3.4-Changelog
> Currently nfs-utils_env.sh is installed in a
> directory that is own by systemd. They requested
> via https://bugzilla.redhat.com/show_bug.cgi?id=1303113
> to move the script into /usr/libexec/nfs-utils
> As such we must update the installation path for nfs-utils_env.sh.
> Signed-off-by: James Hilliard <james.hilliard1@gmail.com>
Committed to 2019.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 7+ messages in thread