[Buildroot] [PATCH v2 1/4] configs/imx6-sabresd_qt5: Move from mdev to eudev

[Buildroot] [PATCH v2 1/4] configs/imx6-sabresd_qt5: Move from mdev to eudev

[Fabio Estevam]

Since commit cf66a67112cd706d2e7 ("package/glmark2: drm support needs udev")
udev is needed when the drm flavor is used.

Move from mdev to eudev in order to fix the following glmark2
build failure:

Unknown flavor: . Supported flavors are dispmanx-glesv2, drm-gl,
drm-glesv2, mir-gl, mir-glesv2, wayland-gl, wayland-glesv2, win32-gl,
win32-glesv2, x11-gl, x11-glesv2

Suggested-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- Fix Subject and commit log: from mdev to eudev

 configs/imx6-sabresd_qt5_defconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/configs/imx6-sabresd_qt5_defconfig b/configs/imx6-sabresd_qt5_defconfig
index 4616f57eae..a2925bd056 100644
--- a/configs/imx6-sabresd_qt5_defconfig
+++ b/configs/imx6-sabresd_qt5_defconfig
@@ -95,4 +95,4 @@ BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_VIDEOPARSERS=y
 BR2_PACKAGE_GST1_PLUGINS_BAD_PLUGIN_KMS=y
 
 # For automatic kernel module loading
-BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_MDEV=y
+BR2_ROOTFS_DEVICE_CREATION_DYNAMIC_EUDEV=y
-- 
2.17.1

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Fabio Estevam]

After migrating to Mesa 19.2 the imx-drm_dri.so is no longer installed
unless the kmsro gallium driver is selected, so explicitly select
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO to fix the problem.

Suggested-by: Peter Seiderer <ps.report@gmx.net>
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- None

 configs/imx6-sabresd_qt5_defconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configs/imx6-sabresd_qt5_defconfig b/configs/imx6-sabresd_qt5_defconfig
index a2925bd056..887e53dc21 100644
--- a/configs/imx6-sabresd_qt5_defconfig
+++ b/configs/imx6-sabresd_qt5_defconfig
@@ -48,6 +48,7 @@ BR2_LINUX_KERNEL_NEEDS_HOST_OPENSSL=y
 # GL driver
 BR2_PACKAGE_MESA3D=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y
+BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
 BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
 BR2_PACKAGE_MESA3D_OPENGL_ES=y
 
-- 
2.17.1

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Thomas Petazzoni]

On Wed,  9 Oct 2019 14:00:02 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y

I don't think this is the correct fix. mesa3d itself should be fixed to
not require explicitly enabling this option. If
BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want
the etnaviv driver, it should be there.

>  BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y

BTW, why do you need this ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Fabio Estevam]

Hi Thomas,

> Fabio Estevam <festevam@gmail.com> wrote:
>
> > +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
>
> I don't think this is the correct fix. mesa3d itself should be fixed to
> not require explicitly enabling this option. If
> BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want
> the etnaviv driver, it should be there.

Yes, it seems we currently have a bug in mesa, which does not install
imx-drm_dri.so without BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO being
selected.

> >  BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_SWRAST=y
>
> BTW, why do you need this ?

Yes, I can remove it.

Thanks

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Erico Nunes]

On Fri, Oct 11, 2019 at 4:37 AM Fabio Estevam <festevam@gmail.com> wrote:
>
> Hi Thomas,
>
> > Fabio Estevam <festevam@gmail.com> wrote:
> >
> > > +BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO=y
> >
> > I don't think this is the correct fix. mesa3d itself should be fixed to
> > not require explicitly enabling this option. If
> > BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_ETNAVIV=y is enabled, then you want
> > the etnaviv driver, it should be there.
>
> Yes, it seems we currently have a bug in mesa, which does not install
> imx-drm_dri.so without BR2_PACKAGE_MESA3D_GALLIUM_DRIVER_KMSRO being
> selected.
I think it is a valid choice to not have it. For example, you might be
interested in only having the GPU for offscreen rendering. So if you
do want the drm driver to bridge to the display, I think you should
just enable kmsro.

Erico

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Thomas Petazzoni]

On Fri, 11 Oct 2019 15:15:16 +0200
Erico Nunes <nunes.erico@gmail.com> wrote:

> I think it is a valid choice to not have it. For example, you might be
> interested in only having the GPU for offscreen rendering. So if you
> do want the drm driver to bridge to the display, I think you should
> just enable kmsro.

Ah, OK, indeed that makes sense. I'll revive Fabio's patch then.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 2/4] configs/imx6-sabresd_qt5: Select the KMSRO gallium driver

[Fabio Estevam]

Hi Thomas,

On Fri, Oct 11, 2019 at 10:20 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Fri, 11 Oct 2019 15:15:16 +0200
> Erico Nunes <nunes.erico@gmail.com> wrote:
>
> > I think it is a valid choice to not have it. For example, you might be
> > interested in only having the GPU for offscreen rendering. So if you
> > do want the drm driver to bridge to the display, I think you should
> > just enable kmsro.
>
> Ah, OK, indeed that makes sense. I'll revive Fabio's patch then.

Do you want me to resend this patch?

[Buildroot] [PATCH v2 3/4] imx6-sabresd/readme.txt: Improve Qt5 Cinematic Demo instructions

[Fabio Estevam]

QT_QPA_EGLFS_ALWAYS_SET_MODE=1 needs to be exported, otherwise the Qt5
Cinematic demo throws a storm of the following messages:

Could not queue DRM page flip on screen LVDS1 (Invalid argument)

Improve the instructions by mentioning such requirement.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- None

 board/freescale/imx6-sabresd/readme.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/board/freescale/imx6-sabresd/readme.txt b/board/freescale/imx6-sabresd/readme.txt
index f09ff5caf4..292dab72c4 100644
--- a/board/freescale/imx6-sabresd/readme.txt
+++ b/board/freescale/imx6-sabresd/readme.txt
@@ -80,6 +80,7 @@ Running kmscube application:
 Running Qt5 Cinematic Demo:
 
 # export QT_QPA_EGLFS_KMS_CONFIG=/root/sabresd.json
+# export QT_QPA_EGLFS_ALWAYS_SET_MODE=1
 # /usr/share/Qt5/CinematicExperience/Qt5_CinematicExperience
 
 Running gl2mark benchmark:
-- 
2.17.1

[Buildroot] [PATCH v2 3/4] imx6-sabresd/readme.txt: Improve Qt5 Cinematic Demo instructions

[Thomas Petazzoni]

On Wed,  9 Oct 2019 14:00:03 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> QT_QPA_EGLFS_ALWAYS_SET_MODE=1 needs to be exported, otherwise the Qt5
> Cinematic demo throws a storm of the following messages:
> 
> Could not queue DRM page flip on screen LVDS1 (Invalid argument)
> 
> Improve the instructions by mentioning such requirement.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - None

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 4/4] configs/imx6-sabresd: Bump U-Boot and kernel versions

[Fabio Estevam]

Bump U-Boot to 2019.10 and kernel to 5.3.4 version.

Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
Changes since v1:
- None

 configs/imx6-sabresd_defconfig     | 8 ++++----
 configs/imx6-sabresd_qt5_defconfig | 8 ++++----
 2 files changed, 8 insertions(+), 8 deletions(-)

diff --git a/configs/imx6-sabresd_defconfig b/configs/imx6-sabresd_defconfig
index c2924b2e39..0d070e47f8 100644
--- a/configs/imx6-sabresd_defconfig
+++ b/configs/imx6-sabresd_defconfig
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # System
 BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
@@ -24,7 +24,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -32,7 +32,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
diff --git a/configs/imx6-sabresd_qt5_defconfig b/configs/imx6-sabresd_qt5_defconfig
index 887e53dc21..7a541951ae 100644
--- a/configs/imx6-sabresd_qt5_defconfig
+++ b/configs/imx6-sabresd_qt5_defconfig
@@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
 BR2_ARM_ENABLE_VFP=y
 BR2_ARM_FPU_VFPV3=y
 
-# Linux headers same as kernel, a 4.19 series
-BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
+# Linux headers same as kernel, a 5.3 series
+BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
 
 # Additional features needed for packages
 BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
@@ -30,7 +30,7 @@ BR2_ROOTFS_OVERLAY="board/freescale/imx6-sabresd/rootfs_overlay"
 BR2_TARGET_UBOOT=y
 BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
 BR2_TARGET_UBOOT_CUSTOM_VERSION=y
-BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
+BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
 BR2_TARGET_UBOOT_FORMAT_IMG=y
 BR2_TARGET_UBOOT_SPL=y
 BR2_TARGET_UBOOT_SPL_NAME="SPL"
@@ -38,7 +38,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
 # Kernel
 BR2_LINUX_KERNEL=y
 BR2_LINUX_KERNEL_CUSTOM_VERSION=y
-BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
+BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
 BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
 BR2_LINUX_KERNEL_DTS_SUPPORT=y
 BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
-- 
2.17.1

[Buildroot] [PATCH v2 4/4] configs/imx6-sabresd: Bump U-Boot and kernel versions

[Thomas Petazzoni]

On Wed,  9 Oct 2019 14:00:04 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Bump U-Boot to 2019.10 and kernel to 5.3.4 version.
> 
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - None
> 
>  configs/imx6-sabresd_defconfig     | 8 ++++----
>  configs/imx6-sabresd_qt5_defconfig | 8 ++++----
>  2 files changed, 8 insertions(+), 8 deletions(-)
> 
> diff --git a/configs/imx6-sabresd_defconfig b/configs/imx6-sabresd_defconfig
> index c2924b2e39..0d070e47f8 100644
> --- a/configs/imx6-sabresd_defconfig
> +++ b/configs/imx6-sabresd_defconfig
> @@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
>  BR2_ARM_ENABLE_VFP=y
>  BR2_ARM_FPU_VFPV3=y
>  
> -# Linux headers same as kernel, a 4.19 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> +# Linux headers same as kernel, a 5.3 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
>  
>  # System
>  BR2_TARGET_GENERIC_GETTY_PORT="ttymxc0"
> @@ -24,7 +24,7 @@ BR2_TARGET_ROOTFS_EXT2_4=y
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
>  BR2_TARGET_UBOOT_FORMAT_IMG=y
>  BR2_TARGET_UBOOT_SPL=y
>  BR2_TARGET_UBOOT_SPL_NAME="SPL"
> @@ -32,7 +32,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
>  # Kernel
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
>  BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
>  BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"
> diff --git a/configs/imx6-sabresd_qt5_defconfig b/configs/imx6-sabresd_qt5_defconfig
> index 887e53dc21..7a541951ae 100644
> --- a/configs/imx6-sabresd_qt5_defconfig
> +++ b/configs/imx6-sabresd_qt5_defconfig
> @@ -4,8 +4,8 @@ BR2_ARM_ENABLE_NEON=y
>  BR2_ARM_ENABLE_VFP=y
>  BR2_ARM_FPU_VFPV3=y
>  
> -# Linux headers same as kernel, a 4.19 series
> -BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_4_19=y
> +# Linux headers same as kernel, a 5.3 series
> +BR2_PACKAGE_HOST_LINUX_HEADERS_CUSTOM_5_3=y
>  
>  # Additional features needed for packages
>  BR2_TOOLCHAIN_BUILDROOT_WCHAR=y
> @@ -30,7 +30,7 @@ BR2_ROOTFS_OVERLAY="board/freescale/imx6-sabresd/rootfs_overlay"
>  BR2_TARGET_UBOOT=y
>  BR2_TARGET_UBOOT_BOARDNAME="mx6sabresd"
>  BR2_TARGET_UBOOT_CUSTOM_VERSION=y
> -BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2018.05"
> +BR2_TARGET_UBOOT_CUSTOM_VERSION_VALUE="2019.10"
>  BR2_TARGET_UBOOT_FORMAT_IMG=y
>  BR2_TARGET_UBOOT_SPL=y
>  BR2_TARGET_UBOOT_SPL_NAME="SPL"
> @@ -38,7 +38,7 @@ BR2_TARGET_UBOOT_SPL_NAME="SPL"
>  # Kernel
>  BR2_LINUX_KERNEL=y
>  BR2_LINUX_KERNEL_CUSTOM_VERSION=y
> -BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="4.19.16"
> +BR2_LINUX_KERNEL_CUSTOM_VERSION_VALUE="5.3.4"
>  BR2_LINUX_KERNEL_DEFCONFIG="imx_v6_v7"
>  BR2_LINUX_KERNEL_DTS_SUPPORT=y
>  BR2_LINUX_KERNEL_INTREE_DTS_NAME="imx6q-sabresd imx6dl-sabresd imx6qp-sabresd"



-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/4] configs/imx6-sabresd_qt5: Move from mdev to eudev

[Thomas Petazzoni]

On Wed,  9 Oct 2019 14:00:01 -0300
Fabio Estevam <festevam@gmail.com> wrote:

> Since commit cf66a67112cd706d2e7 ("package/glmark2: drm support needs udev")
> udev is needed when the drm flavor is used.
> 
> Move from mdev to eudev in order to fix the following glmark2
> build failure:
> 
> Unknown flavor: . Supported flavors are dispmanx-glesv2, drm-gl,
> drm-glesv2, mir-gl, mir-glesv2, wayland-gl, wayland-glesv2, win32-gl,
> win32-glesv2, x11-gl, x11-glesv2
> 
> Suggested-by: Peter Seiderer <ps.report@gmx.net>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> Changes since v1:
> - Fix Subject and commit log: from mdev to eudev

Applied to master, thanks.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com