[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Fabrice Fontaine]

In order for the luvi version to match what is given by
release-monitoring.org, the 'v' prefix should be encoded in
LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/libnetconf2/libnetconf2.hash | 2 +-
 package/libnetconf2/libnetconf2.mk   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/libnetconf2/libnetconf2.hash b/package/libnetconf2/libnetconf2.hash
index c6d1f5185d..9b78049ffb 100644
--- a/package/libnetconf2/libnetconf2.hash
+++ b/package/libnetconf2/libnetconf2.hash
@@ -1,2 +1,2 @@
-sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452  libnetconf2-v0.12-r2.tar.gz
+sha256 760061fb1c1fe87a2a068d5a9e5affcef280044c5940ef344854e9ea7ec26452  libnetconf2-0.12-r2.tar.gz
 sha256 085122ea91161812dda9cd2f42d8c50ecc3a48cc1a4f15044d86cfc5aa887577  LICENSE
diff --git a/package/libnetconf2/libnetconf2.mk b/package/libnetconf2/libnetconf2.mk
index c3999b3e29..49a6de60a9 100644
--- a/package/libnetconf2/libnetconf2.mk
+++ b/package/libnetconf2/libnetconf2.mk
@@ -4,8 +4,8 @@
 #
 ################################################################################
 
-LIBNETCONF2_VERSION = v0.12-r2
-LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,$(LIBNETCONF2_VERSION))
+LIBNETCONF2_VERSION = 0.12-r2
+LIBNETCONF2_SITE = $(call github,CESNET,libnetconf2,v$(LIBNETCONF2_VERSION))
 LIBNETCONF2_INSTALL_STAGING = YES
 LIBNETCONF2_LICENSE = BSD-3-Clause
 LIBNETCONF2_LICENSE_FILES = LICENSE
-- 
2.23.0

[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Thomas Petazzoni]

On Thu, 24 Oct 2019 20:06:53 +0200
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> In order for the luvi version to match what is given by
> release-monitoring.org, the 'v' prefix should be encoded in
> LIBNETCONF2_SITE and not LIBNETCONF2_VERSION.
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

Sorry for missing this when reviewing/applying those packages.

Perhaps it would make sense to add a check in the check-package logic,
to verify that the version doesn't look like vX.Y.Z ?

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Heiko Thiery]

> Perhaps it would make sense to add a check in the check-package logic,
> to verify that the version doesn't look like vX.Y.Z ?

I would like to take care of that.

[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Thomas Petazzoni]

On Fri, 25 Oct 2019 08:55:01 +0200
Heiko Thiery <heiko.thiery@gmail.com> wrote:

> > Perhaps it would make sense to add a check in the check-package logic,
> > to verify that the version doesn't look like vX.Y.Z ?  
> 
> I would like to take care of that.

Then you can poke around in utils/checkpackagelib/lib_mk.py and see to
add another check. I'm not sure how the check should work exactly, but
I'll let you figure that out :-)

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/libnetconf2: fixup the 'v' prefix in the version

[Fabrice Fontaine]

Dear all,

Le ven. 25 oct. 2019 ? 09:30, Thomas Petazzoni
<thomas.petazzoni@bootlin.com> a ?crit :
>
> On Fri, 25 Oct 2019 08:55:01 +0200
> Heiko Thiery <heiko.thiery@gmail.com> wrote:
>
> > > Perhaps it would make sense to add a check in the check-package logic,
> > > to verify that the version doesn't look like vX.Y.Z ?
> >
> > I would like to take care of that.
>
> Then you can poke around in utils/checkpackagelib/lib_mk.py and see to
> add another check. I'm not sure how the check should work exactly, but
> I'll let you figure that out :-)
At very least, we should just check that there is no v prefix, this is
the only requirement from release-monitoring: "Anitya will
automatically strip this from versions it finds." (see
https://release-monitoring.org/static/docs/user-guide.html#creating-a-new-project).

release-monitoring doesn't require that the version is in the X.Y.Z
form, X-Y-Z or X_Y_Z is allowed (and used in some packages).
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com
Best Regards,

Fabrice