[Buildroot] [PATCH 1/1] package/collectd: add init script for SysV

[Buildroot] [PATCH 1/1] package/collectd: add init script for SysV

[Asaf Kahlon]

Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
---
 package/collectd/S90collectd | 33 +++++++++++++++++++++++++++++++++
 package/collectd/collectd.mk |  5 +++++
 2 files changed, 38 insertions(+)
 create mode 100644 package/collectd/S90collectd

diff --git a/package/collectd/S90collectd b/package/collectd/S90collectd
new file mode 100644
index 0000000000..5caff17238
--- /dev/null
+++ b/package/collectd/S90collectd
@@ -0,0 +1,33 @@
+#!/bin/sh
+
+start() {
+	printf "Starting collectd... "
+	/usr/sbin/collectd
+	[ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+stop() {
+	printf "Stopping collectd... "
+	pkill collectd
+	[ $? = 0 ] && echo "OK" || echo "FAIL"
+}
+restart() {
+	stop
+	start
+}
+
+case "$1" in
+  start)
+	start
+	;;
+  stop)
+	stop
+	;;
+  restart|reload)
+	restart
+	;;
+  *)
+	echo "Usage: $0 {start|stop|restart}"
+	exit 1
+esac
+
+exit $?
diff --git a/package/collectd/collectd.mk b/package/collectd/collectd.mk
index 5d94dec46d..1bce196e7e 100644
--- a/package/collectd/collectd.mk
+++ b/package/collectd/collectd.mk
@@ -218,4 +218,9 @@ define COLLECTD_INSTALL_INIT_SYSTEMD
 		$(TARGET_DIR)/etc/systemd/system/multi-user.target.wants/collectd.service
 endef
 
+define COLLECTD_INSTALL_INIT_SYSV
+	$(INSTALL) -D -m 0755 package/collectd/S90collectd \
+		$(TARGET_DIR)/etc/init.d/S90collectd
+endef
+
 $(eval $(autotools-package))
-- 
2.20.1

[Buildroot] [PATCH 1/1] package/collectd: add init script for SysV

[Thomas Petazzoni]

On Sat, 26 Oct 2019 08:50:13 +0300
Asaf Kahlon <asafka7@gmail.com> wrote:

> Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> ---
>  package/collectd/S90collectd | 33 +++++++++++++++++++++++++++++++++
>  package/collectd/collectd.mk |  5 +++++
>  2 files changed, 38 insertions(+)
>  create mode 100644 package/collectd/S90collectd
> 
> diff --git a/package/collectd/S90collectd b/package/collectd/S90collectd
> new file mode 100644
> index 0000000000..5caff17238
> --- /dev/null
> +++ b/package/collectd/S90collectd
> @@ -0,0 +1,33 @@
> +#!/bin/sh
> +
> +start() {
> +	printf "Starting collectd... "
> +	/usr/sbin/collectd

I think we like to use start-stop-daemon in our init scripts. Any
reason why you're not using start-stop-daemon here ?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH 1/1] package/collectd: add init script for SysV

[Asaf Kahlon]

Hello,

On Sat, Oct 26, 2019 at 9:58 AM Thomas Petazzoni
<thomas.petazzoni@bootlin.com> wrote:
>
> On Sat, 26 Oct 2019 08:50:13 +0300
> Asaf Kahlon <asafka7@gmail.com> wrote:
>
> > Signed-off-by: Asaf Kahlon <asafka7@gmail.com>
> > ---
> >  package/collectd/S90collectd | 33 +++++++++++++++++++++++++++++++++
> >  package/collectd/collectd.mk |  5 +++++
> >  2 files changed, 38 insertions(+)
> >  create mode 100644 package/collectd/S90collectd
> >
> > diff --git a/package/collectd/S90collectd b/package/collectd/S90collectd
> > new file mode 100644
> > index 0000000000..5caff17238
> > --- /dev/null
> > +++ b/package/collectd/S90collectd
> > @@ -0,0 +1,33 @@
> > +#!/bin/sh
> > +
> > +start() {
> > +     printf "Starting collectd... "
> > +     /usr/sbin/collectd
>
> I think we like to use start-stop-daemon in our init scripts. Any
> reason why you're not using start-stop-daemon here ?

Nothing special, I sent a v2.

>
> Best regards,
>
> Thomas
> --
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Regards,
Asaf.