* [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu @ 2019-10-28 21:06 Peter Seiderer 2019-10-28 21:06 ` [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa Peter Seiderer 2019-10-28 23:13 ` [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Arnout Vandecappelle 0 siblings, 2 replies; 6+ messages in thread From: Peter Seiderer @ 2019-10-28 21:06 UTC (permalink / raw) To: buildroot Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- package/qemu/Config.in.host | 1 + package/qemu/qemu.mk | 1 + 2 files changed, 2 insertions(+) diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host index 43d55c88ce..d6b4bf6dd4 100644 --- a/package/qemu/Config.in.host +++ b/package/qemu/Config.in.host @@ -18,6 +18,7 @@ config BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS default y if BR2_sh default y if BR2_sparc default y if BR2_sparc64 + default y if BR2_xtensa default y if BR2_x86_64 depends on !BR2_powerpc_620 && !BR2_powerpc_630 && !BR2_powerpc_970 diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk index 4e39fce8a6..a91f9d3eeb 100644 --- a/package/qemu/qemu.mk +++ b/package/qemu/qemu.mk @@ -209,6 +209,7 @@ HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman # sh4aeb sh4eb # sparc sparc # sparc64 sparc64 +# xtensa xtensa HOST_QEMU_ARCH = $(ARCH) ifeq ($(HOST_QEMU_ARCH),i486) -- 2.23.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa 2019-10-28 21:06 [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Peter Seiderer @ 2019-10-28 21:06 ` Peter Seiderer 2019-10-28 23:14 ` Arnout Vandecappelle 2019-10-28 23:13 ` [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Arnout Vandecappelle 1 sibling, 1 reply; 6+ messages in thread From: Peter Seiderer @ 2019-10-28 21:06 UTC (permalink / raw) To: buildroot Fixes [1]: In file included from double-conversion.h:42, from number_decimalquantity.cpp:19: double-conversion-utils.h:121:2: error: #error Target architecture was not detected as supported by Double-Conversion. #error Target architecture was not detected as supported by Double-Conversion. [1] http://autobuild.buildroot.net/results/fc331ae8e2484be6818f4fc334d3f8c9658fffdc Signed-off-by: Peter Seiderer <ps.report@gmx.net> --- Note: Double-conversion tested with: $ cat div.c double Div_double(double x, double y) { return x / y; } $ cat main.c double Div_double(double x, double y); int main(int argc, char** argv) { double result = Div_double(89255.0, 1e22); if (result == 89255e-22) { printf("correct result %e\n", result); return 1; } else { printf("wrong result %e\n", result); return 0; } } Tested for xtensa (using qemu_xtensa_lx60_defconfig plus BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE): $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c div.c $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c main.c $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -o main main.o div.o $ ./host/bin/qemu-xtensa -L staging main correct result 8.925500e-18 --- ...-double-conversion-enable-for-xtensa.patch | 26 +++++++++++++++++++ 1 file changed, 26 insertions(+) create mode 100644 package/icu/0008-double-conversion-enable-for-xtensa.patch diff --git a/package/icu/0008-double-conversion-enable-for-xtensa.patch b/package/icu/0008-double-conversion-enable-for-xtensa.patch new file mode 100644 index 0000000000..7694ee2293 --- /dev/null +++ b/package/icu/0008-double-conversion-enable-for-xtensa.patch @@ -0,0 +1,26 @@ +From f8f37357fa7cc403848d2bafe6152a707ca3a074 Mon Sep 17 00:00:00 2001 +From: Peter Seiderer <ps.report@gmx.net> +Date: Mon, 28 Oct 2019 21:26:05 +0100 +Subject: [PATCH] double-conversion: enable for xtensa + +Signed-off-by: Peter Seiderer <ps.report@gmx.net> +--- + source/i18n/double-conversion-utils.h | 2 +- + 1 file changed, 1 insertion(+), 1 deletion(-) + +diff --git a/source/i18n/double-conversion-utils.h b/source/i18n/double-conversion-utils.h +index a00037e..b3100ac 100644 +--- a/source/i18n/double-conversion-utils.h ++++ b/source/i18n/double-conversion-utils.h +@@ -104,7 +104,7 @@ int main(int argc, char** argv) { + defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \ + defined(__riscv) || \ + defined(__or1k__) || defined(__arc__) || \ +- defined(__microblaze__) || \ ++ defined(__microblaze__) || defined(__XTENSA__) || \ + defined(__EMSCRIPTEN__) + #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1 + #elif defined(__mc68000__) || \ +-- +2.23.0 + -- 2.23.0 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa 2019-10-28 21:06 ` [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa Peter Seiderer @ 2019-10-28 23:14 ` Arnout Vandecappelle 2019-10-29 21:27 ` Peter Seiderer 0 siblings, 1 reply; 6+ messages in thread From: Arnout Vandecappelle @ 2019-10-28 23:14 UTC (permalink / raw) To: buildroot On 28/10/2019 22:06, Peter Seiderer wrote: > Fixes [1]: Please put the colon immediately after Fixes, so it gets picked up by patchwork. Also, did you send the patch upstream? Applied to master, thanks. Regards, Arnout > > In file included from double-conversion.h:42, > from number_decimalquantity.cpp:19: > double-conversion-utils.h:121:2: error: #error Target architecture was not detected as supported by Double-Conversion. > #error Target architecture was not detected as supported by Double-Conversion. > > [1] http://autobuild.buildroot.net/results/fc331ae8e2484be6818f4fc334d3f8c9658fffdc > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > --- > Note: > > Double-conversion tested with: > > $ cat div.c > double Div_double(double x, double y) { return x / y; } > > $ cat main.c > double Div_double(double x, double y); > > int main(int argc, char** argv) { > double result = Div_double(89255.0, 1e22); > if (result == 89255e-22) { > printf("correct result %e\n", result); > return 1; > } else { > printf("wrong result %e\n", result); > return 0; > } > } > > Tested for xtensa (using qemu_xtensa_lx60_defconfig plus BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE): > > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c div.c > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c main.c > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -o main main.o div.o > > $ ./host/bin/qemu-xtensa -L staging main > correct result 8.925500e-18 > --- > ...-double-conversion-enable-for-xtensa.patch | 26 +++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 package/icu/0008-double-conversion-enable-for-xtensa.patch > > diff --git a/package/icu/0008-double-conversion-enable-for-xtensa.patch b/package/icu/0008-double-conversion-enable-for-xtensa.patch > new file mode 100644 > index 0000000000..7694ee2293 > --- /dev/null > +++ b/package/icu/0008-double-conversion-enable-for-xtensa.patch > @@ -0,0 +1,26 @@ > +From f8f37357fa7cc403848d2bafe6152a707ca3a074 Mon Sep 17 00:00:00 2001 > +From: Peter Seiderer <ps.report@gmx.net> > +Date: Mon, 28 Oct 2019 21:26:05 +0100 > +Subject: [PATCH] double-conversion: enable for xtensa > + > +Signed-off-by: Peter Seiderer <ps.report@gmx.net> > +--- > + source/i18n/double-conversion-utils.h | 2 +- > + 1 file changed, 1 insertion(+), 1 deletion(-) > + > +diff --git a/source/i18n/double-conversion-utils.h b/source/i18n/double-conversion-utils.h > +index a00037e..b3100ac 100644 > +--- a/source/i18n/double-conversion-utils.h > ++++ b/source/i18n/double-conversion-utils.h > +@@ -104,7 +104,7 @@ int main(int argc, char** argv) { > + defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \ > + defined(__riscv) || \ > + defined(__or1k__) || defined(__arc__) || \ > +- defined(__microblaze__) || \ > ++ defined(__microblaze__) || defined(__XTENSA__) || \ > + defined(__EMSCRIPTEN__) > + #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1 > + #elif defined(__mc68000__) || \ > +-- > +2.23.0 > + > -- > 2.23.0 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa 2019-10-28 23:14 ` Arnout Vandecappelle @ 2019-10-29 21:27 ` Peter Seiderer 2019-10-29 21:34 ` Arnout Vandecappelle 0 siblings, 1 reply; 6+ messages in thread From: Peter Seiderer @ 2019-10-29 21:27 UTC (permalink / raw) To: buildroot Hello Arnout, On Tue, 29 Oct 2019 00:14:23 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: > On 28/10/2019 22:06, Peter Seiderer wrote: > > Fixes [1]: > > Please put the colon immediately after Fixes, so it gets picked up by patchwork. O.k, will try to remember next time... > > Also, did you send the patch upstream? Yes: https://github.com/google/double-conversion/pull/119 Regards, Peter > > Applied to master, thanks. > > Regards, > Arnout > > > > > In file included from double-conversion.h:42, > > from number_decimalquantity.cpp:19: > > double-conversion-utils.h:121:2: error: #error Target architecture was not detected as supported by Double-Conversion. > > #error Target architecture was not detected as supported by Double-Conversion. > > > > [1] http://autobuild.buildroot.net/results/fc331ae8e2484be6818f4fc334d3f8c9658fffdc > > > > Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > --- > > Note: > > > > Double-conversion tested with: > > > > $ cat div.c > > double Div_double(double x, double y) { return x / y; } > > > > $ cat main.c > > double Div_double(double x, double y); > > > > int main(int argc, char** argv) { > > double result = Div_double(89255.0, 1e22); > > if (result == 89255e-22) { > > printf("correct result %e\n", result); > > return 1; > > } else { > > printf("wrong result %e\n", result); > > return 0; > > } > > } > > > > Tested for xtensa (using qemu_xtensa_lx60_defconfig plus BR2_PACKAGE_HOST_QEMU_LINUX_USER_MODE): > > > > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c div.c > > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -c main.c > > $ ./host/bin/xtensa-buildroot-linux-uclibc-gcc -o main main.o div.o > > > > $ ./host/bin/qemu-xtensa -L staging main > > correct result 8.925500e-18 > > --- > > ...-double-conversion-enable-for-xtensa.patch | 26 +++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > create mode 100644 package/icu/0008-double-conversion-enable-for-xtensa.patch > > > > diff --git a/package/icu/0008-double-conversion-enable-for-xtensa.patch b/package/icu/0008-double-conversion-enable-for-xtensa.patch > > new file mode 100644 > > index 0000000000..7694ee2293 > > --- /dev/null > > +++ b/package/icu/0008-double-conversion-enable-for-xtensa.patch > > @@ -0,0 +1,26 @@ > > +From f8f37357fa7cc403848d2bafe6152a707ca3a074 Mon Sep 17 00:00:00 2001 > > +From: Peter Seiderer <ps.report@gmx.net> > > +Date: Mon, 28 Oct 2019 21:26:05 +0100 > > +Subject: [PATCH] double-conversion: enable for xtensa > > + > > +Signed-off-by: Peter Seiderer <ps.report@gmx.net> > > +--- > > + source/i18n/double-conversion-utils.h | 2 +- > > + 1 file changed, 1 insertion(+), 1 deletion(-) > > + > > +diff --git a/source/i18n/double-conversion-utils.h b/source/i18n/double-conversion-utils.h > > +index a00037e..b3100ac 100644 > > +--- a/source/i18n/double-conversion-utils.h > > ++++ b/source/i18n/double-conversion-utils.h > > +@@ -104,7 +104,7 @@ int main(int argc, char** argv) { > > + defined(__AARCH64EL__) || defined(__aarch64__) || defined(__AARCH64EB__) || \ > > + defined(__riscv) || \ > > + defined(__or1k__) || defined(__arc__) || \ > > +- defined(__microblaze__) || \ > > ++ defined(__microblaze__) || defined(__XTENSA__) || \ > > + defined(__EMSCRIPTEN__) > > + #define DOUBLE_CONVERSION_CORRECT_DOUBLE_OPERATIONS 1 > > + #elif defined(__mc68000__) || \ > > +-- > > +2.23.0 > > + > > -- > > 2.23.0 > > > > _______________________________________________ > > buildroot mailing list > > buildroot at busybox.net > > http://lists.busybox.net/mailman/listinfo/buildroot > > ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa 2019-10-29 21:27 ` Peter Seiderer @ 2019-10-29 21:34 ` Arnout Vandecappelle 0 siblings, 0 replies; 6+ messages in thread From: Arnout Vandecappelle @ 2019-10-29 21:34 UTC (permalink / raw) To: buildroot On 29/10/2019 22:27, Peter Seiderer wrote: > Hello Arnout, > > On Tue, 29 Oct 2019 00:14:23 +0100, Arnout Vandecappelle <arnout@mind.be> wrote: > >> On 28/10/2019 22:06, Peter Seiderer wrote: >>> Fixes [1]: >> >> Please put the colon immediately after Fixes, so it gets picked up by patchwork. > > O.k, will try to remember next time... > >> >> Also, did you send the patch upstream? > > Yes: https://github.com/google/double-conversion/pull/119 It's convenient if you mention that URL in the patch message. Or if you only send it later, mention it in a reply to the submission mail. Regards, Arnout ^ permalink raw reply [flat|nested] 6+ messages in thread
* [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu 2019-10-28 21:06 [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Peter Seiderer 2019-10-28 21:06 ` [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa Peter Seiderer @ 2019-10-28 23:13 ` Arnout Vandecappelle 1 sibling, 0 replies; 6+ messages in thread From: Arnout Vandecappelle @ 2019-10-28 23:13 UTC (permalink / raw) To: buildroot On 28/10/2019 22:06, Peter Seiderer wrote: > Signed-off-by: Peter Seiderer <ps.report@gmx.net> Applied to master, thanks. I didn't understand at first why xtensa was not yet enabled. But it turns out that our xtensa support was added a few months after qemu was added, and nobody bothered to update the list of supported architectures. Regards, Arnout > --- > package/qemu/Config.in.host | 1 + > package/qemu/qemu.mk | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/package/qemu/Config.in.host b/package/qemu/Config.in.host > index 43d55c88ce..d6b4bf6dd4 100644 > --- a/package/qemu/Config.in.host > +++ b/package/qemu/Config.in.host > @@ -18,6 +18,7 @@ config BR2_PACKAGE_HOST_QEMU_ARCH_SUPPORTS > default y if BR2_sh > default y if BR2_sparc > default y if BR2_sparc64 > + default y if BR2_xtensa > default y if BR2_x86_64 > depends on !BR2_powerpc_620 && !BR2_powerpc_630 && !BR2_powerpc_970 > > diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk > index 4e39fce8a6..a91f9d3eeb 100644 > --- a/package/qemu/qemu.mk > +++ b/package/qemu/qemu.mk > @@ -209,6 +209,7 @@ HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman > # sh4aeb sh4eb > # sparc sparc > # sparc64 sparc64 > +# xtensa xtensa > > HOST_QEMU_ARCH = $(ARCH) > ifeq ($(HOST_QEMU_ARCH),i486) > -- > 2.23.0 > > _______________________________________________ > buildroot mailing list > buildroot at busybox.net > http://lists.busybox.net/mailman/listinfo/buildroot > ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-10-29 21:34 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-10-28 21:06 [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Peter Seiderer 2019-10-28 21:06 ` [Buildroot] [PATCH v1 2/2] package/icu: fix double conversion compile for xtensa Peter Seiderer 2019-10-28 23:14 ` Arnout Vandecappelle 2019-10-29 21:27 ` Peter Seiderer 2019-10-29 21:34 ` Arnout Vandecappelle 2019-10-28 23:13 ` [Buildroot] [PATCH v1 1/2] package/qemu: enable xtensa support for host-qemu Arnout Vandecappelle
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox