From: Yann E. MORIN <yann.morin.1998@free.fr>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support
Date: Tue, 5 Nov 2019 19:33:43 +0100 [thread overview]
Message-ID: <20191105183343.GL2710@scaer> (raw)
In-Reply-To: <20191105094215.4580-1-skif@skif-web.ru>
Alexey, All,
On 2019-11-05 12:42 +0300, Alexey Lukyanchuk spake thusly:
> Signed-off-by: Alexey Lukyanchuk <skif@skif-web.ru>
> ---
> package/freerdp/freerdp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
> index 0f32ff4718..931fa49477 100644
> --- a/package/freerdp/freerdp.mk
> +++ b/package/freerdp/freerdp.mk
> @@ -51,6 +51,7 @@ endif
>
> ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
> FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=ON
This one should be removed, since it is in fact not used, and since ...
> +FREERDP_CONF_OPTS += -DWITH_PULSE=ON
... this is the ciorrect variable, and ...
> FREERDP_DEPENDENCIES += pulseaudio
> else
> FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=OFF
... it should also be used here too.
I've applied, fixed, expanded the commit log, and pushed now. Thanks!
Regards,
Yann E. MORIN.
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
next prev parent reply other threads:[~2019-11-05 18:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-05 9:42 [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support Alexey Lukyanchuk
2019-11-05 18:33 ` Yann E. MORIN [this message]
2019-11-07 7:43 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191105183343.GL2710@scaer \
--to=yann.morin.1998@free.fr \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox