* [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support
@ 2019-11-05 9:42 Alexey Lukyanchuk
2019-11-05 18:33 ` Yann E. MORIN
2019-11-07 7:43 ` Peter Korsgaard
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Lukyanchuk @ 2019-11-05 9:42 UTC (permalink / raw)
To: buildroot
Signed-off-by: Alexey Lukyanchuk <skif@skif-web.ru>
---
package/freerdp/freerdp.mk | 1 +
1 file changed, 1 insertion(+)
diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
index 0f32ff4718..931fa49477 100644
--- a/package/freerdp/freerdp.mk
+++ b/package/freerdp/freerdp.mk
@@ -51,6 +51,7 @@ endif
ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=ON
+FREERDP_CONF_OPTS += -DWITH_PULSE=ON
FREERDP_DEPENDENCIES += pulseaudio
else
FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=OFF
--
2.21.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support
2019-11-05 9:42 [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support Alexey Lukyanchuk
@ 2019-11-05 18:33 ` Yann E. MORIN
2019-11-07 7:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Yann E. MORIN @ 2019-11-05 18:33 UTC (permalink / raw)
To: buildroot
Alexey, All,
On 2019-11-05 12:42 +0300, Alexey Lukyanchuk spake thusly:
> Signed-off-by: Alexey Lukyanchuk <skif@skif-web.ru>
> ---
> package/freerdp/freerdp.mk | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/package/freerdp/freerdp.mk b/package/freerdp/freerdp.mk
> index 0f32ff4718..931fa49477 100644
> --- a/package/freerdp/freerdp.mk
> +++ b/package/freerdp/freerdp.mk
> @@ -51,6 +51,7 @@ endif
>
> ifeq ($(BR2_PACKAGE_PULSEAUDIO),y)
> FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=ON
This one should be removed, since it is in fact not used, and since ...
> +FREERDP_CONF_OPTS += -DWITH_PULSE=ON
... this is the ciorrect variable, and ...
> FREERDP_DEPENDENCIES += pulseaudio
> else
> FREERDP_CONF_OPTS += -DWITH_PULSEAUDIO=OFF
... it should also be used here too.
I've applied, fixed, expanded the commit log, and pushed now. Thanks!
Regards,
Yann E. MORIN.
> --
> 2.21.0
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
--
.-----------------.--------------------.------------------.--------------------.
| Yann E. MORIN | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software Designer | \ / CAMPAIGN | ___ |
| +33 561 099 427 `------------.-------: X AGAINST | \e/ There is no |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL | v conspiracy. |
'------------------------------^-------^------------------^--------------------'
^ permalink raw reply [flat|nested] 3+ messages in thread
* [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support
2019-11-05 9:42 [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support Alexey Lukyanchuk
2019-11-05 18:33 ` Yann E. MORIN
@ 2019-11-07 7:43 ` Peter Korsgaard
1 sibling, 0 replies; 3+ messages in thread
From: Peter Korsgaard @ 2019-11-07 7:43 UTC (permalink / raw)
To: buildroot
>>>>> "Alexey" == Alexey Lukyanchuk <skif@skif-web.ru> writes:
> Signed-off-by: Alexey Lukyanchuk <skif@skif-web.ru>
Committed to 2019.02.x and 2019.08.x, thanks.
--
Bye, Peter Korsgaard
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-11-07 7:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-05 9:42 [Buildroot] [PATCH 1/1] package/freerdp: fix pulseaudio support Alexey Lukyanchuk
2019-11-05 18:33 ` Yann E. MORIN
2019-11-07 7:43 ` Peter Korsgaard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox