From: Avi Shukron <avraham.shukron@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package
Date: Mon, 11 Nov 2019 23:31:45 +0200 [thread overview]
Message-ID: <20191111213154.19409-1-avraham.shukron@gmail.com> (raw)
ninja depends on python3 specifically, but the configure.py file
simply uses "env python". Where no python is selected for the target
you simply won't get a python symlink in $(HOST_DIR)/usr/bin, so the
configure.py script fails to run since it can't find "python".
Notice that in order to reproduce the issue, you must not have
python2 installed on your host machine.
Signed-off-by: Avi Shukron <avraham.shukron@gmail.com>
---
package/ninja/ninja.mk | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/package/ninja/ninja.mk b/package/ninja/ninja.mk
index 4897012150..281cd70412 100644
--- a/package/ninja/ninja.mk
+++ b/package/ninja/ninja.mk
@@ -17,7 +17,7 @@ NINJA_LICENSE_FILES = COPYING
HOST_NINJA_DEPENDENCIES = host-python3
define HOST_NINJA_BUILD_CMDS
- (cd $(@D); ./configure.py --bootstrap)
+ (cd $(@D); $(HOST_DIR)/bin/python3 configure.py --bootstrap)
endef
define HOST_NINJA_INSTALL_CMDS
--
2.17.1
next reply other threads:[~2019-11-11 21:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-11 21:31 Avi Shukron [this message]
2019-11-11 21:31 ` [Buildroot] [PATCH v2 2/2] package/qemu: add host-python as an explicit dependency Avi Shukron
2019-11-12 21:05 ` Thomas Petazzoni
2019-11-13 20:22 ` Avraham Shukron
2019-11-15 21:08 ` Thomas Petazzoni
2019-11-15 22:04 ` Avraham Shukron
2019-11-15 22:51 ` Thomas Petazzoni
2019-11-16 11:59 ` Avraham Shukron
2019-11-16 13:49 ` [Buildroot] [PATCH v4] package/qemu: add host-python3 " Avi Shukron
2019-11-15 20:19 ` [Buildroot] [PATCH v3] package/qemu: add host-python " Avi Shukron
2019-11-18 22:22 ` Thomas Petazzoni
2019-11-12 21:04 ` [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package Thomas Petazzoni
2019-11-18 13:00 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191111213154.19409-1-avraham.shukron@gmail.com \
--to=avraham.shukron@gmail.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox