Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Avi Shukron <avraham.shukron@gmail.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3] package/qemu: add host-python as an explicit dependency
Date: Fri, 15 Nov 2019 22:19:00 +0200	[thread overview]
Message-ID: <20191115201908.8216-1-avraham.shukron@gmail.com> (raw)
In-Reply-To: <20191112220534.531a470f@windsurf>

qemu requires python in its configre script. Yet host-python was
not listed as one of the package's dependencies. If no other package
requested host-python, then configuring this package will fail since
it won't find any executable named python in the host dir.

In order to reproduce this issue you must not have python2 installed
on your host machine.

Signed-off-by: Avi Shukron <avraham.shukron@gmail.com>
---
Changes v2->v3:
- Depend directly on host-python3, since it is already a transitive
  dependency of qemu
---
 package/qemu/qemu.mk | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/package/qemu/qemu.mk b/package/qemu/qemu.mk
index a91f9d3eeb..c46e41919f 100644
--- a/package/qemu/qemu.mk
+++ b/package/qemu/qemu.mk
@@ -20,8 +20,7 @@ QEMU_LICENSE_FILES = COPYING COPYING.LIB
 
 #-------------------------------------------------------------
 # Target-qemu
-
-QEMU_DEPENDENCIES = host-pkgconf libglib2 zlib pixman
+QEMU_DEPENDENCIES = host-pkgconf libglib2 zlib pixman host-python3
 
 # Need the LIBS variable because librt and libm are
 # not automatically pulled. :-(
@@ -182,7 +181,7 @@ $(eval $(generic-package))
 #-------------------------------------------------------------
 # Host-qemu
 
-HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman
+HOST_QEMU_DEPENDENCIES = host-pkgconf host-zlib host-libglib2 host-pixman host-python3
 
 #       BR ARCH         qemu
 #       -------         ----
-- 
2.17.1

  parent reply	other threads:[~2019-11-15 20:19 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-11 21:31 [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package Avi Shukron
2019-11-11 21:31 ` [Buildroot] [PATCH v2 2/2] package/qemu: add host-python as an explicit dependency Avi Shukron
2019-11-12 21:05   ` Thomas Petazzoni
2019-11-13 20:22     ` Avraham Shukron
2019-11-15 21:08       ` Thomas Petazzoni
2019-11-15 22:04         ` Avraham Shukron
2019-11-15 22:51           ` Thomas Petazzoni
2019-11-16 11:59             ` Avraham Shukron
2019-11-16 13:49               ` [Buildroot] [PATCH v4] package/qemu: add host-python3 " Avi Shukron
2019-11-15 20:19     ` Avi Shukron [this message]
2019-11-18 22:22       ` [Buildroot] [PATCH v3] package/qemu: add host-python " Thomas Petazzoni
2019-11-12 21:04 ` [Buildroot] [PATCH v2 1/2] package/ninja: invoke python3 explicitly to configure the package Thomas Petazzoni
2019-11-18 13:00 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191115201908.8216-1-avraham.shukron@gmail.com \
    --to=avraham.shukron@gmail.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox