[Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension

Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
       [not found] <1573221183-25905-1-git-send-email-michael.schenk@noser.com>
@ 2019-11-11  8:51 ` Sergey Matyukevich
       [not found]   ` <DB7PR04MB500309181A711B70FEB5B58181740@DB7PR04MB5003.eurprd04.prod.outlook.com>
  0 siblings, 1 reply; 6+ messages in thread
From: Sergey Matyukevich @ 2019-11-11  8:51 UTC (permalink / raw)
  To: buildroot

> Signed-off-by: Michael Schenk <michael.schenk@noser.com>
> ---
>  boot/arm-trusted-firmware/Config.in               | 7 +++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)

...

>  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> -	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
> +	$(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
> +		cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
> +	)
>  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
>  	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
>  endef

Looks good to me: Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>

For better understanding of the rationale behind the change, it would
be great if you could share some technical details of your use-case.

Regards,
Sergey

^ permalink raw reply	[flat|nested] 6+ messages in thread

[parent not found: <DB7PR04MB500309181A711B70FEB5B58181740@DB7PR04MB5003.eurprd04.prod.outlook.com>]

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
       [not found]   ` <DB7PR04MB500309181A711B70FEB5B58181740@DB7PR04MB5003.eurprd04.prod.outlook.com>
@ 2019-11-12 20:17     ` Sergey Matyukevich
  2019-11-12 20:26       ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Sergey Matyukevich @ 2019-11-12 20:17 UTC (permalink / raw)
  To: buildroot

> Hi,
> 
> recently I've starting to make a little playground for using STM32MP1 (https://github.com/schenkmi/buildroot-op-tee-stm32mp1) with OP-TEE build with Buildroot. The proposed change is for platforms like the STM32MP1 which add some special headers to the final binary and add a different file ending. In the STM32MP1 the ATF binaries are called *.stm32. A similar change already exist for U-BOOT and optee-os but was missing for ATF.

Hi Michael,

Thanks for clarification. BTW, for some reason I don't see your patch
in buildroot patchwork system. Though I am not sure if this is a
problem for maintainers...

Regards,
Sergey

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
  2019-11-12 20:17     ` Sergey Matyukevich
@ 2019-11-12 20:26       ` Thomas Petazzoni
  0 siblings, 0 replies; 6+ messages in thread
From: Thomas Petazzoni @ 2019-11-12 20:26 UTC (permalink / raw)
  To: buildroot

On Tue, 12 Nov 2019 23:17:12 +0300
Sergey Matyukevich <geomatsi@gmail.com> wrote:

> > Hi,
> > 
> > recently I've starting to make a little playground for using STM32MP1 (https://github.com/schenkmi/buildroot-op-tee-stm32mp1) with OP-TEE build with Buildroot. The proposed change is for platforms like the STM32MP1 which add some special headers to the final binary and add a different file ending. In the STM32MP1 the ATF binaries are called *.stm32. A similar change already exist for U-BOOT and optee-os but was missing for ATF.  
> 
> Hi Michael,
> 
> Thanks for clarification. BTW, for some reason I don't see your patch
> in buildroot patchwork system. Though I am not sure if this is a
> problem for maintainers...

In fact, it seems like the initial e-mail from Michael didn't made it
to the list at all. At least, I don't see it in my local archives of
the mailing list.

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
@ 2019-11-14 13:29 Schenk Michael
  2019-11-15  7:29 ` Sergey Matyukevich
  2019-11-15  7:36 ` Yegor Yefremov
  0 siblings, 2 replies; 6+ messages in thread
From: Schenk Michael @ 2019-11-14 13:29 UTC (permalink / raw)
  To: buildroot

Signed-off-by: Michael Schenk <michael.schenk@noser.com>
---
 boot/arm-trusted-firmware/Config.in               | 7 +++++++
 boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
 2 files changed, 10 insertions(+), 1 deletion(-)

diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
index beb95fb..78c0301 100644
--- a/boot/arm-trusted-firmware/Config.in
+++ b/boot/arm-trusted-firmware/Config.in
@@ -135,4 +135,11 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
 	help
 	  Enable this option to build ATF with DEBUG=1.
 
+config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
+	string "Binary boot images"
+	default "*.bin"
+	help
+	  Names of generated image files that are installed in the
+	  output images/ directory.
+
 endif
diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
index a7814e5..e528686 100644
--- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
+++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
@@ -146,7 +146,9 @@ define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
 endef
 
 define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
-	cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
+	$(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
+		cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
+	)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
 	$(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
 endef
-- 
2.7.4

^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
  2019-11-14 13:29 Schenk Michael
@ 2019-11-15  7:29 ` Sergey Matyukevich
  2019-11-15  7:36 ` Yegor Yefremov
  1 sibling, 0 replies; 6+ messages in thread
From: Sergey Matyukevich @ 2019-11-15  7:29 UTC (permalink / raw)
  To: buildroot

> Signed-off-by: Michael Schenk <michael.schenk@noser.com>
> ---
>  boot/arm-trusted-firmware/Config.in               | 7 +++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)

Reviewed-by: Sergey Matyukevich <geomatsi@gmail.com>

Regards,
Sergey

^ permalink raw reply	[flat|nested] 6+ messages in thread

* [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension
  2019-11-14 13:29 Schenk Michael
  2019-11-15  7:29 ` Sergey Matyukevich
@ 2019-11-15  7:36 ` Yegor Yefremov
  1 sibling, 0 replies; 6+ messages in thread
From: Yegor Yefremov @ 2019-11-15  7:36 UTC (permalink / raw)
  To: buildroot

Hi Michael,

could you fix the patch title/commit log?

Title: add pattern based copy for ATF as already used for u-boot

Commit log: This adds support for different platforms where the
binaries have different extensions.


On Thu, Nov 14, 2019 at 4:02 PM Schenk Michael <michael.schenk@noser.com> wrote:
>
> Signed-off-by: Michael Schenk <michael.schenk@noser.com>
> ---
>  boot/arm-trusted-firmware/Config.in               | 7 +++++++
>  boot/arm-trusted-firmware/arm-trusted-firmware.mk | 4 +++-
>  2 files changed, 10 insertions(+), 1 deletion(-)
>
> diff --git a/boot/arm-trusted-firmware/Config.in b/boot/arm-trusted-firmware/Config.in
> index beb95fb..78c0301 100644
> --- a/boot/arm-trusted-firmware/Config.in
> +++ b/boot/arm-trusted-firmware/Config.in
> @@ -135,4 +135,11 @@ config BR2_TARGET_ARM_TRUSTED_FIRMWARE_DEBUG
>         help
>           Enable this option to build ATF with DEBUG=1.
>
> +config BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES
> +       string "Binary boot images"
> +       default "*.bin"
> +       help
> +         Names of generated image files that are installed in the
> +         output images/ directory.

Please precise the list type. Is it space separated or comma separated.

Regards,
Yegor

> +
>  endif
> diff --git a/boot/arm-trusted-firmware/arm-trusted-firmware.mk b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> index a7814e5..e528686 100644
> --- a/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> +++ b/boot/arm-trusted-firmware/arm-trusted-firmware.mk
> @@ -146,7 +146,9 @@ define ARM_TRUSTED_FIRMWARE_BUILD_CMDS
>  endef
>
>  define ARM_TRUSTED_FIRMWARE_INSTALL_IMAGES_CMDS
> -       cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/*.bin $(BINARIES_DIR)/
> +       $(foreach f,$(call qstrip,$(BR2_TARGET_ARM_TRUSTED_FIRMWARE_IMAGES)), \
> +               cp -dpf $(ARM_TRUSTED_FIRMWARE_IMG_DIR)/$(f) $(BINARIES_DIR)/
> +       )
>         $(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL)
>         $(ARM_TRUSTED_FIRMWARE_BL31_UBOOT_INSTALL_ELF)
>  endef
> --
> 2.7.4
>
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-11-15  7:36 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <1573221183-25905-1-git-send-email-michael.schenk@noser.com>
2019-11-11  8:51 ` [Buildroot] [PATCH 1/1] add pattern based copy for ATF as already used for u-boot. This add support for different platforms where the binaries have different extension Sergey Matyukevich
     [not found]   ` <DB7PR04MB500309181A711B70FEB5B58181740@DB7PR04MB5003.eurprd04.prod.outlook.com>
2019-11-12 20:17     ` Sergey Matyukevich
2019-11-12 20:26       ` Thomas Petazzoni
2019-11-14 13:29 Schenk Michael
2019-11-15  7:29 ` Sergey Matyukevich
2019-11-15  7:36 ` Yegor Yefremov

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox