Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Koen Martens <gmc@sonologic.nl>
To: buildroot@busybox.net
Subject: [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ?
Date: Sun, 17 Nov 2019 15:02:08 +0100	[thread overview]
Message-ID: <20191117140208.GE13372@coltrane> (raw)
In-Reply-To: <2ca350a6-134b-6149-dd4f-e7cbd790e115@mind.be>

On Sun, Nov 17, 2019 at 02:45:13PM +0100, Arnout Vandecappelle wrote:
> On 17/11/2019 14:37, Koen Martens wrote:
> > SDL2 seems to require shared library support (in that it includes
> > dlfcn.h somewhere along the line), however this is not declared
> > in package/sdl2/Config.in.
> 
>  Yes it is, line 3 of this file has:
> 
> depends on !BR2_STATIC_LIBS
> 
> (not static means dynamic. It's put that way because it covers both the SHARED
> and the STATIC_SHARED options.)
> 
> > In fact, there is an odd comment 
> > at the bottom of that file:
> > 
> > comment "sdl2 needs a toolchain w/ dynamic library"
> >     depends on BR2_STATIC_LIBS
> > 
> > Isn't it contradictory to say 'needs dynamic library' but then depend
> > on BR2_STATIC_LIBS??
> 
>  The *comment* is only shown when you don't have dynamic library support. The
> early condition hides the package completely in menuconfig when dynamic library
> is not available, so it would look as if Buildroot doesn't have this package.
> That's why we add the comment (and to make it easy for people to see what htey
> need to change in the toolchain to have support for it).

Ah, right, makes sense. Thanks for pointing that out. I'm still not sure
why I then need to depend on !BR2_STATIC_LIBS in a package that depends on
SDL2. Shouldn't SDL2 depending on !BR2_STATIC_LIBS be enough to not build
linuxconsoletools with the force-feedback utilities by test-pkg ?

Maybe i'm missing something obvious again, but I'm not in the habbit of
working on buildroot daily anymore and am recovering from a flu, so I might
not be thinking straight atm.

Cheers,

Koen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191117/33eb0c8b/attachment.asc>

  reply	other threads:[~2019-11-17 14:02 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-17 13:37 [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ? Koen Martens
2019-11-17 13:45 ` Arnout Vandecappelle
2019-11-17 14:02   ` Koen Martens [this message]
2019-11-17 14:15     ` Arnout Vandecappelle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20191117140208.GE13372@coltrane \
    --to=gmc@sonologic.nl \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox