Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ?
@ 2019-11-17 13:37 Koen Martens
  2019-11-17 13:45 ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Koen Martens @ 2019-11-17 13:37 UTC (permalink / raw)
  To: buildroot

Hi,

I'm updating linuxconsoletools. However, I'm running into issues
with test-pkg. There is an optional binary for force-feedback 
testing that requires SDL2.

SDL2 seems to require shared library support (in that it includes
dlfcn.h somewhere along the line), however this is not declared
in package/sdl2/Config.in. In fact, there is an odd comment 
at the bottom of that file:

comment "sdl2 needs a toolchain w/ dynamic library"
    depends on BR2_STATIC_LIBS

Isn't it contradictory to say 'needs dynamic library' but then depend
on BR2_STATIC_LIBS??

As a work-around, in my linuxconsoletools Config.in i've added
'depends on BR2_SHARED_LIBS' to prevent the build failures
with test-pkg, but that feels like an ugly way to fix this. It
feels like SDL2 should declare its dependency on BR2_SHARED_LIBS
instead of me declaring it?

This has left me a bit confused.

Cheers,

Koen

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ?
  2019-11-17 13:37 [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ? Koen Martens
@ 2019-11-17 13:45 ` Arnout Vandecappelle
  2019-11-17 14:02   ` Koen Martens
  0 siblings, 1 reply; 4+ messages in thread
From: Arnout Vandecappelle @ 2019-11-17 13:45 UTC (permalink / raw)
  To: buildroot



On 17/11/2019 14:37, Koen Martens wrote:
> Hi,
> 
> I'm updating linuxconsoletools. However, I'm running into issues
> with test-pkg. There is an optional binary for force-feedback 
> testing that requires SDL2.
> 
> SDL2 seems to require shared library support (in that it includes
> dlfcn.h somewhere along the line), however this is not declared
> in package/sdl2/Config.in.

 Yes it is, line 3 of this file has:

depends on !BR2_STATIC_LIBS

(not static means dynamic. It's put that way because it covers both the SHARED
and the STATIC_SHARED options.)

> In fact, there is an odd comment 
> at the bottom of that file:
> 
> comment "sdl2 needs a toolchain w/ dynamic library"
>     depends on BR2_STATIC_LIBS
> 
> Isn't it contradictory to say 'needs dynamic library' but then depend
> on BR2_STATIC_LIBS??

 The *comment* is only shown when you don't have dynamic library support. The
early condition hides the package completely in menuconfig when dynamic library
is not available, so it would look as if Buildroot doesn't have this package.
That's why we add the comment (and to make it easy for people to see what htey
need to change in the toolchain to have support for it).


> As a work-around, in my linuxconsoletools Config.in i've added
> 'depends on BR2_SHARED_LIBS' to prevent the build failures

 You should add this dependency to BR2_PACKAGE_LINUXCONSOLETOOLS_FORCEFEEDBACK
only, and you should make it 'depends on !BR2_STATIC_LIBS'. Also, you should add
a comment like sdl2 has. So, you should end up with:

config BR2_PACKAGE_LINUXCONSOLETOOLS_FORCEFEEDBACK
	bool "force-feedback utilities"
	depends on !BR2_STATIC_LIBS
	select BR2_PACKAGE_SDL2
	help
	  Build force-feedback driver utilities (fftest,
	  ffmvforce, ffset, ffcfstress).

comment "force-feedback utilities needs a toolchain w/ dynamic library"
	depends on BR2_STATIC_LIBS

 Regards,
 Arnout

> with test-pkg, but that feels like an ugly way to fix this. It
> feels like SDL2 should declare its dependency on BR2_SHARED_LIBS
> instead of me declaring it?
> 
> This has left me a bit confused.
> 
> Cheers,
> 
> Koen
> 
> _______________________________________________
> buildroot mailing list
> buildroot at busybox.net
> http://lists.busybox.net/mailman/listinfo/buildroot
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ?
  2019-11-17 13:45 ` Arnout Vandecappelle
@ 2019-11-17 14:02   ` Koen Martens
  2019-11-17 14:15     ` Arnout Vandecappelle
  0 siblings, 1 reply; 4+ messages in thread
From: Koen Martens @ 2019-11-17 14:02 UTC (permalink / raw)
  To: buildroot

On Sun, Nov 17, 2019 at 02:45:13PM +0100, Arnout Vandecappelle wrote:
> On 17/11/2019 14:37, Koen Martens wrote:
> > SDL2 seems to require shared library support (in that it includes
> > dlfcn.h somewhere along the line), however this is not declared
> > in package/sdl2/Config.in.
> 
>  Yes it is, line 3 of this file has:
> 
> depends on !BR2_STATIC_LIBS
> 
> (not static means dynamic. It's put that way because it covers both the SHARED
> and the STATIC_SHARED options.)
> 
> > In fact, there is an odd comment 
> > at the bottom of that file:
> > 
> > comment "sdl2 needs a toolchain w/ dynamic library"
> >     depends on BR2_STATIC_LIBS
> > 
> > Isn't it contradictory to say 'needs dynamic library' but then depend
> > on BR2_STATIC_LIBS??
> 
>  The *comment* is only shown when you don't have dynamic library support. The
> early condition hides the package completely in menuconfig when dynamic library
> is not available, so it would look as if Buildroot doesn't have this package.
> That's why we add the comment (and to make it easy for people to see what htey
> need to change in the toolchain to have support for it).

Ah, right, makes sense. Thanks for pointing that out. I'm still not sure
why I then need to depend on !BR2_STATIC_LIBS in a package that depends on
SDL2. Shouldn't SDL2 depending on !BR2_STATIC_LIBS be enough to not build
linuxconsoletools with the force-feedback utilities by test-pkg ?

Maybe i'm missing something obvious again, but I'm not in the habbit of
working on buildroot daily anymore and am recovering from a flu, so I might
not be thinking straight atm.

Cheers,

Koen

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 195 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20191117/33eb0c8b/attachment.asc>

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ?
  2019-11-17 14:02   ` Koen Martens
@ 2019-11-17 14:15     ` Arnout Vandecappelle
  0 siblings, 0 replies; 4+ messages in thread
From: Arnout Vandecappelle @ 2019-11-17 14:15 UTC (permalink / raw)
  To: buildroot



On 17/11/2019 15:02, Koen Martens wrote:
> On Sun, Nov 17, 2019 at 02:45:13PM +0100, Arnout Vandecappelle wrote:
>> On 17/11/2019 14:37, Koen Martens wrote:
>>> SDL2 seems to require shared library support (in that it includes
>>> dlfcn.h somewhere along the line), however this is not declared
>>> in package/sdl2/Config.in.
>>
>>  Yes it is, line 3 of this file has:
>>
>> depends on !BR2_STATIC_LIBS
>>
>> (not static means dynamic. It's put that way because it covers both the SHARED
>> and the STATIC_SHARED options.)
>>
>>> In fact, there is an odd comment 
>>> at the bottom of that file:
>>>
>>> comment "sdl2 needs a toolchain w/ dynamic library"
>>>     depends on BR2_STATIC_LIBS
>>>
>>> Isn't it contradictory to say 'needs dynamic library' but then depend
>>> on BR2_STATIC_LIBS??
>>
>>  The *comment* is only shown when you don't have dynamic library support. The
>> early condition hides the package completely in menuconfig when dynamic library
>> is not available, so it would look as if Buildroot doesn't have this package.
>> That's why we add the comment (and to make it easy for people to see what htey
>> need to change in the toolchain to have support for it).
> 
> Ah, right, makes sense. Thanks for pointing that out. I'm still not sure
> why I then need to depend on !BR2_STATIC_LIBS in a package that depends on
> SDL2. Shouldn't SDL2 depending on !BR2_STATIC_LIBS be enough to not build
> linuxconsoletools with the force-feedback utilities by test-pkg ?

 That would indeed be a lot better, but unfortunately Kconfig doesn't allow it.
It is not able to infer the dependency from the `select` line. And of course,
the comment would be even more impossible to infer.

 Regards,
 Arnout


> Maybe i'm missing something obvious again, but I'm not in the habbit of
> working on buildroot daily anymore and am recovering from a flu, so I might
> not be thinking straight atm.
> 
> Cheers,
> 
> Koen
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2019-11-17 14:15 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-11-17 13:37 [Buildroot] SDL2 depends on shared libraries, but Config.in depends on BR2_STATIC_LIBS ? Koen Martens
2019-11-17 13:45 ` Arnout Vandecappelle
2019-11-17 14:02   ` Koen Martens
2019-11-17 14:15     ` Arnout Vandecappelle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox