From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2,1/4] package/spice: disable tests
Date: Mon, 18 Nov 2019 22:47:03 +0100 [thread overview]
Message-ID: <20191118224703.3fb65955@windsurf.home> (raw)
In-Reply-To: <20191117164452.5361-1-fontaine.fabrice@gmail.com>
On Sun, 17 Nov 2019 17:44:49 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
> By disabling tests, we'll remove the optional gdk-pixbuf dependency
>
> Fixes:
> - http://autobuild.buildroot.org/results/96c786f85d35f33508e9c71778043d16b87f72cd
>
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
> Changes v1 -> v2 (after review of Yann E. Morin):
> - Disable tests instead of adding and fixing gdk-pixbuf optional
> dependency
I've applied to next. However, your patch to upstream is not really
complete, or at least an additional patch is needed: when tests are
enabled, their configure.ac script should check if gdk-pixbuf is
available. And if it's not available, it should bail out, or disable
tests, but not allow the configure process to complete, and then have a
build failure when compiling.
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-18 21:47 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-17 16:44 [Buildroot] [PATCH v2,1/4] package/spice: disable tests Fabrice Fontaine
2019-11-17 16:44 ` [Buildroot] [PATCH v2,2/4] package/celt051: needs dynamic library Fabrice Fontaine
2019-11-23 13:38 ` [Buildroot] [PATCH v2, 2/4] " Peter Korsgaard
2019-11-23 16:05 ` Fabrice Fontaine
2020-01-23 22:23 ` Arnout Vandecappelle
2020-01-24 18:14 ` Yann E. MORIN
2020-01-27 16:22 ` Arnout Vandecappelle
2020-01-27 16:25 ` Fabrice Fontaine
2019-11-17 16:44 ` [Buildroot] [PATCH v2, 3/4] package/spice-protocol: bump to version 0.14.0 Fabrice Fontaine
2019-11-23 13:33 ` Peter Korsgaard
2019-12-03 9:49 ` Peter Korsgaard
2019-12-03 10:08 ` Baruch Siach
2019-12-03 12:15 ` Peter Korsgaard
2019-11-17 16:44 ` [Buildroot] [PATCH v2, 4/4] package/spice: security bump to version 0.14.2 Fabrice Fontaine
2019-11-23 13:33 ` Peter Korsgaard
2019-12-03 9:49 ` Peter Korsgaard
2019-11-18 21:47 ` Thomas Petazzoni [this message]
2019-11-19 7:47 ` [Buildroot] [PATCH v2,1/4] package/spice: disable tests Fabrice Fontaine
2019-11-19 8:15 ` Thomas Petazzoni
2019-11-22 22:14 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191118224703.3fb65955@windsurf.home \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox