From: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package
Date: Mon, 25 Nov 2019 23:12:21 +0100 [thread overview]
Message-ID: <20191125231221.743cd7ed@windsurf> (raw)
In-Reply-To: <20191121102324.35225-8-jerry.huang@nxp.com>
Hello,
On Thu, 21 Nov 2019 18:23:21 +0800
Changming Huang <jerry.huang@nxp.com> wrote:
> From: Jerry Huang <jerry.huang@nxp.com>
>
> This package provides the firmware for LS1028ARDB DP (display port).
>
> Signed-off-by: Jerry Huang <jerry.huang@nxp.com>
Overall, looks pretty good. Rename to nxp-qoriq-... if you decide to
use the nxp branding.
> diff --git a/DEVELOPERS b/DEVELOPERS
> index 9fbe229eb7..b15115f507 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -2545,3 +2545,6 @@ F: package/qjson/
> F: package/quazip/
> F: package/shapelib/
> F: package/tinc/
> +
> +N: Changming Huang <jerry.huang@nxp.com>
Please sort your name at the right place in the DEVELOPERS file
(alphabetic ordering).
> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> new file mode 100644
> index 0000000000..9259776750
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/Config.in
> @@ -0,0 +1,5 @@
> +config BR2_PACKAGE_FSL_QORIQ_CADENCE_DP_FW
> + bool "FSL QorIQ cadence DP firmware"
Just:
bool "fsl-qorirq-cadence-dp-fw
> + help
> + FSL QorIQ cadence DP firmware, a resident EL3 firmware.
> + link: http://www.nxp.com/lgfiles/sdk/lsdk1909/firmware-cadence-lsdk1909.bin
One empty line between the description and the upstream URL, and no
"link: " before the link. Also, pointing to the binary file itself is
not useful, we need an actual web page. If none exist, just don't
provide an upstream URL.
> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> new file mode 100644
> index 0000000000..bee912bee1
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.hash
> @@ -0,0 +1,2 @@
> +# Locally calculated
> +sha256 5871c5717be32f14a59624d5699d405e8ce9ae2e9c9ef86fd16e13d264a40e58 firmware-cadence-lsdk1909.bin
Hash of the license file is missing.
> diff --git a/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> new file mode 100644
> index 0000000000..d0d112e25f
> --- /dev/null
> +++ b/package/freescale-qoriq/fsl-qoriq-cadence-dp-fw/fsl-qoriq-cadence-dp-fw.mk
> @@ -0,0 +1,24 @@
> +################################################################################
> +#
> +# fsl-qoriq-cadence-dp-fw
> +#
> +################################################################################
> +
> +FSL_QORIQ_CADENCE_DP_FW_VERSION = lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SITE = http://www.nxp.com/lgfiles/sdk/lsdk1909
> +FSL_QORIQ_CADENCE_DP_FW_SOURCE = firmware-cadence-$(FSL_QORIQ_CADENCE_DP_FW_VERSION).bin
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE = NXP-Binary-EULA
> +FSL_QORIQ_CADENCE_DP_FW_LICENSE_FILES = COPYING
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES = YES
> +FSL_QORIQ_CADENCE_DP_FW_INSTALL_TARGET = no
Should be "NO" (upper_case)
> +
> +define FSL_QORIQ_CADENCE_DP_FW_EXTRACT_CMDS
> + cd $(@D); \
> + sh $(FSL_QORIQ_CADENCE_DP_FW_DL_DIR)/$(FSL_QORIQ_CADENCE_DP_FW_SOURCE) --auto-accept;
Final semi-colon not needed.
> +endef
> +
> +define FSL_QORIQ_CADENCE_DP_FW_INSTALL_IMAGES_CMDS
> + $(INSTALL) -D -m 0644 $(@D)/firmware-cadence-lsdk1909/dp/ls1028a-dp-fw.bin $(BINARIES_DIR)/ls1028a-dp-fw.bin
> +endef
> +
> +$(eval $(generic-package))
Thanks!
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2019-11-25 22:12 UTC|newest]
Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-21 10:23 [Buildroot] [PATCH v2 0/9] new board ls1028ardb introduced Changming Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 01/10] package/freescale-qoriq: new package directory Changming Huang
2019-11-25 21:13 ` Thomas Petazzoni
2019-11-26 2:49 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 02/10] package/freescale-qoriq/fsl-qoriq-rcw: move rcw into freescale-qoriq and rename it Changming Huang
2019-11-21 10:34 ` Michael Walle
2019-11-21 10:42 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 21:15 ` [Buildroot] " Thomas Petazzoni
2019-11-26 3:25 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 03/10] package/freescale-qoriq/fsl-qoriq-rcw: upgrade the rcw version to LSDK-19.09 Changming Huang
2019-11-25 21:17 ` Thomas Petazzoni
2019-11-26 3:51 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 04/10] package/freescale-qoriq/fsl-qoriq-rcw: add target rcw binary support Changming Huang
2019-11-25 21:23 ` Thomas Petazzoni
2019-11-26 4:33 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 05/10] boot/arm-trusted-firmware: Add option BR2_TARGET_ARM_TRUSTED_FIRMWARE_UBOOT_BL33_IMAGE Changming Huang
2019-11-22 9:11 ` Sergey Matyukevich
2019-11-22 9:24 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 21:59 ` [Buildroot] " Thomas Petazzoni
2019-11-21 10:23 ` [Buildroot] [PATCH v2 06/10] boot/arm-trusted-firmware: Add RCW support Changming Huang
2019-11-22 9:19 ` Sergey Matyukevich
2019-11-22 9:31 ` [Buildroot] [EXT] " Jerry Huang
2019-11-25 22:09 ` [Buildroot] " Thomas Petazzoni
2019-11-26 7:06 ` [Buildroot] [EXT] " Jerry Huang
2019-11-26 7:34 ` Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 07/10] package/freescale-qoriq/fsl-qoriq-cadence-dp-fw: new package Changming Huang
2019-11-21 10:42 ` Michael Walle
2019-11-21 11:04 ` [Buildroot] [EXT] " Jerry Huang
2019-11-22 10:41 ` Jerry Huang
2019-11-21 10:51 ` [Buildroot] " Michael Walle
2019-11-21 11:09 ` [Buildroot] [EXT] " Jerry Huang
2019-11-22 10:40 ` Jerry Huang
2019-11-22 11:00 ` Michael Walle
2019-11-25 2:40 ` Jerry Huang
2019-11-22 11:05 ` Thomas Petazzoni
2019-11-25 6:25 ` Jerry Huang
2019-11-25 22:12 ` Thomas Petazzoni [this message]
2019-11-26 8:09 ` Jerry Huang
2019-11-26 9:21 ` Michael Walle
2019-11-26 10:13 ` Jerry Huang
2019-11-26 9:29 ` Michael Walle
2019-11-26 10:12 ` Thomas Petazzoni
2019-11-26 10:31 ` Michael Walle
2019-11-26 12:10 ` Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 08/10] package/freescale-qoriq/fsl-qoriq-rcw:Enable IIC5_PMUX and CLK_OUT_PMUX for GPIO Changming Huang
2019-11-25 22:13 ` Thomas Petazzoni
2019-11-26 8:15 ` [Buildroot] [EXT] " Jerry Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 09/10] board/freescale/common/ls: Add standard post image script for Layerscape processors Changming Huang
2019-11-21 10:23 ` [Buildroot] [PATCH v2 10/10] configs/freescale_ls1028ardb*: new board Changming Huang
2019-11-25 22:17 ` Thomas Petazzoni
2019-11-26 12:02 ` [Buildroot] [EXT] " Jerry Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191125231221.743cd7ed@windsurf \
--to=thomas.petazzoni@bootlin.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox