[Buildroot] [PATCH v2 1/2] package/python-gobject: depend on python2

[Buildroot] [PATCH v2 1/2] package/python-gobject: depend on python2

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

Version 2.86.6 of python-gobject is quite old and no longer works with
Python versions > 3.7. When importing a user will recieve the following error:

Traceback (most recent call last):
  File "<stdin>", line 1, in <module>
  File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in
  <module>
  File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
SystemError: initialization of _glib raised unreported exception

Because new versions of python-gobject require gobject-introspection, which is
not currently available in Buildroot, add a dependency on python2 to prevent
users from receiving the above error.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
Changes v1 -> v2:
  - Add missing depends on in the comment section of python-gobject/Config.in
    (Thomas)

 package/python-gobject/Config.in | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/package/python-gobject/Config.in b/package/python-gobject/Config.in
index 475ff25185..36ddffebb0 100644
--- a/package/python-gobject/Config.in
+++ b/package/python-gobject/Config.in
@@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
 	depends on BR2_USE_WCHAR # libglib2
 	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
 	depends on BR2_USE_MMU # libglib2
+	depends on BR2_PACKAGE_PYTHON # Broken with python 3.8
 	select BR2_PACKAGE_LIBGLIB2
 	help
 	  Python bindings for the GLib/GObject library
@@ -10,5 +11,6 @@ config BR2_PACKAGE_PYTHON_GOBJECT
 	  https://wiki.gnome.org/action/show/Projects/PyGObject
 
 comment "python-gobject needs a toolchain w/ wchar, threads"
+	depends on BR2_PACKAGE_PYTHON
 	depends on BR2_USE_MMU
 	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
-- 
2.23.0

[Buildroot] [PATCH v2 2/2] support/testing: add python-gobject test

[aduskett at gmail.com]

From: Adam Duskett <Aduskett@gmail.com>

Add a simple test case that imports the module.

Signed-off-by: Adam Duskett <Aduskett@gmail.com>
---
 DEVELOPERS                                            |  1 +
 .../testing/tests/package/sample_python_gobject.py    |  1 +
 support/testing/tests/package/test_python_gobject.py  | 11 +++++++++++
 3 files changed, 13 insertions(+)
 create mode 100644 support/testing/tests/package/sample_python_gobject.py
 create mode 100644 support/testing/tests/package/test_python_gobject.py

diff --git a/DEVELOPERS b/DEVELOPERS
index 4adaac0c3d..c9fd98636e 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -74,6 +74,7 @@ F:	package/semodule-utils/
 F:	package/setools/
 F:	package/sngrep/
 F:	package/systemd/
+F:	support/testing/tests/package/test_python_gobject.py
 
 N:	Adam Heinrich <adam@adamh.cz>
 F:	package/jack1/
diff --git a/support/testing/tests/package/sample_python_gobject.py b/support/testing/tests/package/sample_python_gobject.py
new file mode 100644
index 0000000000..84ebee7362
--- /dev/null
+++ b/support/testing/tests/package/sample_python_gobject.py
@@ -0,0 +1 @@
+import gobject  # noqa
diff --git a/support/testing/tests/package/test_python_gobject.py b/support/testing/tests/package/test_python_gobject.py
new file mode 100644
index 0000000000..0a59447adb
--- /dev/null
+++ b/support/testing/tests/package/test_python_gobject.py
@@ -0,0 +1,11 @@
+from tests.package.test_python import TestPythonPackageBase
+
+
+class TestPythonPy2Gobject(TestPythonPackageBase):
+    __test__ = True
+    config = TestPythonPackageBase.config + \
+        """
+        BR2_PACKAGE_PYTHON=y
+        BR2_PACKAGE_PYTHON_GOBJECT=y
+        """
+    sample_scripts = ["tests/package/sample_python_gobject.py"]
-- 
2.23.0

[Buildroot] [PATCH v2 1/2] package/python-gobject: depend on python2

[Thomas Petazzoni]

On Sun,  1 Dec 2019 10:39:08 -0800
aduskett at gmail.com wrote:

> From: Adam Duskett <Aduskett@gmail.com>
> 
> Version 2.86.6 of python-gobject is quite old and no longer works with
> Python versions > 3.7. When importing a user will recieve the following error:
> 
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in
>   <module>
>   File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
> SystemError: initialization of _glib raised unreported exception
> 
> Because new versions of python-gobject require gobject-introspection, which is
> not currently available in Buildroot, add a dependency on python2 to prevent
> users from receiving the above error.

You forgot to add the reference to the bug being fixed, despite this
being noted in my review of v1. No need to resend just for that though.

Fixes:

  https://bugs.busybox.net/show_bug.cgi?id=12286

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

[Buildroot] [PATCH v2 1/2] package/python-gobject: depend on python2

[Arnout Vandecappelle]

On 01/12/2019 19:39, aduskett at gmail.com wrote:
> From: Adam Duskett <Aduskett@gmail.com>
> 
> Version 2.86.6 of python-gobject is quite old and no longer works with
> Python versions > 3.7. When importing a user will recieve the following error:
> 
> Traceback (most recent call last):
>   File "<stdin>", line 1, in <module>
>   File "/usr/lib/python3.8/site-packages/gobject/__init__.py", line 26, in
>   <module>
>   File "/usr/lib/python3.8/site-packages/glib/__init__.py", line 22, in <module>
> SystemError: initialization of _glib raised unreported exception
> 
> Because new versions of python-gobject require gobject-introspection, which is
> not currently available in Buildroot, add a dependency on python2 to prevent
> users from receiving the above error.
> 
> Signed-off-by: Adam Duskett <Aduskett@gmail.com>

 Both applied to master, thanks (after adding the Fixes: tag).

 Regards,
 Arnout

> ---
> Changes v1 -> v2:
>   - Add missing depends on in the comment section of python-gobject/Config.in
>     (Thomas)
> 
>  package/python-gobject/Config.in | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/package/python-gobject/Config.in b/package/python-gobject/Config.in
> index 475ff25185..36ddffebb0 100644
> --- a/package/python-gobject/Config.in
> +++ b/package/python-gobject/Config.in
> @@ -3,6 +3,7 @@ config BR2_PACKAGE_PYTHON_GOBJECT
>  	depends on BR2_USE_WCHAR # libglib2
>  	depends on BR2_TOOLCHAIN_HAS_THREADS # libglib2
>  	depends on BR2_USE_MMU # libglib2
> +	depends on BR2_PACKAGE_PYTHON # Broken with python 3.8
>  	select BR2_PACKAGE_LIBGLIB2
>  	help
>  	  Python bindings for the GLib/GObject library
> @@ -10,5 +11,6 @@ config BR2_PACKAGE_PYTHON_GOBJECT
>  	  https://wiki.gnome.org/action/show/Projects/PyGObject
>  
>  comment "python-gobject needs a toolchain w/ wchar, threads"
> +	depends on BR2_PACKAGE_PYTHON
>  	depends on BR2_USE_MMU
>  	depends on !BR2_USE_WCHAR || !BR2_TOOLCHAIN_HAS_THREADS
>