* [Buildroot] [PATCH] package/cryptsetup: use libargon2 when available
@ 2019-12-03 9:27 Pascal de Bruijn
2019-12-03 9:52 ` Thomas Petazzoni
0 siblings, 1 reply; 2+ messages in thread
From: Pascal de Bruijn @ 2019-12-03 9:27 UTC (permalink / raw)
To: buildroot
cryptsetup has an internal copy of libargon2, which is used by default,
but when libargon2 is available as a proper system library this is a
duplication.
Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
---
package/cryptsetup/cryptsetup.mk | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk
index 7788bfb..2941328 100644
--- a/package/cryptsetup/cryptsetup.mk
+++ b/package/cryptsetup/cryptsetup.mk
@@ -29,6 +29,10 @@ else
CRYPTSETUP_CONF_OPTS += --with-crypto_backend=kernel
endif
+ifeq ($(BR2_PACKAGE_LIBARGON2),y)
+CRYPTSETUP_CONF_OPTS += --enable-libargon2
+endif
+
HOST_CRYPTSETUP_DEPENDENCIES = \
host-pkgconf \
host-lvm2 \
--
2.7.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* [Buildroot] [PATCH] package/cryptsetup: use libargon2 when available
2019-12-03 9:27 [Buildroot] [PATCH] package/cryptsetup: use libargon2 when available Pascal de Bruijn
@ 2019-12-03 9:52 ` Thomas Petazzoni
0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-12-03 9:52 UTC (permalink / raw)
To: buildroot
Hello,
On Tue, 3 Dec 2019 10:27:15 +0100
Pascal de Bruijn <p.debruijn@unilogic.nl> wrote:
> cryptsetup has an internal copy of libargon2, which is used by default,
> but when libargon2 is available as a proper system library this is a
> duplication.
>
> Signed-off-by: Pascal de Bruijn <p.debruijn@unilogic.nl>
> ---
> package/cryptsetup/cryptsetup.mk | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/package/cryptsetup/cryptsetup.mk b/package/cryptsetup/cryptsetup.mk
> index 7788bfb..2941328 100644
> --- a/package/cryptsetup/cryptsetup.mk
> +++ b/package/cryptsetup/cryptsetup.mk
> @@ -29,6 +29,10 @@ else
> CRYPTSETUP_CONF_OPTS += --with-crypto_backend=kernel
> endif
>
> +ifeq ($(BR2_PACKAGE_LIBARGON2),y)
> +CRYPTSETUP_CONF_OPTS += --enable-libargon2
> +endif
Then we want to use --disable-libargon2 when the libargon2 package is
not enabled. If libargon2 is mandatory for crypsetup, then we always
want to use the separate package rather than the internal copy from
cryptsetup.
Thanks,
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-12-03 9:52 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-03 9:27 [Buildroot] [PATCH] package/cryptsetup: use libargon2 when available Pascal de Bruijn
2019-12-03 9:52 ` Thomas Petazzoni
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox