Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH 1/1] package/php: libargon2 needs dynamic library
@ 2019-12-04 18:11 Fabrice Fontaine
  2019-12-05 21:43 ` Thomas Petazzoni
  0 siblings, 1 reply; 2+ messages in thread
From: Fabrice Fontaine @ 2019-12-04 18:11 UTC (permalink / raw)
  To: buildroot

Fixes:
 - http://autobuild.buildroot.org/results/72412a68da44d7ecc87656436a17542cafcf1f95

Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
---
 package/php/Config.ext | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/package/php/Config.ext b/package/php/Config.ext
index d5c723ca39..b3d6088f54 100644
--- a/package/php/Config.ext
+++ b/package/php/Config.ext
@@ -70,8 +70,12 @@ config BR2_PACKAGE_PHP_EXT_HASH
 	help
 	  HASH message digest framework
 
+comment "libargon2 needs a toolchain w/ dynamic library"
+	depends on BR2_STATIC_LIBS
+
 config BR2_PACKAGE_PHP_EXT_LIBARGON2
 	bool "libargon2"
+	depends on !BR2_STATIC_LIBS # libargon2
 	select BR2_PACKAGE_LIBARGON2
 	help
 	  libargon2 support
-- 
2.24.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [Buildroot] [PATCH 1/1] package/php: libargon2 needs dynamic library
  2019-12-04 18:11 [Buildroot] [PATCH 1/1] package/php: libargon2 needs dynamic library Fabrice Fontaine
@ 2019-12-05 21:43 ` Thomas Petazzoni
  0 siblings, 0 replies; 2+ messages in thread
From: Thomas Petazzoni @ 2019-12-05 21:43 UTC (permalink / raw)
  To: buildroot

On Wed,  4 Dec 2019 19:11:41 +0100
Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:

> Fixes:
>  - http://autobuild.buildroot.org/results/72412a68da44d7ecc87656436a17542cafcf1f95
> 
> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
> ---
>  package/php/Config.ext | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/package/php/Config.ext b/package/php/Config.ext
> index d5c723ca39..b3d6088f54 100644
> --- a/package/php/Config.ext
> +++ b/package/php/Config.ext
> @@ -70,8 +70,12 @@ config BR2_PACKAGE_PHP_EXT_HASH
>  	help
>  	  HASH message digest framework
>  
> +comment "libargon2 needs a toolchain w/ dynamic library"
> +	depends on BR2_STATIC_LIBS
> +
>  config BR2_PACKAGE_PHP_EXT_LIBARGON2
>  	bool "libargon2"
> +	depends on !BR2_STATIC_LIBS # libargon2

You forgot to propagate the BR2_USE_MMU dependency of libargon2, so I
fixed that as well when applying.

Thanks!

Thomas
-- 
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2019-12-05 21:43 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-12-04 18:11 [Buildroot] [PATCH 1/1] package/php: libargon2 needs dynamic library Fabrice Fontaine
2019-12-05 21:43 ` Thomas Petazzoni

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox